SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.7.0

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes 106 182 0 0

Files

org.woehlke.jakartaee.petclinic.application.views.FlashMessagesViewImpl

Bug Category Details Line Priority Load of known null value in org.woehlke.jakartaee.petclinic.application.views.FlashMessagesViewImpl.flashTheMessages() STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 37 Low

org.woehlke.jakartaee.petclinic.application.views.LanguageViewImpl

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.application.views.LanguageViewImpl.getCountries() may expose internal representation by returning LanguageViewImpl.countries MALICIOUS_CODE EI_EXPOSE_REP 66 Medium org.woehlke.jakartaee.petclinic.application.views.LanguageViewImpl.getFlashMessagesView() may expose internal representation by returning LanguageViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP 45 Medium org.woehlke.jakartaee.petclinic.application.views.LanguageViewImpl.getLOCALE_OPTIONS() may expose internal representation by returning LanguageViewImpl.LOCALE_OPTIONS MALICIOUS_CODE EI_EXPOSE_REP 39 Medium org.woehlke.jakartaee.petclinic.application.views.LanguageViewImpl.getPetclinicApplication() may expose internal representation by returning LanguageViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP 42 Medium org.woehlke.jakartaee.petclinic.application.views.LanguageViewImpl.setFlashMessagesView(FlashMessagesView) may expose internal representation by storing an externally mutable object into LanguageViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP2 31 Medium org.woehlke.jakartaee.petclinic.application.views.LanguageViewImpl.setPetclinicApplication(PetclinicApplication) may expose internal representation by storing an externally mutable object into LanguageViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP2 31 Medium

org.woehlke.jakartaee.petclinic.owner.Owner

Bug Category Details Line Priority Confusing to have methods org.woehlke.jakartaee.petclinic.owner.Owner.getFullName() and org.woehlke.jakartaee.petclinic.vet.Vet.getFullname() BAD_PRACTICE NM_CONFUSING 176 Low

org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl

Bug Category Details Line Priority Dead store to e in org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.deleteSelectedEntity() STYLE DLS_DEAD_LOCAL_STORE 451 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getEntity() may expose internal representation by returning OwnerViewImpl.entity MALICIOUS_CODE EI_EXPOSE_REP 75 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getFlashMessagesView() may expose internal representation by returning OwnerViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP 51 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getLanguageView() may expose internal representation by returning OwnerViewImpl.languageView MALICIOUS_CODE EI_EXPOSE_REP 48 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getList() may expose internal representation by returning OwnerViewImpl.list MALICIOUS_CODE EI_EXPOSE_REP 480 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getOwnerFlowView() may expose internal representation by returning OwnerViewImpl.ownerFlowView MALICIOUS_CODE EI_EXPOSE_REP 54 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getOwnerViewService() may expose internal representation by returning OwnerViewImpl.ownerViewService MALICIOUS_CODE EI_EXPOSE_REP 71 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getPet() may expose internal representation by returning OwnerViewImpl.pet MALICIOUS_CODE EI_EXPOSE_REP 76 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getPetTypeList() may expose internal representation by returning OwnerViewImpl.petTypeList MALICIOUS_CODE EI_EXPOSE_REP 392 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getPetclinicApplication() may expose internal representation by returning OwnerViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP 45 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.getVisit() may expose internal representation by returning OwnerViewImpl.visit MALICIOUS_CODE EI_EXPOSE_REP 79 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setEntity(Owner) may expose internal representation by storing an externally mutable object into OwnerViewImpl.entity MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setFlashMessagesView(FlashMessagesView) may expose internal representation by storing an externally mutable object into OwnerViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setLanguageView(LanguageView) may expose internal representation by storing an externally mutable object into OwnerViewImpl.languageView MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setList(List) may expose internal representation by storing an externally mutable object into OwnerViewImpl.list MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setOwnerFlowView(OwnerFlowView) may expose internal representation by storing an externally mutable object into OwnerViewImpl.ownerFlowView MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setOwnerViewService(OwnerViewService) may expose internal representation by storing an externally mutable object into OwnerViewImpl.ownerViewService MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setPet(Pet) may expose internal representation by storing an externally mutable object into OwnerViewImpl.pet MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setPetTypeList(List) may expose internal representation by storing an externally mutable object into OwnerViewImpl.petTypeList MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setPetclinicApplication(PetclinicApplication) may expose internal representation by storing an externally mutable object into OwnerViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium org.woehlke.jakartaee.petclinic.owner.OwnerViewImpl.setVisit(Visit) may expose internal representation by storing an externally mutable object into OwnerViewImpl.visit MALICIOUS_CODE EI_EXPOSE_REP2 37 Medium

org.woehlke.jakartaee.petclinic.owner.api.OwnerDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.owner.api.OwnerDto.getPetList() may expose internal representation by returning OwnerDto.petList MALICIOUS_CODE EI_EXPOSE_REP 74 Medium new org.woehlke.jakartaee.petclinic.owner.api.OwnerDto(Long, UUID, String, String, String, String, String, String, String, String, PetListDto) may expose internal representation by storing an externally mutable object into OwnerDto.petList MALICIOUS_CODE EI_EXPOSE_REP2 25 Medium org.woehlke.jakartaee.petclinic.owner.api.OwnerDto.setPetList(PetListDto) may expose internal representation by storing an externally mutable object into OwnerDto.petList MALICIOUS_CODE EI_EXPOSE_REP2 21 Medium

org.woehlke.jakartaee.petclinic.owner.api.OwnerListDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.owner.api.OwnerListDto.getOwner() may expose internal representation by returning OwnerListDto.owner MALICIOUS_CODE EI_EXPOSE_REP 26 Medium new org.woehlke.jakartaee.petclinic.owner.api.OwnerListDto(List) may expose internal representation by storing an externally mutable object into OwnerListDto.owner MALICIOUS_CODE EI_EXPOSE_REP2 19 Medium org.woehlke.jakartaee.petclinic.owner.api.OwnerListDto.setOwner(List) may expose internal representation by storing an externally mutable object into OwnerListDto.owner MALICIOUS_CODE EI_EXPOSE_REP2 16 Medium

org.woehlke.jakartaee.petclinic.owner.db.OwnerDaoImpl

Bug Category Details Line Priority Class org.woehlke.jakartaee.petclinic.owner.db.OwnerDaoImpl defines non-transient non-serializable instance field entityManager BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.woehlke.jakartaee.petclinic.owner.db.OwnerListener

Bug Category Details Line Priority Dead store to correctType in org.woehlke.jakartaee.petclinic.owner.db.OwnerListener.onPostLoad(Object) STYLE DLS_DEAD_LOCAL_STORE 65 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.owner.db.OwnerListener.onPostPersist(Object) STYLE DLS_DEAD_LOCAL_STORE 44 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.owner.db.OwnerListener.onPostRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 58 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.owner.db.OwnerListener.onPostUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 51 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.owner.db.OwnerListener.onPrePersist(Object) STYLE DLS_DEAD_LOCAL_STORE 23 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.owner.db.OwnerListener.onPreRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 37 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.owner.db.OwnerListener.onPreUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 30 Medium

org.woehlke.jakartaee.petclinic.owner.db.OwnerServiceImpl

Bug Category Details Line Priority Private method org.woehlke.jakartaee.petclinic.owner.db.OwnerServiceImpl.updateSearchindex(Owner) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 116-122 Low

org.woehlke.jakartaee.petclinic.pet.Pet

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.pet.Pet.getBirthDate() may expose internal representation by returning Pet.birthDate MALICIOUS_CODE EI_EXPOSE_REP 87 Medium org.woehlke.jakartaee.petclinic.pet.Pet.getOwner() may expose internal representation by returning Pet.owner MALICIOUS_CODE EI_EXPOSE_REP 112 Medium org.woehlke.jakartaee.petclinic.pet.Pet.getType() may expose internal representation by returning Pet.type MALICIOUS_CODE EI_EXPOSE_REP 102 Medium new org.woehlke.jakartaee.petclinic.pet.Pet(Long, UUID, String, Date, String, PetType, Owner) may expose internal representation by storing an externally mutable object into Pet.birthDate MALICIOUS_CODE EI_EXPOSE_REP2 31 Medium new org.woehlke.jakartaee.petclinic.pet.Pet(Long, UUID, String, Date, String, PetType, Owner) may expose internal representation by storing an externally mutable object into Pet.owner MALICIOUS_CODE EI_EXPOSE_REP2 31 Medium new org.woehlke.jakartaee.petclinic.pet.Pet(Long, UUID, String, Date, String, PetType, Owner) may expose internal representation by storing an externally mutable object into Pet.type MALICIOUS_CODE EI_EXPOSE_REP2 31 Medium org.woehlke.jakartaee.petclinic.pet.Pet.setBirthDate(Date) may expose internal representation by storing an externally mutable object into Pet.birthDate MALICIOUS_CODE EI_EXPOSE_REP2 28 Medium org.woehlke.jakartaee.petclinic.pet.Pet.setOwner(Owner) may expose internal representation by storing an externally mutable object into Pet.owner MALICIOUS_CODE EI_EXPOSE_REP2 28 Medium org.woehlke.jakartaee.petclinic.pet.Pet.setType(PetType) may expose internal representation by storing an externally mutable object into Pet.type MALICIOUS_CODE EI_EXPOSE_REP2 28 Medium Class org.woehlke.jakartaee.petclinic.pet.Pet implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 26-155 Low

org.woehlke.jakartaee.petclinic.pet.PetEndpoint

Bug Category Details Line Priority Private method org.woehlke.jakartaee.petclinic.pet.PetEndpoint.dtoJsonFactory(PetDto) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 41-42 Low

org.woehlke.jakartaee.petclinic.pet.api.PetDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.pet.api.PetDto.getBirthDate() may expose internal representation by returning PetDto.birthDate MALICIOUS_CODE EI_EXPOSE_REP 52 Medium org.woehlke.jakartaee.petclinic.pet.api.PetDto.getPetType() may expose internal representation by returning PetDto.petType MALICIOUS_CODE EI_EXPOSE_REP 56 Medium org.woehlke.jakartaee.petclinic.pet.api.PetDto.getVisitList() may expose internal representation by returning PetDto.visitList MALICIOUS_CODE EI_EXPOSE_REP 60 Medium new org.woehlke.jakartaee.petclinic.pet.api.PetDto(Long, UUID, String, Date, PetTypeDto, VisitListDto) may expose internal representation by storing an externally mutable object into PetDto.birthDate MALICIOUS_CODE EI_EXPOSE_REP2 31 Medium new org.woehlke.jakartaee.petclinic.pet.api.PetDto(Long, UUID, String, Date, PetTypeDto, VisitListDto) may expose internal representation by storing an externally mutable object into PetDto.petType MALICIOUS_CODE EI_EXPOSE_REP2 31 Medium new org.woehlke.jakartaee.petclinic.pet.api.PetDto(Long, UUID, String, Date, PetTypeDto, VisitListDto) may expose internal representation by storing an externally mutable object into PetDto.visitList MALICIOUS_CODE EI_EXPOSE_REP2 31 Medium org.woehlke.jakartaee.petclinic.pet.api.PetDto.setBirthDate(Date) may expose internal representation by storing an externally mutable object into PetDto.birthDate MALICIOUS_CODE EI_EXPOSE_REP2 27 Medium org.woehlke.jakartaee.petclinic.pet.api.PetDto.setPetType(PetTypeDto) may expose internal representation by storing an externally mutable object into PetDto.petType MALICIOUS_CODE EI_EXPOSE_REP2 27 Medium org.woehlke.jakartaee.petclinic.pet.api.PetDto.setVisitList(VisitListDto) may expose internal representation by storing an externally mutable object into PetDto.visitList MALICIOUS_CODE EI_EXPOSE_REP2 27 Medium

org.woehlke.jakartaee.petclinic.pet.api.PetListDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.pet.api.PetListDto.getPet() may expose internal representation by returning PetListDto.pet MALICIOUS_CODE EI_EXPOSE_REP 26 Medium new org.woehlke.jakartaee.petclinic.pet.api.PetListDto(List) may expose internal representation by storing an externally mutable object into PetListDto.pet MALICIOUS_CODE EI_EXPOSE_REP2 19 Medium org.woehlke.jakartaee.petclinic.pet.api.PetListDto.setPet(List) may expose internal representation by storing an externally mutable object into PetListDto.pet MALICIOUS_CODE EI_EXPOSE_REP2 16 Medium

org.woehlke.jakartaee.petclinic.pet.db.PetDaoImpl

Bug Category Details Line Priority Class org.woehlke.jakartaee.petclinic.pet.db.PetDaoImpl defines non-transient non-serializable instance field entityManager BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.woehlke.jakartaee.petclinic.pet.db.PetListener

Bug Category Details Line Priority Dead store to correctType in org.woehlke.jakartaee.petclinic.pet.db.PetListener.onPostLoad(Object) STYLE DLS_DEAD_LOCAL_STORE 65 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pet.db.PetListener.onPostPersist(Object) STYLE DLS_DEAD_LOCAL_STORE 44 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pet.db.PetListener.onPostRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 58 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pet.db.PetListener.onPostUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 51 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pet.db.PetListener.onPrePersist(Object) STYLE DLS_DEAD_LOCAL_STORE 23 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pet.db.PetListener.onPreRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 37 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pet.db.PetListener.onPreUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 30 Medium

org.woehlke.jakartaee.petclinic.pettype.PetType

Bug Category Details Line Priority Class org.woehlke.jakartaee.petclinic.pettype.PetType implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 25-143 Low

org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl

Bug Category Details Line Priority Dead store to e in org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.deleteSelectedEntity() STYLE DLS_DEAD_LOCAL_STORE 261 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.getEntity() may expose internal representation by returning PetTypeViewImpl.entity MALICIOUS_CODE EI_EXPOSE_REP 193 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.getFlashMessagesView() may expose internal representation by returning PetTypeViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP 48 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.getLanguageView() may expose internal representation by returning PetTypeViewImpl.languageView MALICIOUS_CODE EI_EXPOSE_REP 45 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.getList() may expose internal representation by returning PetTypeViewImpl.list MALICIOUS_CODE EI_EXPOSE_REP 303 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.getPetTypeViewFlow() may expose internal representation by returning PetTypeViewImpl.petTypeViewFlow MALICIOUS_CODE EI_EXPOSE_REP 51 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.getPetclinicApplication() may expose internal representation by returning PetTypeViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP 42 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.setEntity(PetType) may expose internal representation by storing an externally mutable object into PetTypeViewImpl.entity MALICIOUS_CODE EI_EXPOSE_REP2 34 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.setFlashMessagesView(FlashMessagesView) may expose internal representation by storing an externally mutable object into PetTypeViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP2 34 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.setLanguageView(LanguageView) may expose internal representation by storing an externally mutable object into PetTypeViewImpl.languageView MALICIOUS_CODE EI_EXPOSE_REP2 34 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.setList(List) may expose internal representation by storing an externally mutable object into PetTypeViewImpl.list MALICIOUS_CODE EI_EXPOSE_REP2 34 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.setPetTypeViewFlow(PetTypeFlowViewImpl) may expose internal representation by storing an externally mutable object into PetTypeViewImpl.petTypeViewFlow MALICIOUS_CODE EI_EXPOSE_REP2 34 Medium org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.setPetclinicApplication(PetclinicApplication) may expose internal representation by storing an externally mutable object into PetTypeViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP2 34 Medium Possible null pointer dereference of PetTypeViewImpl.entity in org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.saveEditedEntity() CORRECTNESS NP_NULL_ON_SOME_PATH 232 High Possible null pointer dereference of PetTypeViewImpl.entity in org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.saveEditedEntity() CORRECTNESS NP_NULL_ON_SOME_PATH 238 High Possible null pointer dereference of PetTypeViewImpl.entity in org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.saveNewEntity() CORRECTNESS NP_NULL_ON_SOME_PATH 211 High Possible null pointer dereference of PetTypeViewImpl.entity in org.woehlke.jakartaee.petclinic.pettype.PetTypeViewImpl.saveNewEntity() CORRECTNESS NP_NULL_ON_SOME_PATH 217 High

org.woehlke.jakartaee.petclinic.pettype.api.PetTypeListDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.pettype.api.PetTypeListDto.getPetType() may expose internal representation by returning PetTypeListDto.petType MALICIOUS_CODE EI_EXPOSE_REP 25 Medium new org.woehlke.jakartaee.petclinic.pettype.api.PetTypeListDto(List) may expose internal representation by storing an externally mutable object into PetTypeListDto.petType MALICIOUS_CODE EI_EXPOSE_REP2 18 Medium org.woehlke.jakartaee.petclinic.pettype.api.PetTypeListDto.setPetType(List) may expose internal representation by storing an externally mutable object into PetTypeListDto.petType MALICIOUS_CODE EI_EXPOSE_REP2 15 Medium

org.woehlke.jakartaee.petclinic.pettype.db.PetTypeDaoImpl

Bug Category Details Line Priority Class org.woehlke.jakartaee.petclinic.pettype.db.PetTypeDaoImpl defines non-transient non-serializable instance field entityManager BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.woehlke.jakartaee.petclinic.pettype.db.PetTypeListener

Bug Category Details Line Priority Dead store to correctType in org.woehlke.jakartaee.petclinic.pettype.db.PetTypeListener.onPostLoad(Object) STYLE DLS_DEAD_LOCAL_STORE 66 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pettype.db.PetTypeListener.onPostPersist(Object) STYLE DLS_DEAD_LOCAL_STORE 45 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pettype.db.PetTypeListener.onPostRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 59 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pettype.db.PetTypeListener.onPostUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 52 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pettype.db.PetTypeListener.onPrePersist(Object) STYLE DLS_DEAD_LOCAL_STORE 24 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pettype.db.PetTypeListener.onPreRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 38 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.pettype.db.PetTypeListener.onPreUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 31 Medium

org.woehlke.jakartaee.petclinic.specialty.Specialty

Bug Category Details Line Priority Class org.woehlke.jakartaee.petclinic.specialty.Specialty implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 24-144 Low

org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl

Bug Category Details Line Priority Dead store to e in org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.deleteSelectedEntity() STYLE DLS_DEAD_LOCAL_STORE 225 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.getEntity() may expose internal representation by returning SpecialtyViewImpl.entity MALICIOUS_CODE EI_EXPOSE_REP 40 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.getFlashMessagesView() may expose internal representation by returning SpecialtyViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP 52 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.getLanguageView() may expose internal representation by returning SpecialtyViewImpl.languageView MALICIOUS_CODE EI_EXPOSE_REP 49 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.getList() may expose internal representation by returning SpecialtyViewImpl.list MALICIOUS_CODE EI_EXPOSE_REP 271 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.getPetclinicApplication() may expose internal representation by returning SpecialtyViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP 46 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.setEntity(Specialty) may expose internal representation by storing an externally mutable object into SpecialtyViewImpl.entity MALICIOUS_CODE EI_EXPOSE_REP2 33 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.setFlashMessagesView(FlashMessagesView) may expose internal representation by storing an externally mutable object into SpecialtyViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP2 33 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.setLanguageView(LanguageView) may expose internal representation by storing an externally mutable object into SpecialtyViewImpl.languageView MALICIOUS_CODE EI_EXPOSE_REP2 33 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.setList(List) may expose internal representation by storing an externally mutable object into SpecialtyViewImpl.list MALICIOUS_CODE EI_EXPOSE_REP2 33 Medium org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.setPetclinicApplication(PetclinicApplication) may expose internal representation by storing an externally mutable object into SpecialtyViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP2 33 Medium Exception is caught when Exception is not thrown in org.woehlke.jakartaee.petclinic.specialty.SpecialtyViewImpl.performSearch() STYLE REC_CATCH_EXCEPTION 256

org.woehlke.jakartaee.petclinic.specialty.api.SpecialtyListDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.specialty.api.SpecialtyListDto.getSpecialty() may expose internal representation by returning SpecialtyListDto.specialty MALICIOUS_CODE EI_EXPOSE_REP 26 Medium new org.woehlke.jakartaee.petclinic.specialty.api.SpecialtyListDto(List) may expose internal representation by storing an externally mutable object into SpecialtyListDto.specialty MALICIOUS_CODE EI_EXPOSE_REP2 19 Medium org.woehlke.jakartaee.petclinic.specialty.api.SpecialtyListDto.setSpecialty(List) may expose internal representation by storing an externally mutable object into SpecialtyListDto.specialty MALICIOUS_CODE EI_EXPOSE_REP2 16 Medium

org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyDaoImpl

Bug Category Details Line Priority Class org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyDaoImpl defines non-transient non-serializable instance field entityManager BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyListener

Bug Category Details Line Priority Dead store to correctType in org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyListener.onPostLoad(Object) STYLE DLS_DEAD_LOCAL_STORE 62 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyListener.onPostPersist(Object) STYLE DLS_DEAD_LOCAL_STORE 41 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyListener.onPostRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 55 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyListener.onPostUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 48 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyListener.onPrePersist(Object) STYLE DLS_DEAD_LOCAL_STORE 20 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyListener.onPreRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 34 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.specialty.db.SpecialtyListener.onPreUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 27 Medium

org.woehlke.jakartaee.petclinic.vet.Vet

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.vet.Vet.getSpecialties() may expose internal representation by returning Vet.specialties MALICIOUS_CODE EI_EXPOSE_REP 93 Medium new org.woehlke.jakartaee.petclinic.vet.Vet(Long, UUID, String, String, String, Set) may expose internal representation by storing an externally mutable object into Vet.specialties MALICIOUS_CODE EI_EXPOSE_REP2 29 Medium org.woehlke.jakartaee.petclinic.vet.Vet.setSpecialties(Set) may expose internal representation by storing an externally mutable object into Vet.specialties MALICIOUS_CODE EI_EXPOSE_REP2 26 Medium Class org.woehlke.jakartaee.petclinic.vet.Vet implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 24-198 Low

org.woehlke.jakartaee.petclinic.vet.VetViewImpl

Bug Category Details Line Priority Dead store to e in org.woehlke.jakartaee.petclinic.vet.VetViewImpl.deleteSelectedEntity() STYLE DLS_DEAD_LOCAL_STORE 252 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.getEntity() may expose internal representation by returning VetViewImpl.entity MALICIOUS_CODE EI_EXPOSE_REP 62 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.getFlashMessagesView() may expose internal representation by returning VetViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP 50 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.getLanguageView() may expose internal representation by returning VetViewImpl.languageView MALICIOUS_CODE EI_EXPOSE_REP 47 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.getList() may expose internal representation by returning VetViewImpl.list MALICIOUS_CODE EI_EXPOSE_REP 314 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.getPetclinicApplication() may expose internal representation by returning VetViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP 44 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.getSpecialtiesPickList() may expose internal representation by returning VetViewImpl.specialtiesPickList MALICIOUS_CODE EI_EXPOSE_REP 63 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.getVetViewFlow() may expose internal representation by returning VetViewImpl.vetViewFlow MALICIOUS_CODE EI_EXPOSE_REP 53 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.setEntity(Vet) may expose internal representation by storing an externally mutable object into VetViewImpl.entity MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.setFlashMessagesView(FlashMessagesView) may expose internal representation by storing an externally mutable object into VetViewImpl.flashMessagesView MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.setLanguageView(LanguageView) may expose internal representation by storing an externally mutable object into VetViewImpl.languageView MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.setList(List) may expose internal representation by storing an externally mutable object into VetViewImpl.list MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.setPetclinicApplication(PetclinicApplication) may expose internal representation by storing an externally mutable object into VetViewImpl.petclinicApplication MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.setSpecialtiesPickList(DualListModel) may expose internal representation by storing an externally mutable object into VetViewImpl.specialtiesPickList MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium org.woehlke.jakartaee.petclinic.vet.VetViewImpl.setVetViewFlow(VetFlowViewImpl) may expose internal representation by storing an externally mutable object into VetViewImpl.vetViewFlow MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium

org.woehlke.jakartaee.petclinic.vet.api.VetDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.vet.api.VetDto.getSpecialtyList() may expose internal representation by returning VetDto.specialtyList MALICIOUS_CODE EI_EXPOSE_REP 52 Medium new org.woehlke.jakartaee.petclinic.vet.api.VetDto(Long, UUID, String, String, SpecialtyListDto) may expose internal representation by storing an externally mutable object into VetDto.specialtyList MALICIOUS_CODE EI_EXPOSE_REP2 28 Medium org.woehlke.jakartaee.petclinic.vet.api.VetDto.setSpecialtyList(SpecialtyListDto) may expose internal representation by storing an externally mutable object into VetDto.specialtyList MALICIOUS_CODE EI_EXPOSE_REP2 24 Medium

org.woehlke.jakartaee.petclinic.vet.api.VetListDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.vet.api.VetListDto.getVetList() may expose internal representation by returning VetListDto.vetList MALICIOUS_CODE EI_EXPOSE_REP 30 Medium new org.woehlke.jakartaee.petclinic.vet.api.VetListDto(List) may expose internal representation by storing an externally mutable object into VetListDto.vetList MALICIOUS_CODE EI_EXPOSE_REP2 23 Medium org.woehlke.jakartaee.petclinic.vet.api.VetListDto.setVetList(List) may expose internal representation by storing an externally mutable object into VetListDto.vetList MALICIOUS_CODE EI_EXPOSE_REP2 20 Medium

org.woehlke.jakartaee.petclinic.vet.db.VetDaoImpl

Bug Category Details Line Priority Class org.woehlke.jakartaee.petclinic.vet.db.VetDaoImpl defines non-transient non-serializable instance field entityManager BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.woehlke.jakartaee.petclinic.vet.db.VetListener

Bug Category Details Line Priority Dead store to correctType in org.woehlke.jakartaee.petclinic.vet.db.VetListener.onPostLoad(Object) STYLE DLS_DEAD_LOCAL_STORE 63 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.vet.db.VetListener.onPostPersist(Object) STYLE DLS_DEAD_LOCAL_STORE 42 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.vet.db.VetListener.onPostRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 56 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.vet.db.VetListener.onPostUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 49 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.vet.db.VetListener.onPrePersist(Object) STYLE DLS_DEAD_LOCAL_STORE 21 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.vet.db.VetListener.onPreRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 35 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.vet.db.VetListener.onPreUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 28 Medium

org.woehlke.jakartaee.petclinic.visit.Visit

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.visit.Visit.getDate() may expose internal representation by returning Visit.date MALICIOUS_CODE EI_EXPOSE_REP 85 Medium org.woehlke.jakartaee.petclinic.visit.Visit.getPet() may expose internal representation by returning Visit.pet MALICIOUS_CODE EI_EXPOSE_REP 98 Medium new org.woehlke.jakartaee.petclinic.visit.Visit(Long, UUID, String, Date, String, Pet) may expose internal representation by storing an externally mutable object into Visit.date MALICIOUS_CODE EI_EXPOSE_REP2 29 Medium new org.woehlke.jakartaee.petclinic.visit.Visit(Long, UUID, String, Date, String, Pet) may expose internal representation by storing an externally mutable object into Visit.pet MALICIOUS_CODE EI_EXPOSE_REP2 29 Medium org.woehlke.jakartaee.petclinic.visit.Visit.setDate(Date) may expose internal representation by storing an externally mutable object into Visit.date MALICIOUS_CODE EI_EXPOSE_REP2 26 Medium org.woehlke.jakartaee.petclinic.visit.Visit.setPet(Pet) may expose internal representation by storing an externally mutable object into Visit.pet MALICIOUS_CODE EI_EXPOSE_REP2 26 Medium Class org.woehlke.jakartaee.petclinic.visit.Visit implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 24-151 Low

org.woehlke.jakartaee.petclinic.visit.api.VisitDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.visit.api.VisitDto.getDate() may expose internal representation by returning VisitDto.date MALICIOUS_CODE EI_EXPOSE_REP 44 Medium new org.woehlke.jakartaee.petclinic.visit.api.VisitDto(Long, UUID, Date, String) may expose internal representation by storing an externally mutable object into VisitDto.date MALICIOUS_CODE EI_EXPOSE_REP2 27 Medium org.woehlke.jakartaee.petclinic.visit.api.VisitDto.setDate(Date) may expose internal representation by storing an externally mutable object into VisitDto.date MALICIOUS_CODE EI_EXPOSE_REP2 23 Medium

org.woehlke.jakartaee.petclinic.visit.api.VisitListDto

Bug Category Details Line Priority org.woehlke.jakartaee.petclinic.visit.api.VisitListDto.getVisit() may expose internal representation by returning VisitListDto.visit MALICIOUS_CODE EI_EXPOSE_REP 27 Medium new org.woehlke.jakartaee.petclinic.visit.api.VisitListDto(List) may expose internal representation by storing an externally mutable object into VisitListDto.visit MALICIOUS_CODE EI_EXPOSE_REP2 20 Medium org.woehlke.jakartaee.petclinic.visit.api.VisitListDto.setVisit(List) may expose internal representation by storing an externally mutable object into VisitListDto.visit MALICIOUS_CODE EI_EXPOSE_REP2 16 Medium

org.woehlke.jakartaee.petclinic.visit.db.VisitDaoImpl

Bug Category Details Line Priority Class org.woehlke.jakartaee.petclinic.visit.db.VisitDaoImpl defines non-transient non-serializable instance field entityManager BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.woehlke.jakartaee.petclinic.visit.db.VisitListener

Bug Category Details Line Priority Dead store to correctType in org.woehlke.jakartaee.petclinic.visit.db.VisitListener.onPostLoad(Object) STYLE DLS_DEAD_LOCAL_STORE 66 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.visit.db.VisitListener.onPostPersist(Object) STYLE DLS_DEAD_LOCAL_STORE 45 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.visit.db.VisitListener.onPostRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 59 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.visit.db.VisitListener.onPostUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 52 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.visit.db.VisitListener.onPrePersist(Object) STYLE DLS_DEAD_LOCAL_STORE 23 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.visit.db.VisitListener.onPreRemove(Object) STYLE DLS_DEAD_LOCAL_STORE 38 Medium Dead store to correctType in org.woehlke.jakartaee.petclinic.visit.db.VisitListener.onPreUpdate(Object) STYLE DLS_DEAD_LOCAL_STORE 31 Medium