The following document contains the results of Checkstyle 9.3 with sun_checks.xml ruleset.
| Files |  |
 |
 |
|---|---|---|---|
| 189 | 0 | 0 | 10738 |
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | LeftCurly | 15 | |
| NeedBraces | 640 | | |
| coding | HiddenField | 390 | |
| MagicNumber | 158 | | |
| design | DesignForExtension | 1289 | |
| VisibilityModifier | 9 | | |
| imports | AvoidStarImport | 43 | |
UnusedImports
|
2 | | |
| javadoc | JavadocMethod | 1 | |
| JavadocPackage | 32 | | |
| JavadocStyle | 24 | | |
| JavadocVariable | 592 | | |
| MissingJavadocMethod | 1113 | | |
| misc | ArrayTypeStyle | 5 | |
| FinalParameters | 1024 | | |
| NewlineAtEndOfFile | 1 | | |
| TodoComment | 9 | | |
| modifier | ModifierOrder | 11 | |
| naming | ConstantName | 15 | |
| MemberName | 4 | | |
| MethodName | 8 | | |
| ParameterName | 5 | | |
| regexp | RegexpSingleline
|
465 | |
| sizes | LineLength
|
1544 | |
| MethodLength | 1 | | |
| whitespace | FileTabCharacter | 85 | |
| GenericWhitespace | 1 | | |
| MethodParamPad | 4 | | |
| NoWhitespaceBefore | 1 | | |
| OperatorWrap | 167 | | |
| ParenPad | 3 | | |
| WhitespaceAfter | 973 | | |
| WhitespaceAround | 2104 | |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 10 |
|
design | DesignForExtension | Class 'GreenshopApplication' looks like designed for extension (can be subclassed), but the method 'configure' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopApplication' final or making the method 'configure' static/final/abstract/empty, or adding allowed annotation for the method. | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 13 |
|
misc | FinalParameters | Parameter application should be final. | 13 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
misc | FinalParameters | Parameter args should be final. | 17 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
design | DesignForExtension | Class 'CategoryAndProductController' looks like designed for extension (can be subclassed), but the method 'rootCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryAndProductController' final or making the method 'rootCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
misc | FinalParameters | Parameter model should be final. | 40 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 40 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 42 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 44 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 47 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 47 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 110). | 54 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 57 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 58 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 127). | 70 |
|
design | DesignForExtension | Class 'CategoryAndProductController' looks like designed for extension (can be subclassed), but the method 'rootCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryAndProductController' final or making the method 'rootCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
misc | FinalParameters | Parameter categoryId should be final. | 72 |
|
misc | FinalParameters | Parameter parentId should be final. | 73 |
|
misc | FinalParameters | Parameter productId should be final. | 74 |
|
misc | FinalParameters | Parameter model should be final. | 75 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 75 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 77 |
|
sizes | LineLength | Line is longer than 80 characters (found 137). | 82 |
|
design | DesignForExtension | Class 'CategoryAndProductController' looks like designed for extension (can be subclassed), but the method 'rootCategoryIdSetActive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryAndProductController' final or making the method 'rootCategoryIdSetActive' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 82 |
|
misc | FinalParameters | Parameter categoryId should be final. | 84 |
|
misc | FinalParameters | Parameter parentId should be final. | 85 |
|
misc | FinalParameters | Parameter productId should be final. | 86 |
|
misc | FinalParameters | Parameter model should be final. | 87 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 87 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 139). | 95 |
|
design | DesignForExtension | Class 'CategoryAndProductController' looks like designed for extension (can be subclassed), but the method 'rootCategoryIdSetInactive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryAndProductController' final or making the method 'rootCategoryIdSetInactive' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
misc | FinalParameters | Parameter categoryId should be final. | 97 |
|
misc | FinalParameters | Parameter parentId should be final. | 98 |
|
misc | FinalParameters | Parameter productId should be final. | 99 |
|
misc | FinalParameters | Parameter model should be final. | 100 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 100 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 104 |
|
misc | FinalParameters | Parameter categoryId should be final. | 109 |
|
misc | FinalParameters | Parameter parentId should be final. | 110 |
|
misc | FinalParameters | Parameter productId should be final. | 111 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 111 |
|
misc | FinalParameters | Parameter model should be final. | 111 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 113 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 114 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 115 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 116 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 118 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 118 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 119 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 121 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 116). | 129 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 130 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 132 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 132 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 138 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 139 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 141 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 142 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
design | DesignForExtension | Class 'ManufacturerController' looks like designed for extension (can be subclassed), but the method 'manufacturers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerController' final or making the method 'manufacturers' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
misc | FinalParameters | Parameter model should be final. | 29 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 29 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 31 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 36 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 41 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 45 |
|
design | DesignForExtension | Class 'ManufacturerController' looks like designed for extension (can be subclassed), but the method 'manufacturersId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerController' final or making the method 'manufacturersId' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 47 |
|
whitespace | NoWhitespaceBefore | ',' is preceded with whitespace. | 47 |
|
misc | FinalParameters | Parameter model should be final. | 47 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 47 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 50 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 54 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 55 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 56 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 58 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 59 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 59 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
design | DesignForExtension | Class 'ReviewController' looks like designed for extension (can be subclassed), but the method 'reviews' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewController' final or making the method 'reviews' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
|
misc | FinalParameters | Parameter model should be final. | 32 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 39 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 39 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 42 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 48 |
|
design | DesignForExtension | Class 'ReviewController' looks like designed for extension (can be subclassed), but the method 'reviewsId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewController' final or making the method 'reviewsId' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
|
misc | FinalParameters | Parameter reviewId should be final. | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
misc | FinalParameters | Parameter model should be final. | 49 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 59 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 65 |
|
design | DesignForExtension | Class 'ReviewController' looks like designed for extension (can be subclassed), but the method 'reviewsSetInactive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewController' final or making the method 'reviewsSetInactive' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
|
misc | FinalParameters | Parameter reviewId should be final. | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 66 |
|
misc | FinalParameters | Parameter model should be final. | 66 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 70 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 75 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 79 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 83 |
|
design | DesignForExtension | Class 'ReviewController' looks like designed for extension (can be subclassed), but the method 'reviewsSetActive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewController' final or making the method 'reviewsSetActive' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
|
misc | FinalParameters | Parameter reviewId should be final. | 84 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 84 |
|
misc | FinalParameters | Parameter model should be final. | 84 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 84 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 86 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 88 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 93 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 95 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 97 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.entities.*. | 9 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.model.*. | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
design | DesignForExtension | Class 'SpecialController' looks like designed for extension (can be subclassed), but the method 'specials' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialController' final or making the method 'specials' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
misc | FinalParameters | Parameter model should be final. | 31 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 31 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 45 |
|
design | DesignForExtension | Class 'SpecialController' looks like designed for extension (can be subclassed), but the method 'specialsId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialController' final or making the method 'specialsId' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
misc | FinalParameters | Parameter productId should be final. | 46 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 46 |
|
misc | FinalParameters | Parameter model should be final. | 46 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 46 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 50 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 53 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 54 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 56 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 60 |
|
design | DesignForExtension | Class 'SpecialController' looks like designed for extension (can be subclassed), but the method 'specialSetInactive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialController' final or making the method 'specialSetInactive' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
|
misc | FinalParameters | Parameter productId should be final. | 61 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 61 |
|
misc | FinalParameters | Parameter model should be final. | 61 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 61 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 65 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 66 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 70 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 72 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 77 |
|
design | DesignForExtension | Class 'SpecialController' looks like designed for extension (can be subclassed), but the method 'specialSetActive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialController' final or making the method 'specialSetActive' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 77 |
|
misc | FinalParameters | Parameter productId should be final. | 78 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 78 |
|
misc | FinalParameters | Parameter model should be final. | 78 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 78 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 80 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 82 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 82 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 83 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 89 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 90 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'home' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'home' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
misc | FinalParameters | Parameter model should be final. | 27 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 27 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 29 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'administrators' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'administrators' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
|
misc | FinalParameters | Parameter model should be final. | 34 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 34 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 37 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 40 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 40 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 47 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'administratorId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'administratorId' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 47 |
|
misc | FinalParameters | Parameter administratorId should be final. | 49 |
|
misc | FinalParameters | Parameter model should be final. | 49 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 52 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 54 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 59 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'administratorEditForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'administratorEditForm' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 59 |
|
misc | FinalParameters | Parameter administratorId should be final. | 61 |
|
misc | FinalParameters | Parameter model should be final. | 61 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 61 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 64 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 71 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'administratorEditSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'administratorEditSave' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 71 |
|
misc | FinalParameters | Parameter administratorId should be final. | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 74 |
|
misc | FinalParameters | Parameter thisAdministrator should be final. | 74 |
|
misc | FinalParameters | Parameter result should be final. | 74 |
|
misc | FinalParameters | Parameter model should be final. | 74 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 74 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 77 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 78 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 79 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 80 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 85 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 85 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 89 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'administratorInsertForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'administratorInsertForm' static/final/abstract/empty, or adding allowed annotation for the method. | 89 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 89 |
|
misc | FinalParameters | Parameter model should be final. | 90 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 90 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 94 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 95 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 100 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'administratorInsertSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'administratorInsertSave' static/final/abstract/empty, or adding allowed annotation for the method. | 100 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 102 |
|
misc | FinalParameters | Parameter thisAdministrator should be final. | 102 |
|
misc | FinalParameters | Parameter result should be final. | 102 |
|
misc | FinalParameters | Parameter model should be final. | 102 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 102 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 104 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 105 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 105 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 106 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 107 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 113 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 117 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'administratorDeleteForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'administratorDeleteForm' static/final/abstract/empty, or adding allowed annotation for the method. | 117 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 117 |
|
misc | FinalParameters | Parameter administratorId should be final. | 119 |
|
misc | FinalParameters | Parameter model should be final. | 119 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 119 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 121 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 122 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 123 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 124 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 125 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 129 |
|
design | DesignForExtension | Class 'AdministratorController' looks like designed for extension (can be subclassed), but the method 'administratorDeleteSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorController' final or making the method 'administratorDeleteSave' static/final/abstract/empty, or adding allowed annotation for the method. | 129 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 129 |
|
misc | FinalParameters | Parameter administratorId should be final. | 131 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 132 |
|
misc | FinalParameters | Parameter thisAdministrator should be final. | 132 |
|
misc | FinalParameters | Parameter result should be final. | 132 |
|
misc | FinalParameters | Parameter model should be final. | 132 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 132 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 134 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 135 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 135 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 136 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 137 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 138 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
design | DesignForExtension | Class 'CustomerController' looks like designed for extension (can be subclassed), but the method 'customers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerController' final or making the method 'customers' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
misc | FinalParameters | Parameter model should be final. | 25 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 25 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 27 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 29 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 34 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 37 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 41 |
|
design | DesignForExtension | Class 'CustomerController' looks like designed for extension (can be subclassed), but the method 'customerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerController' final or making the method 'customerId' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
|
misc | FinalParameters | Parameter customerId should be final. | 42 |
|
misc | FinalParameters | Parameter model should be final. | 42 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 42 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 46 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 50 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 50 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
design | DesignForExtension | Class 'OrderController' looks like designed for extension (can be subclassed), but the method 'orders' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderController' final or making the method 'orders' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
misc | FinalParameters | Parameter model should be final. | 30 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 30 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 37 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 37 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 44 |
|
design | DesignForExtension | Class 'OrderController' looks like designed for extension (can be subclassed), but the method 'orderId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderController' final or making the method 'orderId' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
misc | FinalParameters | Parameter orderId should be final. | 45 |
|
misc | FinalParameters | Parameter model should be final. | 45 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 50 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 52 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
design | DesignForExtension | Class 'CurrencyController' looks like designed for extension (can be subclassed), but the method 'currencies' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CurrencyController' final or making the method 'currencies' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
misc | FinalParameters | Parameter model should be final. | 16 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 16 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 18 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
design | DesignForExtension | Class 'LanguageController' looks like designed for extension (can be subclassed), but the method 'languages' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LanguageController' final or making the method 'languages' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
misc | FinalParameters | Parameter model should be final. | 25 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 25 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 27 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 29 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 31 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 31 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 38 |
|
design | DesignForExtension | Class 'LanguageController' looks like designed for extension (can be subclassed), but the method 'languageId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LanguageController' final or making the method 'languageId' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
|
misc | FinalParameters | Parameter languageId should be final. | 39 |
|
misc | FinalParameters | Parameter model should be final. | 39 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 39 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
design | DesignForExtension | Class 'OrderStatusController' looks like designed for extension (can be subclassed), but the method 'ordersStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusController' final or making the method 'ordersStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
misc | FinalParameters | Parameter model should be final. | 31 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 31 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 45 |
|
design | DesignForExtension | Class 'OrderStatusController' looks like designed for extension (can be subclassed), but the method 'ordersStatusId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusController' final or making the method 'ordersStatusId' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 46 |
|
misc | FinalParameters | Parameter ordersStatusId should be final. | 46 |
|
misc | FinalParameters | Parameter model should be final. | 46 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 46 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 50 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 56 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
design | DesignForExtension | Class 'ReportsController' looks like designed for extension (can be subclassed), but the method 'productsViewed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReportsController' final or making the method 'productsViewed' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
misc | FinalParameters | Parameter model should be final. | 29 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 29 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 31 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 33 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 38 |
|
design | DesignForExtension | Class 'ReportsController' looks like designed for extension (can be subclassed), but the method 'productsPurchased' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReportsController' final or making the method 'productsPurchased' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
|
misc | FinalParameters | Parameter model should be final. | 39 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 39 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 45 |
|
design | DesignForExtension | Class 'ReportsController' looks like designed for extension (can be subclassed), but the method 'customerOrdersTotal' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReportsController' final or making the method 'customerOrdersTotal' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
misc | FinalParameters | Parameter model should be final. | 46 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 46 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 42 |
|
design | DesignForExtension | Class 'CountryController' looks like designed for extension (can be subclassed), but the method 'countries' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryController' final or making the method 'countries' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 45 |
|
misc | FinalParameters | Parameter page should be final. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
misc | FinalParameters | Parameter model should be final. | 45 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 47 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 50 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 59 |
|
design | DesignForExtension | Class 'CountryController' looks like designed for extension (can be subclassed), but the method 'countries' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryController' final or making the method 'countries' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 60 |
|
whitespace | ParenPad | '(' is followed by whitespace. | 60 |
|
misc | FinalParameters | Parameter page should be final. | 60 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
misc | FinalParameters | Parameter countryId should be final. | 61 |
|
misc | FinalParameters | Parameter model should be final. | 61 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 61 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 66 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 67 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 72 |
|
design | DesignForExtension | Class 'CountryController' looks like designed for extension (can be subclassed), but the method 'countriesInsertForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryController' final or making the method 'countriesInsertForm' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 73 |
|
misc | FinalParameters | Parameter page should be final. | 73 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
misc | FinalParameters | Parameter model should be final. | 73 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 75 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 76 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 77 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 78 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 80 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 81 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 86 |
|
design | DesignForExtension | Class 'CountryController' looks like designed for extension (can be subclassed), but the method 'countriesInsertPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryController' final or making the method 'countriesInsertPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 86 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 87 |
|
misc | FinalParameters | Parameter page should be final. | 87 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 87 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 88 |
|
misc | FinalParameters | Parameter thisCountry should be final. | 88 |
|
misc | FinalParameters | Parameter result should be final. | 88 |
|
misc | FinalParameters | Parameter model should be final. | 88 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 88 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 89 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 90 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 90 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 93 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 93 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 94 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 95 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 97 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 98 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 102 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 102 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 106 |
|
design | DesignForExtension | Class 'CountryController' looks like designed for extension (can be subclassed), but the method 'countriesEditForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryController' final or making the method 'countriesEditForm' static/final/abstract/empty, or adding allowed annotation for the method. | 106 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 106 |
|
misc | FinalParameters | Parameter countryId should be final. | 107 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 108 |
|
misc | FinalParameters | Parameter page should be final. | 108 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 108 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 108 |
|
misc | FinalParameters | Parameter model should be final. | 109 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 109 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 111 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 114 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 114 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 115 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 117 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 118 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 122 |
|
design | DesignForExtension | Class 'CountryController' looks like designed for extension (can be subclassed), but the method 'countriesEditSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryController' final or making the method 'countriesEditSave' static/final/abstract/empty, or adding allowed annotation for the method. | 122 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 122 |
|
misc | FinalParameters | Parameter countryId should be final. | 123 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 124 |
|
misc | FinalParameters | Parameter page should be final. | 124 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 124 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 124 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 125 |
|
misc | FinalParameters | Parameter thisCountry should be final. | 125 |
|
misc | FinalParameters | Parameter result should be final. | 125 |
|
misc | FinalParameters | Parameter model should be final. | 125 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 125 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 126 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 126 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 127 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 127 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 130 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 131 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 133 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 134 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 135 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 144 |
|
design | DesignForExtension | Class 'CountryController' looks like designed for extension (can be subclassed), but the method 'countriesDeleteForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryController' final or making the method 'countriesDeleteForm' static/final/abstract/empty, or adding allowed annotation for the method. | 144 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 144 |
|
misc | FinalParameters | Parameter countryId should be final. | 145 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 146 |
|
misc | FinalParameters | Parameter page should be final. | 146 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 146 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 146 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 146 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 146 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 146 |
|
misc | FinalParameters | Parameter model should be final. | 147 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 147 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 149 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 151 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 152 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 152 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 153 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 154 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 158 |
|
design | DesignForExtension | Class 'CountryController' looks like designed for extension (can be subclassed), but the method 'countriesDeleteSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryController' final or making the method 'countriesDeleteSave' static/final/abstract/empty, or adding allowed annotation for the method. | 158 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 158 |
|
misc | FinalParameters | Parameter countryId should be final. | 159 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 160 |
|
misc | FinalParameters | Parameter page should be final. | 160 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 160 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 160 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 160 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 160 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 160 |
|
misc | FinalParameters | Parameter model should be final. | 161 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 161 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 164 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 164 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 36 |
|
design | DesignForExtension | Class 'TaxClassController' looks like designed for extension (can be subclassed), but the method 'taxClasses' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassController' final or making the method 'taxClasses' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 39 |
|
misc | FinalParameters | Parameter page should be final. | 39 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
misc | FinalParameters | Parameter model should be final. | 39 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 39 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 42 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 42 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 46 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 46 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 53 |
|
design | DesignForExtension | Class 'TaxClassController' looks like designed for extension (can be subclassed), but the method 'taxClassId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassController' final or making the method 'taxClassId' static/final/abstract/empty, or adding allowed annotation for the method. | 53 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 53 |
|
misc | FinalParameters | Parameter taxClassId should be final. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 55 |
|
misc | FinalParameters | Parameter page should be final. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
misc | FinalParameters | Parameter model should be final. | 56 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 58 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 59 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 59 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 63 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 63 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 66 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 70 |
|
design | DesignForExtension | Class 'TaxClassController' looks like designed for extension (can be subclassed), but the method 'taxClassInsertForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassController' final or making the method 'taxClassInsertForm' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 71 |
|
misc | FinalParameters | Parameter page should be final. | 71 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 71 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 71 |
|
misc | FinalParameters | Parameter model should be final. | 71 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 71 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 74 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 78 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 82 |
|
design | DesignForExtension | Class 'TaxClassController' looks like designed for extension (can be subclassed), but the method 'taxClassInsertPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassController' final or making the method 'taxClassInsertPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 83 |
|
misc | FinalParameters | Parameter page should be final. | 83 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 83 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 83 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 84 |
|
misc | FinalParameters | Parameter thisTaxClass should be final. | 84 |
|
misc | FinalParameters | Parameter result should be final. | 84 |
|
misc | FinalParameters | Parameter model should be final. | 84 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 84 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 85 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 85 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 86 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 89 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 91 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 96 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 96 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 96 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 96 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 96 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 100 |
|
design | DesignForExtension | Class 'TaxClassController' looks like designed for extension (can be subclassed), but the method 'taxClassEditForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassController' final or making the method 'taxClassEditForm' static/final/abstract/empty, or adding allowed annotation for the method. | 100 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
|
misc | FinalParameters | Parameter taxClassId should be final. | 101 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 102 |
|
misc | FinalParameters | Parameter page should be final. | 102 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 102 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 102 |
|
misc | FinalParameters | Parameter model should be final. | 103 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 103 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 105 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 107 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 108 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 110 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 114 |
|
design | DesignForExtension | Class 'TaxClassController' looks like designed for extension (can be subclassed), but the method 'taxClassEditSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassController' final or making the method 'taxClassEditSave' static/final/abstract/empty, or adding allowed annotation for the method. | 114 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 114 |
|
misc | FinalParameters | Parameter taxClassId should be final. | 115 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 116 |
|
misc | FinalParameters | Parameter page should be final. | 116 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 116 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 116 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 116 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 116 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 117 |
|
misc | FinalParameters | Parameter thisTaxClass should be final. | 117 |
|
misc | FinalParameters | Parameter result should be final. | 117 |
|
misc | FinalParameters | Parameter model should be final. | 117 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 117 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 118 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 118 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 119 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 119 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 122 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 123 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 123 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 125 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 132 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 132 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 132 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 136 |
|
design | DesignForExtension | Class 'TaxClassController' looks like designed for extension (can be subclassed), but the method 'taxClassDeleteForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassController' final or making the method 'taxClassDeleteForm' static/final/abstract/empty, or adding allowed annotation for the method. | 136 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 136 |
|
misc | FinalParameters | Parameter taxClassId should be final. | 137 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 138 |
|
misc | FinalParameters | Parameter page should be final. | 138 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 138 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 138 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 138 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 138 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 138 |
|
misc | FinalParameters | Parameter model should be final. | 139 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 139 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 141 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 143 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 144 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 144 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 146 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 150 |
|
design | DesignForExtension | Class 'TaxClassController' looks like designed for extension (can be subclassed), but the method 'taxClassDeleteSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassController' final or making the method 'taxClassDeleteSave' static/final/abstract/empty, or adding allowed annotation for the method. | 150 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 150 |
|
misc | FinalParameters | Parameter taxClassId should be final. | 151 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 152 |
|
misc | FinalParameters | Parameter page should be final. | 152 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 152 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 152 |
|
misc | FinalParameters | Parameter model should be final. | 153 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 153 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 156 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 156 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.springframework.web.bind.annotation.*. | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 45 |
|
design | DesignForExtension | Class 'TaxRateController' looks like designed for extension (can be subclassed), but the method 'taxRates' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateController' final or making the method 'taxRates' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 47 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 48 |
|
misc | FinalParameters | Parameter page should be final. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
misc | FinalParameters | Parameter model should be final. | 48 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 50 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 51 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 58 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 62 |
|
design | DesignForExtension | Class 'TaxRateController' looks like designed for extension (can be subclassed), but the method 'taxRateId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateController' final or making the method 'taxRateId' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
|
misc | FinalParameters | Parameter taxRateId should be final. | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 64 |
|
misc | FinalParameters | Parameter page should be final. | 64 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 64 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 64 |
|
misc | FinalParameters | Parameter model should be final. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 79 |
|
design | DesignForExtension | Class 'TaxRateController' looks like designed for extension (can be subclassed), but the method 'taxRateInsertForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateController' final or making the method 'taxRateInsertForm' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 80 |
|
misc | FinalParameters | Parameter page should be final. | 80 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 80 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 80 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 80 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 80 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 80 |
|
misc | FinalParameters | Parameter model should be final. | 80 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 80 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 83 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 85 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 95 |
|
design | DesignForExtension | Class 'TaxRateController' looks like designed for extension (can be subclassed), but the method 'taxRateInsertPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateController' final or making the method 'taxRateInsertPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 96 |
|
misc | FinalParameters | Parameter page should be final. | 96 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 96 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 96 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 96 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 96 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 97 |
|
misc | FinalParameters | Parameter thisTaxRate should be final. | 97 |
|
misc | FinalParameters | Parameter result should be final. | 97 |
|
misc | FinalParameters | Parameter model should be final. | 97 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 97 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 98 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 98 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 99 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 99 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 101 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 102 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 104 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 105 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 109 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 109 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 109 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 109 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 109 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 109 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 113 |
|
design | DesignForExtension | Class 'TaxRateController' looks like designed for extension (can be subclassed), but the method 'taxRateEditForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateController' final or making the method 'taxRateEditForm' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 113 |
|
misc | FinalParameters | Parameter taxRateId should be final. | 114 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 115 |
|
misc | FinalParameters | Parameter page should be final. | 115 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 115 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 115 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 115 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 115 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 115 |
|
misc | FinalParameters | Parameter model should be final. | 116 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 116 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 118 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 120 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 121 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 123 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 125 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 127 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 131 |
|
design | DesignForExtension | Class 'TaxRateController' looks like designed for extension (can be subclassed), but the method 'taxRateEditSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateController' final or making the method 'taxRateEditSave' static/final/abstract/empty, or adding allowed annotation for the method. | 131 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 131 |
|
misc | FinalParameters | Parameter taxRateId should be final. | 132 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 133 |
|
misc | FinalParameters | Parameter page should be final. | 133 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 133 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 133 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 133 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 133 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 133 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 134 |
|
misc | FinalParameters | Parameter thisTaxRate should be final. | 134 |
|
misc | FinalParameters | Parameter result should be final. | 134 |
|
misc | FinalParameters | Parameter model should be final. | 134 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 134 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 135 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 135 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 136 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 136 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 138 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 139 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 140 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 142 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 152 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 152 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 152 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 156 |
|
design | DesignForExtension | Class 'TaxRateController' looks like designed for extension (can be subclassed), but the method 'taxRateDeleteForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateController' final or making the method 'taxRateDeleteForm' static/final/abstract/empty, or adding allowed annotation for the method. | 156 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 156 |
|
misc | FinalParameters | Parameter taxRateId should be final. | 157 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 158 |
|
misc | FinalParameters | Parameter page should be final. | 158 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 158 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 158 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 158 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 158 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 158 |
|
misc | FinalParameters | Parameter model should be final. | 159 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 159 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 161 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 163 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 164 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 164 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 166 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 170 |
|
design | DesignForExtension | Class 'TaxRateController' looks like designed for extension (can be subclassed), but the method 'taxRateDeleteSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateController' final or making the method 'taxRateDeleteSave' static/final/abstract/empty, or adding allowed annotation for the method. | 170 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 170 |
|
misc | FinalParameters | Parameter taxRateId should be final. | 171 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 172 |
|
misc | FinalParameters | Parameter page should be final. | 172 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 172 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 172 |
|
misc | FinalParameters | Parameter model should be final. | 173 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 173 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 176 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 176 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.springframework.web.bind.annotation.*. | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 36 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 36 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 50 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 52 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZones' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZones' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 55 |
|
misc | FinalParameters | Parameter page should be final. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
misc | FinalParameters | Parameter model should be final. | 55 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 57 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 58 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 58 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 63 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 65 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 67 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 72 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneId' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 73 |
|
misc | FinalParameters | Parameter page should be final. | 73 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 74 |
|
misc | FinalParameters | Parameter model should be final. | 74 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 74 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 77 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 79 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 81 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 82 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 83 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 87 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZonesInsertForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZonesInsertForm' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 88 |
|
misc | FinalParameters | Parameter page should be final. | 88 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 88 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 88 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 88 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 88 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 88 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 88 |
|
misc | FinalParameters | Parameter model should be final. | 88 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 88 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 90 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 91 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 91 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 93 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 95 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 99 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZonesInsertSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZonesInsertSave' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 100 |
|
misc | FinalParameters | Parameter page should be final. | 100 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 100 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 100 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 100 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 100 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 100 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 101 |
|
misc | FinalParameters | Parameter thisTaxZone should be final. | 101 |
|
misc | FinalParameters | Parameter result should be final. | 101 |
|
misc | FinalParameters | Parameter model should be final. | 101 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 101 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 103 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 104 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 104 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 106 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 107 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 107 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 110 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 115 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 116 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 116 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 116 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 116 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 116 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 116 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 120 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneDeleteForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneDeleteForm' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 120 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 121 |
|
misc | FinalParameters | Parameter page should be final. | 121 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 121 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 121 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 122 |
|
misc | FinalParameters | Parameter model should be final. | 122 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 122 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 124 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 125 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 125 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 127 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 129 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 130 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 131 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 135 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneDeletePerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneDeletePerform' static/final/abstract/empty, or adding allowed annotation for the method. | 135 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 135 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 136 |
|
misc | FinalParameters | Parameter page should be final. | 136 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 136 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 136 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 136 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 136 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 136 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 137 |
|
misc | FinalParameters | Parameter thisTaxZone should be final. | 138 |
|
misc | FinalParameters | Parameter result should be final. | 139 |
|
misc | FinalParameters | Parameter model should be final. | 140 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 140 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 142 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 143 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 143 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 145 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 147 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 150 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 150 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 153 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneEditForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneEditForm' static/final/abstract/empty, or adding allowed annotation for the method. | 153 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 153 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 154 |
|
misc | FinalParameters | Parameter page should be final. | 154 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 154 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 154 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 154 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 154 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 154 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 155 |
|
misc | FinalParameters | Parameter model should be final. | 155 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 155 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 157 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 158 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 158 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 160 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 162 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 163 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 164 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 168 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneEditPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneEditPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 168 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 168 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 169 |
|
misc | FinalParameters | Parameter page should be final. | 169 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 169 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 169 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 170 |
|
misc | FinalParameters | Parameter thisTaxZone should be final. | 171 |
|
misc | FinalParameters | Parameter result should be final. | 172 |
|
misc | FinalParameters | Parameter model should be final. | 173 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 173 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 175 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 176 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 176 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 178 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 179 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 180 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 184 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 184 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 184 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 184 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 184 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 184 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 188 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 188 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 188 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 189 |
|
misc | FinalParameters | Parameter model should be final. | 189 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 189 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 193 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 194 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 195 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 197 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 197 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 197 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 197 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 204 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneWithZoneId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneWithZoneId' static/final/abstract/empty, or adding allowed annotation for the method. | 204 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 204 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 205 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 205 |
|
misc | FinalParameters | Parameter zoneId should be final. | 205 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 205 |
|
misc | FinalParameters | Parameter model should be final. | 205 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 205 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 207 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 209 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 210 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 211 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 212 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 213 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 217 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneInsertForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneInsertForm' static/final/abstract/empty, or adding allowed annotation for the method. | 217 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 217 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 218 |
|
misc | FinalParameters | Parameter model should be final. | 218 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 218 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 220 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 222 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 223 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 224 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 226 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 226 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 226 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 226 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 229 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 230 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 231 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 233 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 237 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneInsertSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneInsertSave' static/final/abstract/empty, or adding allowed annotation for the method. | 237 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 237 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 238 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 239 |
|
misc | FinalParameters | Parameter newSubZoneInfoBean should be final. | 239 |
|
misc | FinalParameters | Parameter result should be final. | 240 |
|
misc | FinalParameters | Parameter model should be final. | 241 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 241 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 242 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 242 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 243 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 243 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 245 |
|
whitespace | WhitespaceAround | '||' is not followed by whitespace. | 245 |
|
whitespace | WhitespaceAround | '||' is not preceded with whitespace. | 245 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 245 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 245 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 247 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 248 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 249 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 250 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 252 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 252 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 252 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 252 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 255 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 258 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 260 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 260 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 260 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 260 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 269 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 269 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 273 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneWithZoneIdDeleteForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneWithZoneIdDeleteForm' static/final/abstract/empty, or adding allowed annotation for the method. | 273 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 273 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 274 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 274 |
|
misc | FinalParameters | Parameter zoneId should be final. | 274 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 274 |
|
misc | FinalParameters | Parameter model should be final. | 274 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 274 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 276 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 278 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 279 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 280 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 281 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 282 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 286 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneWithZoneIdDeletePerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneWithZoneIdDeletePerform' static/final/abstract/empty, or adding allowed annotation for the method. | 286 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 286 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 287 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 287 |
|
misc | FinalParameters | Parameter zoneId should be final. | 287 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 287 |
|
misc | FinalParameters | Parameter model should be final. | 287 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 287 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 288 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 290 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 290 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 293 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneWithZoneIdEditForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneWithZoneIdEditForm' static/final/abstract/empty, or adding allowed annotation for the method. | 293 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 293 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 294 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 294 |
|
misc | FinalParameters | Parameter zoneId should be final. | 294 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 294 |
|
misc | FinalParameters | Parameter model should be final. | 294 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 294 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 296 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 298 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 299 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 300 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 301 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 302 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 303 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 304 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 306 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 310 |
|
design | DesignForExtension | Class 'TaxZoneController' looks like designed for extension (can be subclassed), but the method 'taxZoneWithZoneIdEditPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneController' final or making the method 'taxZoneWithZoneIdEditPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 310 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 310 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 311 |
|
misc | FinalParameters | Parameter zoneId should be final. | 312 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 313 |
|
misc | FinalParameters | Parameter newSubZoneInfoBean should be final. | 313 |
|
misc | FinalParameters | Parameter result should be final. | 314 |
|
misc | FinalParameters | Parameter model should be final. | 315 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 315 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 316 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 317 |
|
whitespace | WhitespaceAround | '||' is not followed by whitespace. | 317 |
|
whitespace | WhitespaceAround | '||' is not preceded with whitespace. | 317 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 317 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 317 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 319 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 321 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 322 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 323 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 324 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 327 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 329 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 329 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 329 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 329 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 335 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 335 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 335 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 335 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 335 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 335 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 42 |
|
design | DesignForExtension | Class 'ZoneController' looks like designed for extension (can be subclassed), but the method 'zones' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneController' final or making the method 'zones' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 45 |
|
misc | FinalParameters | Parameter page should be final. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
misc | FinalParameters | Parameter model should be final. | 45 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 47 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 50 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
design | DesignForExtension | Class 'ZoneController' looks like designed for extension (can be subclassed), but the method 'zoneId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneController' final or making the method 'zoneId' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 60 |
|
misc | FinalParameters | Parameter page should be final. | 60 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
misc | FinalParameters | Parameter zoneId should be final. | 61 |
|
misc | FinalParameters | Parameter model should be final. | 61 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 61 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
design | DesignForExtension | Class 'ZoneController' looks like designed for extension (can be subclassed), but the method 'zonesInsertForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneController' final or making the method 'zonesInsertForm' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 73 |
|
misc | FinalParameters | Parameter page should be final. | 73 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
misc | FinalParameters | Parameter model should be final. | 73 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 75 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 76 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 78 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 80 |
|
design | DesignForExtension | Class 'ZoneController' looks like designed for extension (can be subclassed), but the method 'zonesInsertPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneController' final or making the method 'zonesInsertPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 86 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 87 |
|
misc | FinalParameters | Parameter page should be final. | 87 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 87 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 88 |
|
misc | FinalParameters | Parameter thisZone should be final. | 88 |
|
misc | FinalParameters | Parameter result should be final. | 88 |
|
misc | FinalParameters | Parameter model should be final. | 88 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 88 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 89 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 90 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 90 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 93 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 93 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 93 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 95 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 97 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 102 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 106 |
|
design | DesignForExtension | Class 'ZoneController' looks like designed for extension (can be subclassed), but the method 'zonesEditForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneController' final or making the method 'zonesEditForm' static/final/abstract/empty, or adding allowed annotation for the method. | 106 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 106 |
|
misc | FinalParameters | Parameter zoneId should be final. | 107 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 108 |
|
misc | FinalParameters | Parameter page should be final. | 108 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 108 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 108 |
|
misc | FinalParameters | Parameter model should be final. | 109 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 109 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 111 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 114 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 114 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 114 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 116 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 118 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 122 |
|
design | DesignForExtension | Class 'ZoneController' looks like designed for extension (can be subclassed), but the method 'zonesEditSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneController' final or making the method 'zonesEditSave' static/final/abstract/empty, or adding allowed annotation for the method. | 122 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 122 |
|
misc | FinalParameters | Parameter zoneId should be final. | 123 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 124 |
|
misc | FinalParameters | Parameter page should be final. | 124 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 124 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 124 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 125 |
|
misc | FinalParameters | Parameter thisZone should be final. | 125 |
|
misc | FinalParameters | Parameter result should be final. | 125 |
|
misc | FinalParameters | Parameter model should be final. | 125 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 125 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 126 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 126 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 127 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 127 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 130 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 130 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 130 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 133 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 134 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 135 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 144 |
|
design | DesignForExtension | Class 'ZoneController' looks like designed for extension (can be subclassed), but the method 'zonesDeleteForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneController' final or making the method 'zonesDeleteForm' static/final/abstract/empty, or adding allowed annotation for the method. | 144 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 144 |
|
misc | FinalParameters | Parameter zoneId should be final. | 145 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 146 |
|
misc | FinalParameters | Parameter page should be final. | 146 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 146 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 146 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 146 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 146 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 146 |
|
misc | FinalParameters | Parameter model should be final. | 147 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 147 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 149 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 151 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 152 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 154 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 158 |
|
design | DesignForExtension | Class 'ZoneController' looks like designed for extension (can be subclassed), but the method 'zonesDeleteSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneController' final or making the method 'zonesDeleteSave' static/final/abstract/empty, or adding allowed annotation for the method. | 158 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 158 |
|
misc | FinalParameters | Parameter zoneId should be final. | 159 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 160 |
|
misc | FinalParameters | Parameter page should be final. | 160 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 160 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 160 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 160 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 160 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 160 |
|
misc | FinalParameters | Parameter model should be final. | 161 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 161 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 164 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 164 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
design | VisibilityModifier | Variable 'userConfig' must be private and have accessor methods. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
design | VisibilityModifier | Variable 'webConfig' must be private and have accessor methods. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
design | VisibilityModifier | Variable 'webSecurity' must be private and have accessor methods. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 62 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 72 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 75 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 78 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 81 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 92 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 95 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 98 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 101 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 104 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 107 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 110 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 113 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 116 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 119 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 122 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 125 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 128 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 131 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
|
misc | FinalParameters | Parameter greenshopProperties should be final. | 38 |
|
coding | HiddenField | 'greenshopProperties' hides a field. | 38 |
|
design | DesignForExtension | Class 'GreenshopWebMvcConfig' looks like designed for extension (can be subclassed), but the method 'localeResolver' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebMvcConfig' final or making the method 'localeResolver' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 42 |
|
design | DesignForExtension | Class 'GreenshopWebMvcConfig' looks like designed for extension (can be subclassed), but the method 'localeChangeInterceptor' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebMvcConfig' final or making the method 'localeChangeInterceptor' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
design | DesignForExtension | Class 'GreenshopWebMvcConfig' looks like designed for extension (can be subclassed), but the method 'methodValidationPostProcessor' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebMvcConfig' final or making the method 'methodValidationPostProcessor' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
|
design | DesignForExtension | Class 'GreenshopWebMvcConfig' looks like designed for extension (can be subclassed), but the method 'addInterceptors' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebMvcConfig' final or making the method 'addInterceptors' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
misc | FinalParameters | Parameter registry should be final. | 62 |
|
design | DesignForExtension | Class 'GreenshopWebMvcConfig' looks like designed for extension (can be subclassed), but the method 'addResourceHandlers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebMvcConfig' final or making the method 'addResourceHandlers' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
misc | FinalParameters | Parameter registry should be final. | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 68 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 68 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 69 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 69 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 69 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 69 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 70 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 70 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 70 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 70 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 70 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 70 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 70 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 72 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 72 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 73 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 74 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 74 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 74 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 74 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
|
misc | FinalParameters | Parameter auth should be final. | 35 |
|
misc | FinalParameters | Parameter administratorService should be final. | 36 |
|
coding | HiddenField | 'administratorService' hides a field. | 36 |
|
misc | FinalParameters | Parameter greenshopProperties should be final. | 37 |
|
coding | HiddenField | 'greenshopProperties' hides a field. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
design | DesignForExtension | Class 'GreenshopWebSecurityConfig' looks like designed for extension (can be subclassed), but the method 'configure' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebSecurityConfig' final or making the method 'configure' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
misc | FinalParameters | Parameter http should be final. | 50 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 56 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 60 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 69 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 70 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 77 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 78 |
|
sizes | LineLength | Line is longer than 80 characters (found 108). | 79 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 84 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 89 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 89 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 90 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 90 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 90 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 91 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 92 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 92 |
|
design | DesignForExtension | Class 'GreenshopWebSecurityConfig' looks like designed for extension (can be subclassed), but the method 'authProvider' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebSecurityConfig' final or making the method 'authProvider' static/final/abstract/empty, or adding allowed annotation for the method. | 97 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 97 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 99 |
|
whitespace | ParenPad | '(' is followed by whitespace. | 100 |
|
design | DesignForExtension | Class 'GreenshopWebSecurityConfig' looks like designed for extension (can be subclassed), but the method 'authenticationManager' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebSecurityConfig' final or making the method 'authenticationManager' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 105 |
|
sizes | LineLength | Line is longer than 80 characters (found 131). | 107 |
|
design | DesignForExtension | Class 'GreenshopWebSecurityConfig' looks like designed for extension (can be subclassed), but the method 'authenticationFilter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'GreenshopWebSecurityConfig' final or making the method 'authenticationFilter' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 110 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 114 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.service.*. | 24 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
design | VisibilityModifier | Variable 'catalogService' must be private and have accessor methods. | 31 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
design | VisibilityModifier | Variable 'customerService' must be private and have accessor methods. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
design | VisibilityModifier | Variable 'languageService' must be private and have accessor methods. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
design | VisibilityModifier | Variable 'categoryService' must be private and have accessor methods. | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 53 |
|
design | DesignForExtension | Class 'AbstractController' looks like designed for extension (can be subclassed), but the method 'createTransientBasket' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractController' final or making the method 'createTransientBasket' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 54 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 55 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 58 |
|
design | DesignForExtension | Class 'AbstractController' looks like designed for extension (can be subclassed), but the method 'getDefaultBoxContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractController' final or making the method 'getDefaultBoxContent' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
misc | FinalParameters | Parameter model should be final. | 59 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 69 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 70 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 71 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 74 |
|
design | DesignForExtension | Class 'AbstractController' looks like designed for extension (can be subclassed), but the method 'getLoggedInCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractController' final or making the method 'getLoggedInCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 75 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 78 |
|
sizes | LineLength | Line is longer than 80 characters (found 121). | 82 |
|
design | DesignForExtension | Class 'AbstractController' looks like designed for extension (can be subclassed), but the method 'getShareProductBean' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractController' final or making the method 'getShareProductBean' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
misc | FinalParameters | Parameter request should be final. | 82 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 82 |
|
misc | FinalParameters | Parameter productDescription should be final. | 82 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 86 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 88 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 37 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 37 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 53 |
|
design | DesignForExtension | Class 'CartController' looks like designed for extension (can be subclassed), but the method 'shoppingCart' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CartController' final or making the method 'shoppingCart' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 54 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 56 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 56 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 56 |
|
misc | FinalParameters | Parameter model should be final. | 57 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 57 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 63 |
|
design | DesignForExtension | Class 'CartController' looks like designed for extension (can be subclassed), but the method 'addToBasket' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CartController' final or making the method 'addToBasket' static/final/abstract/empty, or adding allowed annotation for the method. | 63 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 65 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 65 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 66 |
|
misc | FinalParameters | Parameter request should be final. | 66 |
|
misc | FinalParameters | Parameter response should be final. | 67 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 68 |
|
misc | FinalParameters | Parameter productId should be final. | 68 |
|
misc | FinalParameters | Parameter model should be final. | 68 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 70 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 74 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 77 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 77 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 79 |
|
sizes | LineLength | Line is longer than 80 characters (found 180). | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 84 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 84 |
|
sizes | LineLength | Line is longer than 80 characters (found 116). | 85 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 85 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 85 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 85 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 89 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 90 |
|
design | DesignForExtension | Class 'CartController' looks like designed for extension (can be subclassed), but the method 'removeFromBasket' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CartController' final or making the method 'removeFromBasket' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 90 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 92 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 92 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 93 |
|
misc | FinalParameters | Parameter request should be final. | 93 |
|
misc | FinalParameters | Parameter response should be final. | 94 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 95 |
|
misc | FinalParameters | Parameter productId should be final. | 95 |
|
misc | FinalParameters | Parameter model should be final. | 95 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 95 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 97 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 99 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 100 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 101 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 104 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 104 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 104 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 106 |
|
sizes | LineLength | Line is longer than 80 characters (found 180). | 109 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 111 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 121). | 112 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 112 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 112 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 112 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 117 |
|
design | DesignForExtension | Class 'CartController' looks like designed for extension (can be subclassed), but the method 'updateBasket' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CartController' final or making the method 'updateBasket' static/final/abstract/empty, or adding allowed annotation for the method. | 117 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 117 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 119 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 119 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 120 |
|
misc | FinalParameters | Parameter request should be final. | 120 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 121 |
|
misc | FinalParameters | Parameter response should be final. | 121 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 122 |
|
misc | FinalParameters | Parameter cartQuantity should be final. | 122 |
|
misc | ArrayTypeStyle | Array brackets at illegal position. | 122 |
|
misc | FinalParameters | Parameter model should be final. | 122 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 122 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 124 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 127 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 128 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 128 |
|
misc | FinalParameters | Parameter request should be final. | 128 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 128 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 129 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 129 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 131 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 131 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 132 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 133 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 133 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 135 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 135 |
|
misc | ArrayTypeStyle | Array brackets at illegal position. | 137 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 138 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 138 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 139 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 139 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 141 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 143 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 143 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 143 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 143 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 143 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 143 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 147 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 147 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 148 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 148 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 148 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 148 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 148 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 148 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.springframework.web.bind.annotation.*. | 11 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.entities.*. | 12 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.model.*. | 13 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.service.*. | 14 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 26 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'home' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'home' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
misc | FinalParameters | Parameter model should be final. | 45 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 45 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 50 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'category' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'category' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 50 |
|
misc | FinalParameters | Parameter categoryId should be final. | 51 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
misc | FinalParameters | Parameter model should be final. | 51 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 51 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 55 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 56 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 57 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 59 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 59 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 116). | 65 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 69 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 70 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'categoryFilteredByManufacturerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'categoryFilteredByManufacturerId' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
misc | FinalParameters | Parameter categoryId should be final. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 73 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 73 |
|
misc | FinalParameters | Parameter model should be final. | 73 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 74 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 74 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 75 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 75 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 77 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 77 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 77 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 77 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 80 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 81 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'categoryFilteredByManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'categoryFilteredByManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 81 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 81 |
|
misc | FinalParameters | Parameter categoryId should be final. | 83 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 84 |
|
misc | FinalParameters | Parameter model should be final. | 84 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 84 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 86 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 89 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 90 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 92 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 94 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 147). | 98 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 102 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 103 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'product' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'product' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 103 |
|
misc | FinalParameters | Parameter productId should be final. | 104 |
|
misc | FinalParameters | Parameter request should be final. | 105 |
|
misc | FinalParameters | Parameter response should be final. | 106 |
|
misc | FinalParameters | Parameter model should be final. | 107 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 107 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 109 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 113 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 127). | 117 |
|
sizes | LineLength | Line is longer than 80 characters (found 132). | 119 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 121 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 121 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 123 |
|
sizes | LineLength | Line is longer than 80 characters (found 180). | 126 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 130 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 130 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 134 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'manufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'manufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 135 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 135 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 136 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 136 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 136 |
|
misc | FinalParameters | Parameter model should be final. | 136 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 136 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 137 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 137 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 138 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 138 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 141 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'manufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'manufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 141 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 141 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 142 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 142 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 142 |
|
misc | FinalParameters | Parameter model should be final. | 142 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 142 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 143 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 143 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 145 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 147 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 148 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 149 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 151 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 151 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 151 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 154 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 154 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 154 |
|
sizes | LineLength | Line is longer than 80 characters (found 116). | 156 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 158 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 160 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 164 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 165 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'manufacturerFilteredByCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'manufacturerFilteredByCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 165 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 165 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 167 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 168 |
|
misc | FinalParameters | Parameter categoryId should be final. | 168 |
|
misc | FinalParameters | Parameter model should be final. | 168 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 168 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 169 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 169 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 169 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 170 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 170 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 172 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 172 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 172 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 172 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 175 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 176 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'manufacturerFilteredByCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'manufacturerFilteredByCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 176 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 176 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 178 |
|
misc | FinalParameters | Parameter categoryId should be final. | 179 |
|
misc | FinalParameters | Parameter model should be final. | 179 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 179 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 180 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 180 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 182 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 184 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 185 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 186 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 188 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 188 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 188 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 191 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 191 |
|
sizes | LineLength | Line is longer than 80 characters (found 137). | 193 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 193 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 193 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 196 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 198 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 203 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'manufacturerRedirect' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'manufacturerRedirect' static/final/abstract/empty, or adding allowed annotation for the method. | 203 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 203 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 204 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 204 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 204 |
|
misc | FinalParameters | Parameter model should be final. | 204 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 207 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 209 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 210 |
|
sizes | LineLength | Line is longer than 80 characters (found 116). | 211 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 211 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 211 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 211 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 212 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 212 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 212 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 214 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 219 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'writeReviewForProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'writeReviewForProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 219 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 219 |
|
misc | FinalParameters | Parameter productId should be final. | 220 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 221 |
|
misc | FinalParameters | Parameter request should be final. | 221 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 222 |
|
misc | FinalParameters | Parameter response should be final. | 222 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 223 |
|
misc | FinalParameters | Parameter model should be final. | 223 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 223 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 225 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 227 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 228 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 229 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 232 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 232 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 232 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 234 |
|
sizes | LineLength | Line is longer than 80 characters (found 152). | 238 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 240 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 242 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 251 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'writeReviewForProductPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'writeReviewForProductPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 251 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 251 |
|
sizes | LineLength | Line is longer than 80 characters (found 125). | 252 |
|
misc | FinalParameters | Parameter writeReviewBean should be final. | 252 |
|
sizes | LineLength | Line is longer than 80 characters (found 164). | 253 |
|
misc | FinalParameters | Parameter result should be final. | 253 |
|
sizes | LineLength | Line is longer than 80 characters (found 120). | 254 |
|
misc | FinalParameters | Parameter productId should be final. | 254 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 255 |
|
misc | FinalParameters | Parameter request should be final. | 255 |
|
sizes | LineLength | Line is longer than 80 characters (found 120). | 256 |
|
misc | FinalParameters | Parameter response should be final. | 256 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 257 |
|
misc | FinalParameters | Parameter model should be final. | 257 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 257 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 259 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 261 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 262 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 263 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 265 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 265 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 268 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 268 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 268 |
|
sizes | LineLength | Line is longer than 80 characters (found 142). | 270 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 272 |
|
sizes | LineLength | Line is longer than 80 characters (found 156). | 274 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 276 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 277 |
|
sizes | LineLength | Line is longer than 80 characters (found 126). | 278 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 279 |
|
sizes | LineLength | Line is longer than 80 characters (found 121). | 287 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 287 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 289 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 289 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 293 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'showReviews' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'showReviews' static/final/abstract/empty, or adding allowed annotation for the method. | 293 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 293 |
|
misc | FinalParameters | Parameter productId should be final. | 294 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 295 |
|
misc | FinalParameters | Parameter request should be final. | 295 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 296 |
|
misc | FinalParameters | Parameter response should be final. | 296 |
|
misc | FinalParameters | Parameter model should be final. | 297 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 297 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 299 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 301 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 302 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 303 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 306 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 306 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 306 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 308 |
|
sizes | LineLength | Line is longer than 80 characters (found 180). | 311 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 313 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 315 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 315 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 317 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 318 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 318 |
|
sizes | LineLength | Line is longer than 80 characters (found 110). | 323 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 328 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'showReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'showReview' static/final/abstract/empty, or adding allowed annotation for the method. | 328 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 328 |
|
misc | FinalParameters | Parameter reviewId should be final. | 329 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 330 |
|
misc | FinalParameters | Parameter request should be final. | 330 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 331 |
|
misc | FinalParameters | Parameter response should be final. | 331 |
|
misc | FinalParameters | Parameter model should be final. | 332 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 332 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 334 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 336 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 337 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 338 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 338 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 342 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 342 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 344 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 345 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 348 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 348 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 348 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 350 |
|
sizes | LineLength | Line is longer than 80 characters (found 180). | 353 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 355 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 357 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'reviews' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'reviews' static/final/abstract/empty, or adding allowed annotation for the method. | 362 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 362 |
|
misc | FinalParameters | Parameter request should be final. | 363 |
|
misc | FinalParameters | Parameter response should be final. | 364 |
|
misc | FinalParameters | Parameter model should be final. | 365 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 367 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 369 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 370 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 371 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 371 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 371 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 373 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 375 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 377 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'specials' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'specials' static/final/abstract/empty, or adding allowed annotation for the method. | 382 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 382 |
|
misc | FinalParameters | Parameter request should be final. | 383 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 384 |
|
misc | FinalParameters | Parameter response should be final. | 384 |
|
misc | FinalParameters | Parameter model should be final. | 385 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 387 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 389 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 390 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 391 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 391 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 391 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 393 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 395 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 397 |
|
design | DesignForExtension | Class 'CatalogController' looks like designed for extension (can be subclassed), but the method 'newProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogController' final or making the method 'newProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 402 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 402 |
|
misc | FinalParameters | Parameter request should be final. | 403 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 404 |
|
misc | FinalParameters | Parameter response should be final. | 404 |
|
misc | FinalParameters | Parameter model should be final. | 405 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 405 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 407 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 409 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 410 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 411 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 411 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 411 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 413 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 415 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 417 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 25 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 33 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'createCheckoutBean' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'createCheckoutBean' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 35 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 39 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutShipping' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutShipping' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
misc | FinalParameters | Parameter checkout should be final. | 41 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 42 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 42 |
|
misc | FinalParameters | Parameter model should be final. | 42 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 42 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 48 |
|
sizes | LineLength | Line is longer than 80 characters (found 120). | 49 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 60 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutPayment' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutPayment' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
misc | FinalParameters | Parameter checkout should be final. | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 64 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 64 |
|
misc | FinalParameters | Parameter model should be final. | 64 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 64 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 66 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 72 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 74 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutConfirmation' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutConfirmation' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 74 |
|
misc | FinalParameters | Parameter checkout should be final. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 77 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 77 |
|
misc | FinalParameters | Parameter model should be final. | 77 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 77 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 78 |
|
whitespace | WhitespaceAfter | ';' is not followed by whitespace. | 78 |
|
whitespace | WhitespaceAround | 'if' is not preceded with whitespace. | 78 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 78 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 83 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 84 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 85 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutConfirmationPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutConfirmationPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 85 |
|
misc | FinalParameters | Parameter checkout should be final. | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 88 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 88 |
|
misc | FinalParameters | Parameter model should be final. | 89 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 89 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 95 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 99 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 100 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutShippingAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutShippingAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 100 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
|
misc | FinalParameters | Parameter checkout should be final. | 102 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 103 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 103 |
|
misc | FinalParameters | Parameter model should be final. | 103 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 103 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 105 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 109 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 114 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 115 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 119 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 120 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutShippingAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutShippingAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 120 |
|
misc | FinalParameters | Parameter checkout should be final. | 122 |
|
misc | FinalParameters | Parameter newAddress should be final. | 123 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 124 |
|
misc | FinalParameters | Parameter result should be final. | 124 |
|
misc | FinalParameters | Parameter model should be final. | 125 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 125 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 128 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 119). | 131 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 134 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 135 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 135 |
|
sizes | LineLength | Line is longer than 80 characters (found 123). | 136 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 138 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 139 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 139 |
|
sizes | LineLength | Line is longer than 80 characters (found 108). | 142 |
|
sizes | LineLength | Line is longer than 80 characters (found 126). | 144 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 144 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 144 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 151 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 152 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutPaymentAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutPaymentAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 152 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 152 |
|
misc | FinalParameters | Parameter checkout should be final. | 154 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 155 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 155 |
|
misc | FinalParameters | Parameter model should be final. | 155 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 155 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 157 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 161 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 164 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 166 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 167 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 171 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 172 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutPaymentAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutPaymentAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 172 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 172 |
|
misc | FinalParameters | Parameter checkout should be final. | 174 |
|
misc | FinalParameters | Parameter newAddress should be final. | 175 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 176 |
|
misc | FinalParameters | Parameter result should be final. | 176 |
|
misc | FinalParameters | Parameter model should be final. | 177 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 177 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 180 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 180 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 181 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 182 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 183 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 186 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 187 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 187 |
|
sizes | LineLength | Line is longer than 80 characters (found 123). | 188 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 190 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 191 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 191 |
|
sizes | LineLength | Line is longer than 80 characters (found 108). | 194 |
|
sizes | LineLength | Line is longer than 80 characters (found 128). | 196 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 203 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 204 |
|
design | DesignForExtension | Class 'CheckoutController' looks like designed for extension (can be subclassed), but the method 'checkoutPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutController' final or making the method 'checkoutPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 204 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 204 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 206 |
|
misc | FinalParameters | Parameter checkout should be final. | 206 |
|
misc | FinalParameters | Parameter model should be final. | 206 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 206 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 210 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 31 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 31 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 38 |
|
design | DesignForExtension | Class 'CreateAccountController' looks like designed for extension (can be subclassed), but the method 'createNewCustomerForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateAccountController' final or making the method 'createNewCustomerForm' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
misc | FinalParameters | Parameter model should be final. | 40 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 42 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 48 |
|
design | DesignForExtension | Class 'CreateAccountController' looks like designed for extension (can be subclassed), but the method 'createNewCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateAccountController' final or making the method 'createNewCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 51 |
|
misc | FinalParameters | Parameter createNewCustomerFormBean should be final. | 51 |
|
misc | FinalParameters | Parameter result should be final. | 52 |
|
misc | FinalParameters | Parameter model should be final. | 52 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 54 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 54 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 141). | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 57 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 57 |
|
sizes | LineLength | Line is longer than 80 characters (found 123). | 58 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 58 |
|
sizes | LineLength | Line is longer than 80 characters (found 126). | 59 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 59 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 59 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 63 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 64 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 69 |
|
sizes | LineLength | Line is longer than 80 characters (found 130). | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 172). | 72 |
|
whitespace | MethodParamPad | '(' is preceded with whitespace. | 72 |
|
whitespace | MethodParamPad | '(' is preceded with whitespace. | 72 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 72 |
|
whitespace | MethodParamPad | '(' is preceded with whitespace. | 72 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 72 |
|
whitespace | MethodParamPad | '(' is preceded with whitespace. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 73 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 15 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 15 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 15 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
|
design | DesignForExtension | Class 'LoginController' looks like designed for extension (can be subclassed), but the method 'showLoginForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LoginController' final or making the method 'showLoginForm' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
misc | FinalParameters | Parameter model should be final. | 18 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 18 |
|
design | DesignForExtension | Class 'LoginController' looks like designed for extension (can be subclassed), but the method 'showAdminLoginForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LoginController' final or making the method 'showAdminLoginForm' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
misc | FinalParameters | Parameter model should be final. | 24 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 24 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.springframework.web.bind.annotation.*. | 8 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 22 |
|
design | DesignForExtension | Class 'SearchController' looks like designed for extension (can be subclassed), but the method 'showAdvancedSearchForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SearchController' final or making the method 'showAdvancedSearchForm' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
misc | FinalParameters | Parameter model should be final. | 25 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 30 |
|
design | DesignForExtension | Class 'SearchController' looks like designed for extension (can be subclassed), but the method 'showAdvancedSearchFormPost' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SearchController' final or making the method 'showAdvancedSearchFormPost' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 35 |
|
misc | FinalParameters | Parameter advancedSearchBean should be final. | 37 |
|
misc | FinalParameters | Parameter result should be final. | 38 |
|
misc | FinalParameters | Parameter model should be final. | 39 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 39 |
|
design | DesignForExtension | Class 'SearchController' looks like designed for extension (can be subclassed), but the method 'showAdvancedSearchForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SearchController' final or making the method 'showAdvancedSearchForm' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
misc | FinalParameters | Parameter keywords should be final. | 47 |
|
misc | FinalParameters | Parameter model should be final. | 47 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 47 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.springframework.web.bind.annotation.*. | 20 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.customer.entities.*. | 29 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 38 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 38 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'initBinder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'initBinder' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
|
misc | FinalParameters | Parameter binder should be final. | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 56 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 59 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'account' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'account' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
|
misc | FinalParameters | Parameter model should be final. | 61 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 61 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 65 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountEdit' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountEdit' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
|
misc | FinalParameters | Parameter model should be final. | 67 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 69 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 71 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 75 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountEditSave' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountEditSave' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 78 |
|
misc | FinalParameters | Parameter customerDetails should be final. | 78 |
|
misc | FinalParameters | Parameter result should be final. | 78 |
|
misc | FinalParameters | Parameter model should be final. | 78 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 78 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 80 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 83 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 85 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 97 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'addressBook' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'addressBook' static/final/abstract/empty, or adding allowed annotation for the method. | 98 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 98 |
|
misc | FinalParameters | Parameter model should be final. | 99 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 99 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 101 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 103 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 104 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 105 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 106 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 107 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 109 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 113 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'addressBookEditForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'addressBookEditForm' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 114 |
|
misc | FinalParameters | Parameter addressId should be final. | 114 |
|
misc | FinalParameters | Parameter model should be final. | 114 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 114 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 118 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 119 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 120 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 121 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 122 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 122 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 128 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 134 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 137 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 138 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'addressBookEditStore' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'addressBookEditStore' static/final/abstract/empty, or adding allowed annotation for the method. | 138 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 138 |
|
misc | FinalParameters | Parameter customersAddress should be final. | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 141 |
|
misc | FinalParameters | Parameter addressId should be final. | 141 |
|
misc | FinalParameters | Parameter model should be final. | 141 |
|
misc | FinalParameters | Parameter result should be final. | 141 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 141 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 142 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 144 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 145 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 146 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 148 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 149 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 149 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 152 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 153 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 155 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 157 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 158 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 159 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 160 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 162 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 163 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 167 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 169 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'addressBookAddForm' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'addressBookAddForm' static/final/abstract/empty, or adding allowed annotation for the method. | 170 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 170 |
|
misc | FinalParameters | Parameter model should be final. | 171 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 171 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 173 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 175 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 176 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 177 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 178 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 178 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 180 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 183 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'addressBookAddPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'addressBookAddPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 184 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 184 |
|
sizes | LineLength | Line is longer than 80 characters (found 123). | 185 |
|
misc | FinalParameters | Parameter customersAddress should be final. | 185 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 185 |
|
misc | FinalParameters | Parameter model should be final. | 185 |
|
misc | FinalParameters | Parameter result should be final. | 185 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 185 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 186 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 188 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 189 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 190 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 190 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 192 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 193 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 193 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 194 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 198 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 201 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 203 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 204 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 205 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 206 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 208 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 209 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 215 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 216 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'addressBookDelete' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'addressBookDelete' static/final/abstract/empty, or adding allowed annotation for the method. | 216 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 216 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 217 |
|
misc | FinalParameters | Parameter addressId should be final. | 217 |
|
misc | FinalParameters | Parameter model should be final. | 217 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 217 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 218 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 219 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 221 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 222 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 222 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 228 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 229 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 229 |
|
misc | FinalParameters | Parameter model should be final. | 230 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 230 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 232 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 236 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountPasswordPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountPasswordPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 237 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 237 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 238 |
|
misc | FinalParameters | Parameter changePasswordBean should be final. | 238 |
|
misc | FinalParameters | Parameter result should be final. | 239 |
|
misc | FinalParameters | Parameter model should be final. | 239 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 239 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 241 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 243 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 244 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 244 |
|
whitespace | WhitespaceAround | '&&' is not followed by whitespace. | 245 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 245 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 246 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 250 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 250 |
|
sizes | LineLength | Line is longer than 80 characters (found 131). | 251 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 251 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 251 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 254 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 254 |
|
sizes | LineLength | Line is longer than 80 characters (found 119). | 255 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 255 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 255 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 258 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 262 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountHistory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountHistory' static/final/abstract/empty, or adding allowed annotation for the method. | 263 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 263 |
|
misc | FinalParameters | Parameter model should be final. | 264 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 264 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 268 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 268 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 272 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 273 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountHistoryInfo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountHistoryInfo' static/final/abstract/empty, or adding allowed annotation for the method. | 273 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 273 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 274 |
|
misc | FinalParameters | Parameter orderId should be final. | 274 |
|
misc | FinalParameters | Parameter model should be final. | 274 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 274 |
|
sizes | LineLength | Line is longer than 80 characters (found 123). | 277 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 277 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 278 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 278 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 281 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 282 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountNewsletter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountNewsletter' static/final/abstract/empty, or adding allowed annotation for the method. | 282 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 282 |
|
misc | FinalParameters | Parameter model should be final. | 283 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 283 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 285 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 287 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 292 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountNewsletterPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountNewsletterPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 292 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 292 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 293 |
|
misc | FinalParameters | Parameter customer should be final. | 293 |
|
misc | FinalParameters | Parameter result should be final. | 293 |
|
misc | FinalParameters | Parameter model should be final. | 293 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 295 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 297 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 298 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 298 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 307 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 308 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountNotifications' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountNotifications' static/final/abstract/empty, or adding allowed annotation for the method. | 308 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 308 |
|
misc | FinalParameters | Parameter model should be final. | 309 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 309 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 312 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 314 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 315 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 319 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 319 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 320 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 324 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'accountNotificationsPerform' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'accountNotificationsPerform' static/final/abstract/empty, or adding allowed annotation for the method. | 324 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 324 |
|
misc | FinalParameters | Parameter customerInfo should be final. | 326 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 327 |
|
misc | FinalParameters | Parameter productNotification should be final. | 327 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 327 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 327 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 327 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 327 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 327 |
|
misc | ArrayTypeStyle | Array brackets at illegal position. | 327 |
|
misc | FinalParameters | Parameter result should be final. | 328 |
|
misc | FinalParameters | Parameter model should be final. | 328 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 328 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 330 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 332 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 333 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 334 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 334 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 339 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 342 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 342 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 347 |
|
design | DesignForExtension | Class 'UserController' looks like designed for extension (can be subclassed), but the method 'addProductNotification' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserController' final or making the method 'addProductNotification' static/final/abstract/empty, or adding allowed annotation for the method. | 347 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 347 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 348 |
|
misc | FinalParameters | Parameter productId should be final. | 348 |
|
misc | FinalParameters | Parameter model should be final. | 348 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 351 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 353 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 354 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 355 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 355 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 356 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 356 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 5 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 24 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 24 |
|
coding | MagicNumber | '255' is a magic number. | 24 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 27 |
|
coding | MagicNumber | '60' is a magic number. | 27 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
|
misc | FinalParameters | Parameter id should be final. | 34 |
|
coding | HiddenField | 'id' hides a field. | 34 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'getUserName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'getUserName' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'setUserName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'setUserName' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 42 |
|
misc | FinalParameters | Parameter userName should be final. | 42 |
|
coding | HiddenField | 'userName' hides a field. | 42 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'getUserPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'getUserPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 46 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'setUserPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'setUserPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 50 |
|
misc | FinalParameters | Parameter userPassword should be final. | 50 |
|
coding | HiddenField | 'userPassword' hides a field. | 50 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
misc | FinalParameters | Parameter o should be final. | 55 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 56 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 57 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 62 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 63 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 63 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
coding | MagicNumber | '31' is a magic number. | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 72 |
|
coding | MagicNumber | '31' is a magic number. | 72 |
|
design | DesignForExtension | Class 'Administrator' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Administrator' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 78 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 79 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 80 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 6 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 8 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 9 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 10 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 13 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 14 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 15 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 16 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 24 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
misc | FinalParameters | Parameter id should be final. | 45 |
|
coding | HiddenField | 'id' hides a field. | 45 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'getTitle' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'getTitle' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'setTitle' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'setTitle' static/final/abstract/empty, or adding allowed annotation for the method. | 53 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 53 |
|
misc | FinalParameters | Parameter title should be final. | 53 |
|
coding | HiddenField | 'title' hides a field. | 53 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'getDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'getDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'setDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'setDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
misc | FinalParameters | Parameter description should be final. | 61 |
|
coding | HiddenField | 'description' hides a field. | 61 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 69 |
|
misc | FinalParameters | Parameter lastModified should be final. | 69 |
|
coding | HiddenField | 'lastModified' hides a field. | 69 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 73 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 73 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 77 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 77 |
|
coding | HiddenField | 'dateAdded' hides a field. | 77 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 81 |
|
misc | FinalParameters | Parameter o should be final. | 82 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 83 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 84 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 88 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 89 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 89 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 91 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 92 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 94 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 94 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
coding | MagicNumber | '31' is a magic number. | 102 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 103 |
|
coding | MagicNumber | '31' is a magic number. | 103 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 104 |
|
coding | MagicNumber | '31' is a magic number. | 104 |
|
coding | MagicNumber | '31' is a magic number. | 105 |
|
design | DesignForExtension | Class 'TaxClass' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClass' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 109 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 111 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 112 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 113 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 114 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 115 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 116 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 5 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 8 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 28 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 29 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 29 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 40 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
coding | MagicNumber | '255' is a magic number. | 46 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 50 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 54 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 54 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
|
misc | FinalParameters | Parameter id should be final. | 62 |
|
coding | HiddenField | 'id' hides a field. | 62 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'getTaxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'getTaxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'setTaxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'setTaxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
misc | FinalParameters | Parameter taxZone should be final. | 70 |
|
coding | HiddenField | 'taxZone' hides a field. | 70 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'getTaxClass' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'getTaxClass' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 74 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'setTaxClass' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'setTaxClass' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 78 |
|
misc | FinalParameters | Parameter taxClass should be final. | 78 |
|
coding | HiddenField | 'taxClass' hides a field. | 78 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'getPriority' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'getPriority' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 82 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'setPriority' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'setPriority' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 86 |
|
misc | FinalParameters | Parameter priority should be final. | 86 |
|
coding | HiddenField | 'priority' hides a field. | 86 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'getTaxRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'getTaxRate' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 90 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'setTaxRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'setTaxRate' static/final/abstract/empty, or adding allowed annotation for the method. | 94 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 94 |
|
misc | FinalParameters | Parameter taxRate should be final. | 94 |
|
coding | HiddenField | 'taxRate' hides a field. | 94 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'getDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'getDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 98 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 98 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'setDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'setDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 102 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 102 |
|
misc | FinalParameters | Parameter description should be final. | 102 |
|
coding | HiddenField | 'description' hides a field. | 102 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 106 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 106 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 110 |
|
misc | FinalParameters | Parameter lastModified should be final. | 110 |
|
coding | HiddenField | 'lastModified' hides a field. | 110 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 114 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 114 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 118 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 118 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 118 |
|
coding | HiddenField | 'dateAdded' hides a field. | 118 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 122 |
|
misc | FinalParameters | Parameter o should be final. | 123 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 124 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 125 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 129 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 130 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 132 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 132 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 133 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 133 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 135 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 135 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 136 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 136 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 137 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 137 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 138 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 138 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 143 |
|
coding | MagicNumber | '31' is a magic number. | 146 |
|
coding | MagicNumber | '31' is a magic number. | 147 |
|
coding | MagicNumber | '31' is a magic number. | 148 |
|
coding | MagicNumber | '31' is a magic number. | 149 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 150 |
|
coding | MagicNumber | '31' is a magic number. | 150 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 151 |
|
coding | MagicNumber | '31' is a magic number. | 151 |
|
coding | MagicNumber | '31' is a magic number. | 152 |
|
design | DesignForExtension | Class 'TaxRate' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRate' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 156 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 158 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 159 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 160 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 161 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 162 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 163 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 164 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 165 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 166 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 7 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 10 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 28 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 28 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 33 |
|
coding | MagicNumber | '32' is a magic number. | 33 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
coding | MagicNumber | '255' is a magic number. | 39 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 40 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 51 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
|
misc | FinalParameters | Parameter id should be final. | 55 |
|
coding | HiddenField | 'id' hides a field. | 55 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 59 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 63 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
|
misc | FinalParameters | Parameter name should be final. | 63 |
|
coding | HiddenField | 'name' hides a field. | 63 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'getDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'getDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 67 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'setDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'setDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 71 |
|
misc | FinalParameters | Parameter description should be final. | 71 |
|
coding | HiddenField | 'description' hides a field. | 71 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 75 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
|
misc | FinalParameters | Parameter lastModified should be final. | 79 |
|
coding | HiddenField | 'lastModified' hides a field. | 79 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 87 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 87 |
|
coding | HiddenField | 'dateAdded' hides a field. | 87 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
misc | FinalParameters | Parameter o should be final. | 92 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 93 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 94 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 98 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 98 |
|
sizes | LineLength | Line is longer than 80 characters (found 119). | 99 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 99 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 100 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 100 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 101 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 101 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 103 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 103 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 108 |
|
coding | MagicNumber | '31' is a magic number. | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 112 |
|
coding | MagicNumber | '31' is a magic number. | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 113 |
|
coding | MagicNumber | '31' is a magic number. | 113 |
|
coding | MagicNumber | '31' is a magic number. | 114 |
|
design | DesignForExtension | Class 'TaxZone' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 118 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 120 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 121 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 122 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 123 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 124 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 125 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 8 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 12 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
|
misc | FinalParameters | Parameter id should be final. | 60 |
|
coding | HiddenField | 'id' hides a field. | 60 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'getZoneCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'getZoneCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 64 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'setZoneCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'setZoneCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
|
misc | FinalParameters | Parameter zoneCountry should be final. | 68 |
|
coding | HiddenField | 'zoneCountry' hides a field. | 68 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'getZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'getZone' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'setZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'setZone' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
|
misc | FinalParameters | Parameter zone should be final. | 76 |
|
coding | HiddenField | 'zone' hides a field. | 76 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'getTaxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'getTaxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 80 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 80 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'setTaxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'setTaxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 84 |
|
misc | FinalParameters | Parameter taxZone should be final. | 84 |
|
coding | HiddenField | 'taxZone' hides a field. | 84 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 88 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 88 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 92 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 92 |
|
misc | FinalParameters | Parameter lastModified should be final. | 92 |
|
coding | HiddenField | 'lastModified' hides a field. | 92 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 96 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 100 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 100 |
|
coding | HiddenField | 'dateAdded' hides a field. | 100 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 104 |
|
misc | FinalParameters | Parameter o should be final. | 105 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 106 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 107 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 111 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 113 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 114 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 114 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 115 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 115 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 116 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 121 |
|
coding | MagicNumber | '31' is a magic number. | 124 |
|
coding | MagicNumber | '31' is a magic number. | 125 |
|
coding | MagicNumber | '31' is a magic number. | 126 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 127 |
|
coding | MagicNumber | '31' is a magic number. | 127 |
|
coding | MagicNumber | '31' is a magic number. | 128 |
|
design | DesignForExtension | Class 'TaxZone2Zone' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2Zone' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 132 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 134 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 135 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 136 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 137 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 138 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 139 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 140 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
misc | FinalParameters | Parameter administrator should be final. | 22 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'getAuthorities' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'getAuthorities' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'getPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'getPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'getUsername' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'getUsername' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'isAccountNonExpired' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'isAccountNonExpired' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'isAccountNonLocked' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'isAccountNonLocked' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'isCredentialsNonExpired' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'isCredentialsNonExpired' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'isEnabled' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'isEnabled' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
misc | FinalParameters | Parameter o should be final. | 66 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 67 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 72 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 73 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 73 |
|
design | DesignForExtension | Class 'AdministratorBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
|
coding | MagicNumber | '31' is a magic number. | 81 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
naming | MemberName | Name 'zone_country_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
naming | MemberName | Name 'zone_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 10 |
|
design | DesignForExtension | Class 'NewSubZoneInfoBean' looks like designed for extension (can be subclassed), but the method 'getZone_country_id' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NewSubZoneInfoBean' final or making the method 'getZone_country_id' static/final/abstract/empty, or adding allowed annotation for the method. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
naming | MethodName | Name 'getZone_country_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 12 |
|
design | DesignForExtension | Class 'NewSubZoneInfoBean' looks like designed for extension (can be subclassed), but the method 'setZone_country_id' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NewSubZoneInfoBean' final or making the method 'setZone_country_id' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
naming | MethodName | Name 'setZone_country_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 16 |
|
misc | FinalParameters | Parameter zone_country_id should be final. | 16 |
|
coding | HiddenField | 'zone_country_id' hides a field. | 16 |
|
naming | ParameterName | Name 'zone_country_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 16 |
|
design | DesignForExtension | Class 'NewSubZoneInfoBean' looks like designed for extension (can be subclassed), but the method 'getZone_id' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NewSubZoneInfoBean' final or making the method 'getZone_id' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
naming | MethodName | Name 'getZone_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 20 |
|
design | DesignForExtension | Class 'NewSubZoneInfoBean' looks like designed for extension (can be subclassed), but the method 'setZone_id' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NewSubZoneInfoBean' final or making the method 'setZone_id' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
naming | MethodName | Name 'setZone_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 24 |
|
misc | FinalParameters | Parameter zone_id should be final. | 24 |
|
coding | HiddenField | 'zone_id' hides a field. | 24 |
|
naming | ParameterName | Name 'zone_id' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 24 |
|
design | DesignForExtension | Class 'NewSubZoneInfoBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NewSubZoneInfoBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
misc | FinalParameters | Parameter o should be final. | 29 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 30 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 31 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 35 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 37 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 37 |
|
design | DesignForExtension | Class 'NewSubZoneInfoBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NewSubZoneInfoBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
|
coding | MagicNumber | '31' is a magic number. | 45 |
|
design | DesignForExtension | Class 'NewSubZoneInfoBean' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NewSubZoneInfoBean' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 51 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 52 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 53 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'getOrderId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'getOrderId' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'setOrderId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'setOrderId' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
misc | FinalParameters | Parameter orderId should be final. | 28 |
|
coding | HiddenField | 'orderId' hides a field. | 28 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'getCustomerName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'getCustomerName' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'setCustomerName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'setCustomerName' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
misc | FinalParameters | Parameter customerName should be final. | 36 |
|
coding | HiddenField | 'customerName' hides a field. | 36 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'getOrderTotal' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'getOrderTotal' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'setOrderTotal' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'setOrderTotal' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
misc | FinalParameters | Parameter orderTotal should be final. | 44 |
|
coding | HiddenField | 'orderTotal' hides a field. | 44 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'getOrderPlaced' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'getOrderPlaced' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'setOrderPlaced' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'setOrderPlaced' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
|
misc | FinalParameters | Parameter orderPlaced should be final. | 52 |
|
coding | HiddenField | 'orderPlaced' hides a field. | 52 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'getOrderStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'getOrderStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'setOrderStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'setOrderStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
|
misc | FinalParameters | Parameter orderStatus should be final. | 60 |
|
coding | HiddenField | 'orderStatus' hides a field. | 60 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'getPaymentMethod' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'getPaymentMethod' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 64 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'setPaymentMethod' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'setPaymentMethod' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
|
misc | FinalParameters | Parameter paymentMethod should be final. | 68 |
|
coding | HiddenField | 'paymentMethod' hides a field. | 68 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
misc | FinalParameters | Parameter o should be final. | 73 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 74 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 75 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 79 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
coding | MagicNumber | '32' is a magic number. | 86 |
|
design | DesignForExtension | Class 'OrderAdminBean' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderAdminBean' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 89 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 91 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 92 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 93 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 94 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 95 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 96 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 97 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 9 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 13 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 27 |
|
misc | FinalParameters | Parameter administratorRepository should be final. | 27 |
|
coding | HiddenField | 'administratorRepository' hides a field. | 27 |
|
misc | FinalParameters | Parameter encoder should be final. | 27 |
|
coding | HiddenField | 'encoder' hides a field. | 27 |
|
design | DesignForExtension | Class 'AdministratorServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllAdministrators' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorServiceImpl' final or making the method 'findAllAdministrators' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
design | DesignForExtension | Class 'AdministratorServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAdministratorById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorServiceImpl' final or making the method 'findAdministratorById' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
misc | FinalParameters | Parameter administratorId should be final. | 38 |
|
design | DesignForExtension | Class 'AdministratorServiceImpl' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorServiceImpl' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
misc | FinalParameters | Parameter thisAdministrator should be final. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 45 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 46 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 46 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 46 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 47 |
|
design | DesignForExtension | Class 'AdministratorServiceImpl' looks like designed for extension (can be subclassed), but the method 'create' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorServiceImpl' final or making the method 'create' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
misc | FinalParameters | Parameter thisAdministrator should be final. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 55 |
|
design | DesignForExtension | Class 'AdministratorServiceImpl' looks like designed for extension (can be subclassed), but the method 'delete' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorServiceImpl' final or making the method 'delete' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
misc | FinalParameters | Parameter thisAdministrator should be final. | 61 |
|
design | DesignForExtension | Class 'AdministratorServiceImpl' looks like designed for extension (can be subclassed), but the method 'loadUserByUsername' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdministratorServiceImpl' final or making the method 'loadUserByUsername' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 66 |
|
misc | FinalParameters | Parameter username should be final. | 66 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 67 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 68 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 68 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
design | DesignForExtension | Class 'TaxClassServiceImpl' looks like designed for extension (can be subclassed), but the method 'findById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassServiceImpl' final or making the method 'findById' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
misc | FinalParameters | Parameter taxClassId should be final. | 26 |
|
design | DesignForExtension | Class 'TaxClassServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassServiceImpl' final or making the method 'findAll' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
design | DesignForExtension | Class 'TaxClassServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassServiceImpl' final or making the method 'findAll' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
misc | FinalParameters | Parameter pageRequest should be final. | 36 |
|
design | DesignForExtension | Class 'TaxClassServiceImpl' looks like designed for extension (can be subclassed), but the method 'create' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassServiceImpl' final or making the method 'create' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
misc | FinalParameters | Parameter thisTaxClass should be final. | 42 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
design | DesignForExtension | Class 'TaxClassServiceImpl' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassServiceImpl' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
misc | FinalParameters | Parameter thisTaxClass should be final. | 49 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
design | DesignForExtension | Class 'TaxClassServiceImpl' looks like designed for extension (can be subclassed), but the method 'delete' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxClassServiceImpl' final or making the method 'delete' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
misc | FinalParameters | Parameter thisTaxClass should be final. | 56 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
design | DesignForExtension | Class 'TaxRateServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateServiceImpl' final or making the method 'findAll' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
misc | FinalParameters | Parameter pageRequest should be final. | 25 |
|
design | DesignForExtension | Class 'TaxRateServiceImpl' looks like designed for extension (can be subclassed), but the method 'findById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateServiceImpl' final or making the method 'findById' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
misc | FinalParameters | Parameter taxRateId should be final. | 30 |
|
design | DesignForExtension | Class 'TaxRateServiceImpl' looks like designed for extension (can be subclassed), but the method 'delete' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateServiceImpl' final or making the method 'delete' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
misc | FinalParameters | Parameter thisTaxRate should be final. | 36 |
|
design | DesignForExtension | Class 'TaxRateServiceImpl' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateServiceImpl' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
misc | FinalParameters | Parameter loadedTaxRate should be final. | 42 |
|
design | DesignForExtension | Class 'TaxRateServiceImpl' looks like designed for extension (can be subclassed), but the method 'create' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxRateServiceImpl' final or making the method 'create' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
misc | FinalParameters | Parameter thisTaxRate should be final. | 48 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
|
design | DesignForExtension | Class 'TaxZone2ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'createTaxZone2Zone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2ZoneServiceImpl' final or making the method 'createTaxZone2Zone' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 24 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 24 |
|
misc | FinalParameters | Parameter newTaxZone2Zone should be final. | 25 |
|
design | DesignForExtension | Class 'TaxZone2ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'deleteTaxZone2Zone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2ZoneServiceImpl' final or making the method 'deleteTaxZone2Zone' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
misc | FinalParameters | Parameter thisZone should be final. | 31 |
|
design | DesignForExtension | Class 'TaxZone2ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'updateTaxZone2Zone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2ZoneServiceImpl' final or making the method 'updateTaxZone2Zone' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 36 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 36 |
|
misc | FinalParameters | Parameter thisZone should be final. | 37 |
|
design | DesignForExtension | Class 'TaxZone2ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'getNumberOfZonesForTaxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2ZoneServiceImpl' final or making the method 'getNumberOfZonesForTaxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
misc | FinalParameters | Parameter thisTaxZone should be final. | 42 |
|
design | DesignForExtension | Class 'TaxZone2ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'findZonesByTaxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2ZoneServiceImpl' final or making the method 'findZonesByTaxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
|
misc | FinalParameters | Parameter thisTaxZone should be final. | 47 |
|
design | DesignForExtension | Class 'TaxZone2ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'findTaxZone2ZoneById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZone2ZoneServiceImpl' final or making the method 'findTaxZone2ZoneById' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
|
misc | FinalParameters | Parameter zoneId should be final. | 52 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
design | DesignForExtension | Class 'TaxZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'createTaxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneServiceImpl' final or making the method 'createTaxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 |
|
misc | FinalParameters | Parameter thisTaxZone should be final. | 32 |
|
design | DesignForExtension | Class 'TaxZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'deleteTaxZones' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneServiceImpl' final or making the method 'deleteTaxZones' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 37 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 37 |
|
misc | FinalParameters | Parameter thisTaxZone should be final. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
design | DesignForExtension | Class 'TaxZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'updateTaxZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneServiceImpl' final or making the method 'updateTaxZone' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 46 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 46 |
|
misc | FinalParameters | Parameter thisTaxZone should be final. | 47 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
design | DesignForExtension | Class 'TaxZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneServiceImpl' final or making the method 'findAll' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
|
design | DesignForExtension | Class 'TaxZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllTaxZones' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneServiceImpl' final or making the method 'findAllTaxZones' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
misc | FinalParameters | Parameter pageRequest should be final. | 61 |
|
design | DesignForExtension | Class 'TaxZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'findTaxZoneById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TaxZoneServiceImpl' final or making the method 'findTaxZoneById' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
misc | FinalParameters | Parameter taxZoneId should be final. | 66 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 12 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 122). | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 39 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
|
design | DesignForExtension | Class 'CartServiceImpl' looks like designed for extension (can be subclassed), but the method 'addProductToCart' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CartServiceImpl' final or making the method 'addProductToCart' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 53 |
|
misc | FinalParameters | Parameter productId should be final. | 53 |
|
misc | FinalParameters | Parameter optionsAndValues should be final. | 53 |
|
misc | FinalParameters | Parameter language should be final. | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 57 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 58 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 58 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 58 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 58 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 60 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 61 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 62 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 62 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 153). | 63 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 64 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 64 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 73 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 74 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 80 |
|
sizes | LineLength | Line is longer than 80 characters (found 129). | 81 |
|
misc | FinalParameters | Parameter productId should be final. | 81 |
|
misc | FinalParameters | Parameter optionsAndValues should be final. | 81 |
|
misc | FinalParameters | Parameter language should be final. | 81 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 81 |
|
sizes | LineLength | Line is longer than 80 characters (found 114). | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 108). | 85 |
|
sizes | LineLength | Line is longer than 80 characters (found 116). | 87 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 89 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 89 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 92 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 153). | 93 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 93 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 93 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 94 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 94 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 95 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 95 |
|
sizes | LineLength | Line is longer than 80 characters (found 151). | 96 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 96 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 97 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 97 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 97 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 97 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 97 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 98 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 103 |
|
design | DesignForExtension | Class 'CartServiceImpl' looks like designed for extension (can be subclassed), but the method 'removeProductFromCart' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CartServiceImpl' final or making the method 'removeProductFromCart' static/final/abstract/empty, or adding allowed annotation for the method. | 107 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 108 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 108 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 110 |
|
misc | FinalParameters | Parameter productId should be final. | 110 |
|
misc | FinalParameters | Parameter optionsAndValues should be final. | 111 |
|
misc | FinalParameters | Parameter language should be final. | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 114 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 115 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 115 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 115 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 115 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 117 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 118 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 118 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 118 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 118 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 119 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 119 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 119 |
|
sizes | LineLength | Line is longer than 80 characters (found 153). | 120 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 120 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 121 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 121 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 122 |
|
design | DesignForExtension | Class 'CartServiceImpl' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CartServiceImpl' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 129 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 130 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 130 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 130 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 130 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 131 |
|
misc | FinalParameters | Parameter cartQuantity should be final. | 131 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 131 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 132 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 133 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 133 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 133 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 133 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 135 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 136 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 136 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 136 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 136 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 137 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 137 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 137 |
|
whitespace | WhitespaceAfter | ';' is not followed by whitespace. | 137 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 137 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 137 |
|
whitespace | WhitespaceAfter | ';' is not followed by whitespace. | 137 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 137 |
|
sizes | LineLength | Line is longer than 80 characters (found 146). | 138 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 138 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 138 |
|
sizes | LineLength | Line is longer than 80 characters (found 161). | 139 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 139 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 140 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 141 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 143 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 144 |
|
design | DesignForExtension | Class 'CartServiceImpl' looks like designed for extension (can be subclassed), but the method 'polulateByPersistentBasket' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CartServiceImpl' final or making the method 'polulateByPersistentBasket' static/final/abstract/empty, or adding allowed annotation for the method. | 152 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 153 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 153 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 153 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 153 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 153 |
|
sizes | LineLength | Line is longer than 80 characters (found 130). | 154 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 154 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 154 |
|
misc | FinalParameters | Parameter language should be final. | 154 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 154 |
|
misc | FinalParameters | Parameter auth should be final. | 154 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 155 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 155 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 155 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 155 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 157 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 158 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 158 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 158 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 158 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 159 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 160 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 161 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 161 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 161 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 162 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 163 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 164 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 164 |
|
sizes | LineLength | Line is longer than 80 characters (found 147). | 165 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 166 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 167 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 169 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 169 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 170 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 171 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 171 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 172 |
|
sizes | LineLength | Line is longer than 80 characters (found 119). | 173 |
|
sizes | LineLength | Line is longer than 80 characters (found 161). | 174 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 174 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 175 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 175 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 175 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 175 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 176 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 177 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 178 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 181 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 182 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 184 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 185 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 19 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 21 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 28 |
|
design | DesignForExtension | Class 'PopulateBasketAfterLogin' looks like designed for extension (can be subclassed), but the method 'onAuthenticationSuccess' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PopulateBasketAfterLogin' final or making the method 'onAuthenticationSuccess' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 31 |
|
misc | FinalParameters | Parameter request should be final. | 31 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
|
misc | FinalParameters | Parameter response should be final. | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 33 |
|
misc | FinalParameters | Parameter authentication should be final. | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 108). | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 133). | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 38 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 20 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 22 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 23 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 24 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 26 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 27 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 29 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 30 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 31 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 39 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 50 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 52 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 54 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 56 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 58 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 59 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 59 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 59 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 61 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 62 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 62 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 62 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 62 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 64 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 65 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 65 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 65 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 65 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 67 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 68 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 68 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 71 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 75 |
|
misc | FinalParameters | Parameter id should be final. | 75 |
|
coding | HiddenField | 'id' hides a field. | 75 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'getCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'getCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'setCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'setCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
|
misc | FinalParameters | Parameter customer should be final. | 83 |
|
coding | HiddenField | 'customer' hides a field. | 83 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'getProductId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'getProductId' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 87 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'setProductId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'setProductId' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 91 |
|
misc | FinalParameters | Parameter productId should be final. | 91 |
|
coding | HiddenField | 'productId' hides a field. | 91 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'getQuantity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'getQuantity' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'setQuantity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'setQuantity' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
misc | FinalParameters | Parameter quantity should be final. | 99 |
|
coding | HiddenField | 'quantity' hides a field. | 99 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'getFinalPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'getFinalPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 103 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'setFinalPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'setFinalPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 107 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 107 |
|
misc | FinalParameters | Parameter finalPrice should be final. | 107 |
|
coding | HiddenField | 'finalPrice' hides a field. | 107 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 111 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 115 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 115 |
|
coding | HiddenField | 'dateAdded' hides a field. | 115 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 119 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 119 |
|
misc | FinalParameters | Parameter now should be final. | 120 |
|
coding | HiddenField | 'dateAdded' hides a field. | 121 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 122 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 122 |
|
coding | MagicNumber | '1900' is a magic number. | 122 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 123 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 123 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 124 |
|
coding | MagicNumber | '10' is a magic number. | 124 |
|
whitespace | WhitespaceAround | '?' is not preceded with whitespace. | 124 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 124 |
|
whitespace | WhitespaceAround | ':' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | ':' is not preceded with whitespace. | 124 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 124 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 126 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 126 |
|
coding | MagicNumber | '10' is a magic number. | 126 |
|
whitespace | WhitespaceAround | '?' is not preceded with whitespace. | 126 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 126 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 126 |
|
whitespace | WhitespaceAround | ':' is not followed by whitespace. | 126 |
|
whitespace | WhitespaceAround | ':' is not preceded with whitespace. | 126 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 126 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 126 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 133 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 138 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 141 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 146 |
|
misc | FinalParameters | Parameter obj should be final. | 147 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 148 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 150 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 152 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 156 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 158 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 161 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 163 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 166 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 168 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 170 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 175 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 178 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 179 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'getProductIdAsLong' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'getProductIdAsLong' static/final/abstract/empty, or adding allowed annotation for the method. | 183 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 183 |
|
design | DesignForExtension | Class 'CustomersBasket' looks like designed for extension (can be subclassed), but the method 'getOptionsAndValues' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasket' final or making the method 'getOptionsAndValues' static/final/abstract/empty, or adding allowed annotation for the method. | 188 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 188 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 190 |
|
misc | ArrayTypeStyle | Array brackets at illegal position. | 191 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 192 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 192 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 192 |
|
whitespace | WhitespaceAfter | ';' is not followed by whitespace. | 192 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 192 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 192 |
|
whitespace | WhitespaceAfter | ';' is not followed by whitespace. | 192 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 192 |
|
misc | ArrayTypeStyle | Array brackets at illegal position. | 193 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 200 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 15 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 18 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 19 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 20 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 26 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 27 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 29 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 30 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 31 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 33 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 40 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 50 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 50 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 54 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 54 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 57 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 58 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 58 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 58 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 62 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 62 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 62 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 69 |
|
misc | FinalParameters | Parameter id should be final. | 69 |
|
coding | HiddenField | 'id' hides a field. | 69 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'getCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'getCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 73 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 73 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'setCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'setCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 77 |
|
misc | FinalParameters | Parameter customer should be final. | 77 |
|
coding | HiddenField | 'customer' hides a field. | 77 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'getProductId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'getProductId' static/final/abstract/empty, or adding allowed annotation for the method. | 81 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 81 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'setProductId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'setProductId' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 85 |
|
misc | FinalParameters | Parameter productId should be final. | 85 |
|
coding | HiddenField | 'productId' hides a field. | 85 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'getProductOptionId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'getProductOptionId' static/final/abstract/empty, or adding allowed annotation for the method. | 89 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 89 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'setProductOptionId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'setProductOptionId' static/final/abstract/empty, or adding allowed annotation for the method. | 93 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 93 |
|
misc | FinalParameters | Parameter productOptionId should be final. | 93 |
|
coding | HiddenField | 'productOptionId' hides a field. | 93 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'getProductOptionValueId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'getProductOptionValueId' static/final/abstract/empty, or adding allowed annotation for the method. | 97 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 97 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'setProductOptionValueId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'setProductOptionValueId' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 101 |
|
misc | FinalParameters | Parameter productOptionValueId should be final. | 101 |
|
coding | HiddenField | 'productOptionValueId' hides a field. | 101 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 107 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 108 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 118 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 121 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 123 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 126 |
|
design | DesignForExtension | Class 'CustomersBasketAttribute' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomersBasketAttribute' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 131 |
|
misc | FinalParameters | Parameter obj should be final. | 132 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 133 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 135 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 137 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 141 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 143 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 146 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 148 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 151 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 153 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 156 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 158 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 161 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 163 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 163 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 168 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 9 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 9 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 12 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 12 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 13 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'getSubTotal' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'getSubTotal' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 14 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 16 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 21 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'getSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'getSize' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 24 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 25 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 29 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'isEmptyCart' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'isEmptyCart' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 30 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'addProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'addProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
|
misc | FinalParameters | Parameter transientProduct should be final. | 34 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 36 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 45 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'addProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'addProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
misc | FinalParameters | Parameter transientProduct should be final. | 45 |
|
misc | FinalParameters | Parameter quantity should be final. | 45 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 46 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 47 |
|
whitespace | WhitespaceAround | '+=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '+=' is not preceded with whitespace. | 48 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 54 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 56 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'removeProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'removeProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
|
misc | FinalParameters | Parameter transientProduct should be final. | 57 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 65 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'getTransientProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'getTransientProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 72 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'setTransientProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'setTransientProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
misc | FinalParameters | Parameter transientProducts should be final. | 72 |
|
coding | HiddenField | 'transientProducts' hides a field. | 72 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'getNumberOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'getNumberOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 80 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'setNumberOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'setNumberOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 80 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 80 |
|
misc | FinalParameters | Parameter numberOfProducts should be final. | 80 |
|
coding | HiddenField | 'numberOfProducts' hides a field. | 80 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 84 |
|
misc | FinalParameters | Parameter cartQuantity should be final. | 84 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 85 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 85 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 86 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 86 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 87 |
|
whitespace | WhitespaceAfter | ';' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 87 |
|
whitespace | WhitespaceAfter | ';' is not followed by whitespace. | 87 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 88 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 89 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 89 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 90 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 94 |
|
design | DesignForExtension | Class 'TransientBasket' looks like designed for extension (can be subclassed), but the method 'clearBasket' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientBasket' final or making the method 'clearBasket' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 100 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 102 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 10 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 114). | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 13 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'getPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'getPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 14 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 16 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 18 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 19 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 27 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'getParameterForUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'getParameterForUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 28 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 30 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 39 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'getProductIdWithAttributes' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'getProductIdWithAttributes' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 43 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 43 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 51 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'getProductDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'getProductDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 55 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'setProductDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'setProductDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
|
misc | FinalParameters | Parameter productDescription should be final. | 55 |
|
coding | HiddenField | 'productDescription' hides a field. | 55 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'getProductOptionAttributeList' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'getProductOptionAttributeList' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'setProductOptionAttributeList' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'setProductOptionAttributeList' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 62 |
|
misc | FinalParameters | Parameter productOptionAttributeList should be final. | 62 |
|
coding | HiddenField | 'productOptionAttributeList' hides a field. | 62 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 76 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
misc | FinalParameters | Parameter obj should be final. | 80 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 81 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 83 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 85 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 89 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 91 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 94 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 96 |
|
design | DesignForExtension | Class 'TransientProduct' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TransientProduct' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 103 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 104 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 10 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 9 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 15 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.entities.*. | 6 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.model.*. | 7 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 11 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.*. | 3 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.entities.*. | 10 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.model.*. | 11 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.repositories.*. | 12 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 15 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 15 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 15 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 15 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 17 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 17 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 20 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
design | DesignForExtension | Class 'CatalogServiceImpl' looks like designed for extension (can be subclassed), but the method 'findProductOptionsByProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogServiceImpl' final or making the method 'findProductOptionsByProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
misc | FinalParameters | Parameter product should be final. | 50 |
|
sizes | LineLength | Line is longer than 80 characters (found 125). | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 150). | 53 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 63 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 69 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 69 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 77 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 89 |
|
design | DesignForExtension | Class 'CatalogServiceImpl' looks like designed for extension (can be subclassed), but the method 'findProductImages' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogServiceImpl' final or making the method 'findProductImages' static/final/abstract/empty, or adding allowed annotation for the method. | 93 |
|
misc | FinalParameters | Parameter product should be final. | 94 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 95 |
|
design | DesignForExtension | Class 'CatalogServiceImpl' looks like designed for extension (can be subclassed), but the method 'getNumberOfReviewsForProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CatalogServiceImpl' final or making the method 'getNumberOfReviewsForProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 98 |
|
misc | FinalParameters | Parameter product should be final. | 99 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | UnusedImports | Unused import - javax.persistence.FetchType. | 11 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 25 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 25 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 26 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 29 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 29 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 29 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 41 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 50 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 54 |
|
misc | FinalParameters | Parameter id should be final. | 54 |
|
coding | HiddenField | 'id' hides a field. | 54 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'getImage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'getImage' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'setImage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'setImage' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
|
misc | FinalParameters | Parameter image should be final. | 62 |
|
coding | HiddenField | 'image' hides a field. | 62 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'getParentId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'getParentId' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'setParentId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'setParentId' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
misc | FinalParameters | Parameter parentId should be final. | 70 |
|
coding | HiddenField | 'parentId' hides a field. | 70 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'getSortOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'getSortOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 74 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'setSortOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'setSortOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 78 |
|
misc | FinalParameters | Parameter sortOrder should be final. | 78 |
|
coding | HiddenField | 'sortOrder' hides a field. | 78 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 82 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 86 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 86 |
|
coding | HiddenField | 'dateAdded' hides a field. | 86 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 90 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 94 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 94 |
|
misc | FinalParameters | Parameter lastModified should be final. | 94 |
|
coding | HiddenField | 'lastModified' hides a field. | 94 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'getProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'getProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 98 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 98 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'setProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'setProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 102 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 102 |
|
misc | FinalParameters | Parameter products should be final. | 102 |
|
coding | HiddenField | 'products' hides a field. | 102 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 106 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 115 |
|
coding | MagicNumber | '32' is a magic number. | 116 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 121 |
|
misc | FinalParameters | Parameter obj should be final. | 122 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 123 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 125 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 127 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 131 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 133 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 136 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 138 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 141 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 143 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 146 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 148 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 150 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 152 |
|
design | DesignForExtension | Class 'Category' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Category' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 157 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 159 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 160 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 161 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 162 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 163 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 164 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 165 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 12 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 12 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 20 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 25 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'getCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'getCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'setCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'setCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
|
misc | FinalParameters | Parameter category should be final. | 33 |
|
coding | HiddenField | 'category' hides a field. | 33 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
|
misc | FinalParameters | Parameter language should be final. | 41 |
|
coding | HiddenField | 'language' hides a field. | 41 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
misc | FinalParameters | Parameter name should be final. | 49 |
|
coding | HiddenField | 'name' hides a field. | 49 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 58 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 60 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 61 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
misc | FinalParameters | Parameter obj should be final. | 66 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 67 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 69 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 71 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 75 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 77 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 80 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 82 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 85 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 87 |
|
design | DesignForExtension | Class 'CategoryDescription' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescription' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 92 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 94 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 95 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 96 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 97 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 7 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 10 |
|
design | DesignForExtension | Class 'CategoryDescriptionId' looks like designed for extension (can be subclassed), but the method 'getCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionId' final or making the method 'getCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
design | DesignForExtension | Class 'CategoryDescriptionId' looks like designed for extension (can be subclassed), but the method 'setCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionId' final or making the method 'setCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
misc | FinalParameters | Parameter category should be final. | 14 |
|
coding | HiddenField | 'category' hides a field. | 14 |
|
design | DesignForExtension | Class 'CategoryDescriptionId' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionId' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
design | DesignForExtension | Class 'CategoryDescriptionId' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionId' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
misc | FinalParameters | Parameter language should be final. | 20 |
|
coding | HiddenField | 'language' hides a field. | 20 |
|
design | DesignForExtension | Class 'CategoryDescriptionId' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionId' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 30 |
|
design | DesignForExtension | Class 'CategoryDescriptionId' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionId' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
|
misc | FinalParameters | Parameter obj should be final. | 34 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 35 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 37 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 39 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 43 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 45 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 48 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 50 |
|
design | DesignForExtension | Class 'CategoryDescriptionId' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionId' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 56 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 59 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 60 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 19 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 21 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
coding | MagicNumber | '32' is a magic number. | 24 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 25 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 25 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
coding | MagicNumber | '32' is a magic number. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 37 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
|
misc | FinalParameters | Parameter id should be final. | 48 |
|
coding | HiddenField | 'id' hides a field. | 48 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
|
misc | FinalParameters | Parameter name should be final. | 56 |
|
coding | HiddenField | 'name' hides a field. | 56 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'getCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'getCode' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'setCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'setCode' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 64 |
|
misc | FinalParameters | Parameter code should be final. | 64 |
|
coding | HiddenField | 'code' hides a field. | 64 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'getDirectory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'getDirectory' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'setDirectory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'setDirectory' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
misc | FinalParameters | Parameter directory should be final. | 72 |
|
coding | HiddenField | 'directory' hides a field. | 72 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'getSortOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'getSortOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'setSortOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'setSortOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 80 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 80 |
|
misc | FinalParameters | Parameter sortOrder should be final. | 80 |
|
coding | HiddenField | 'sortOrder' hides a field. | 80 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 86 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 87 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 94 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 98 |
|
design | DesignForExtension | Class 'Language' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Language' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
misc | FinalParameters | Parameter obj should be final. | 104 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 105 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 107 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 109 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 113 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 115 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 118 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 120 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 123 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 125 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 128 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 130 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 132 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 136 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 21 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 26 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 30 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 31 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
misc | FinalParameters | Parameter obj should be final. | 36 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 37 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 39 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 41 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 45 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 47 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 50 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 52 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 55 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 57 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 60 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 62 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 65 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 67 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 72 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 74 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 74 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 76 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 77 |
|
coding | MagicNumber | '32' is a magic number. | 77 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 78 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 78 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 81 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 82 |
|
coding | MagicNumber | '64' is a magic number. | 82 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 83 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 86 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 87 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 88 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 88 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 89 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 91 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 92 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 93 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 93 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 94 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 97 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 97 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 101 |
|
misc | FinalParameters | Parameter id should be final. | 101 |
|
coding | HiddenField | 'id' hides a field. | 101 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 105 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 109 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 109 |
|
misc | FinalParameters | Parameter name should be final. | 109 |
|
coding | HiddenField | 'name' hides a field. | 109 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'getImage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'getImage' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 113 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'setImage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'setImage' static/final/abstract/empty, or adding allowed annotation for the method. | 117 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 117 |
|
misc | FinalParameters | Parameter image should be final. | 117 |
|
coding | HiddenField | 'image' hides a field. | 117 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 121 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 121 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 125 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 125 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 125 |
|
coding | HiddenField | 'dateAdded' hides a field. | 125 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 129 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 129 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 133 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 133 |
|
misc | FinalParameters | Parameter lastModified should be final. | 133 |
|
coding | HiddenField | 'lastModified' hides a field. | 133 |
|
design | DesignForExtension | Class 'Manufacturer' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturer' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 137 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 139 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 140 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 143 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 144 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 7 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'getManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'getManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'setManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'setManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
misc | FinalParameters | Parameter manufacturer should be final. | 49 |
|
coding | HiddenField | 'manufacturer' hides a field. | 49 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 53 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 53 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
|
misc | FinalParameters | Parameter language should be final. | 57 |
|
coding | HiddenField | 'language' hides a field. | 57 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'getUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'getUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'setUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'setUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
|
misc | FinalParameters | Parameter url should be final. | 65 |
|
coding | HiddenField | 'url' hides a field. | 65 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'getUrlClicked' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'getUrlClicked' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 69 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'setUrlClicked' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'setUrlClicked' static/final/abstract/empty, or adding allowed annotation for the method. | 73 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 73 |
|
misc | FinalParameters | Parameter urlClicked should be final. | 73 |
|
coding | HiddenField | 'urlClicked' hides a field. | 73 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'getLastclick' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'getLastclick' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 77 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'setLastclick' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'setLastclick' static/final/abstract/empty, or adding allowed annotation for the method. | 81 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 81 |
|
misc | FinalParameters | Parameter lastclick should be final. | 81 |
|
coding | HiddenField | 'lastclick' hides a field. | 81 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
misc | FinalParameters | Parameter o should be final. | 86 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 87 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 88 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 92 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 93 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 94 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 94 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 95 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 96 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
coding | MagicNumber | '31' is a magic number. | 104 |
|
coding | MagicNumber | '31' is a magic number. | 105 |
|
coding | MagicNumber | '31' is a magic number. | 106 |
|
coding | MagicNumber | '31' is a magic number. | 107 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 113 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 114 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 115 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 116 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 117 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 118 |
|
design | DesignForExtension | Class 'ManufacturerInfo' looks like designed for extension (can be subclassed), but the method 'addClick' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfo' final or making the method 'addClick' static/final/abstract/empty, or adding allowed annotation for the method. | 122 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 122 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
|
design | DesignForExtension | Class 'ManufacturerInfoId' looks like designed for extension (can be subclassed), but the method 'getManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfoId' final or making the method 'getManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
design | DesignForExtension | Class 'ManufacturerInfoId' looks like designed for extension (can be subclassed), but the method 'setManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfoId' final or making the method 'setManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
misc | FinalParameters | Parameter manufacturer should be final. | 20 |
|
coding | HiddenField | 'manufacturer' hides a field. | 20 |
|
design | DesignForExtension | Class 'ManufacturerInfoId' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfoId' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
design | DesignForExtension | Class 'ManufacturerInfoId' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfoId' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
misc | FinalParameters | Parameter language should be final. | 28 |
|
coding | HiddenField | 'language' hides a field. | 28 |
|
design | DesignForExtension | Class 'ManufacturerInfoId' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfoId' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
misc | FinalParameters | Parameter o should be final. | 33 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 34 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 39 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 39 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 40 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 40 |
|
design | DesignForExtension | Class 'ManufacturerInfoId' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfoId' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
coding | MagicNumber | '31' is a magic number. | 48 |
|
design | DesignForExtension | Class 'ManufacturerInfoId' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfoId' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 54 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 55 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 56 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | UnusedImports | Unused import - javax.persistence.FetchType. | 10 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 28 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 28 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 33 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 33 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 36 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 36 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 41 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 45 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
coding | MagicNumber | '15' is a magic number. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
coding | MagicNumber | '4' is a magic number. | 45 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 49 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 49 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 55 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 57 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 57 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 60 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 60 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
coding | MagicNumber | '5' is a magic number. | 60 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 62 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 63 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 65 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 66 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 66 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 66 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 68 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 69 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 70 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 70 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 71 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 73 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 74 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 74 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 74 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 77 |
|
whitespace | ParenPad | '(' is followed by whitespace. | 78 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 83 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 84 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 88 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 88 |
|
misc | FinalParameters | Parameter id should be final. | 88 |
|
coding | HiddenField | 'id' hides a field. | 88 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getQuantity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getQuantity' static/final/abstract/empty, or adding allowed annotation for the method. | 92 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 92 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setQuantity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setQuantity' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 96 |
|
misc | FinalParameters | Parameter quantity should be final. | 96 |
|
coding | HiddenField | 'quantity' hides a field. | 96 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getModel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getModel' static/final/abstract/empty, or adding allowed annotation for the method. | 100 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setModel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setModel' static/final/abstract/empty, or adding allowed annotation for the method. | 104 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 104 |
|
misc | FinalParameters | Parameter model should be final. | 104 |
|
coding | HiddenField | 'model' hides a field. | 104 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getImage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getImage' static/final/abstract/empty, or adding allowed annotation for the method. | 108 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 108 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setImage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setImage' static/final/abstract/empty, or adding allowed annotation for the method. | 112 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 112 |
|
misc | FinalParameters | Parameter image should be final. | 112 |
|
coding | HiddenField | 'image' hides a field. | 112 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 116 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 116 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 120 |
|
misc | FinalParameters | Parameter price should be final. | 120 |
|
coding | HiddenField | 'price' hides a field. | 120 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 124 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 124 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 128 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 128 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 128 |
|
coding | HiddenField | 'dateAdded' hides a field. | 128 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 132 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 132 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 136 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 136 |
|
misc | FinalParameters | Parameter lastModified should be final. | 136 |
|
coding | HiddenField | 'lastModified' hides a field. | 136 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getDateAvailable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getDateAvailable' static/final/abstract/empty, or adding allowed annotation for the method. | 140 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 140 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setDateAvailable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setDateAvailable' static/final/abstract/empty, or adding allowed annotation for the method. | 144 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 144 |
|
misc | FinalParameters | Parameter dateAvailable should be final. | 144 |
|
coding | HiddenField | 'dateAvailable' hides a field. | 144 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getWeight' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getWeight' static/final/abstract/empty, or adding allowed annotation for the method. | 148 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 148 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setWeight' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setWeight' static/final/abstract/empty, or adding allowed annotation for the method. | 152 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 152 |
|
misc | FinalParameters | Parameter weight should be final. | 152 |
|
coding | HiddenField | 'weight' hides a field. | 152 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'isStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'isStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 156 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 156 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 160 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 160 |
|
misc | FinalParameters | Parameter status should be final. | 160 |
|
coding | HiddenField | 'status' hides a field. | 160 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getTaxClassId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getTaxClassId' static/final/abstract/empty, or adding allowed annotation for the method. | 164 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 164 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setTaxClassId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setTaxClassId' static/final/abstract/empty, or adding allowed annotation for the method. | 168 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 168 |
|
misc | FinalParameters | Parameter taxClassId should be final. | 168 |
|
coding | HiddenField | 'taxClassId' hides a field. | 168 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 172 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 172 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 176 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 176 |
|
misc | FinalParameters | Parameter manufacturer should be final. | 176 |
|
coding | HiddenField | 'manufacturer' hides a field. | 176 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getOrdered' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getOrdered' static/final/abstract/empty, or adding allowed annotation for the method. | 180 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 180 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setOrdered' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setOrdered' static/final/abstract/empty, or adding allowed annotation for the method. | 184 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 184 |
|
misc | FinalParameters | Parameter ordered should be final. | 184 |
|
coding | HiddenField | 'ordered' hides a field. | 184 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 187 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'getCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'getCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 188 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 188 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'setCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'setCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 192 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 192 |
|
misc | FinalParameters | Parameter categories should be final. | 192 |
|
coding | HiddenField | 'categories' hides a field. | 192 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 196 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 201 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 203 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 205 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 207 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 209 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 210 |
|
coding | MagicNumber | '32' is a magic number. | 211 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 212 |
|
coding | MagicNumber | '1231' is a magic number. | 214 |
|
coding | MagicNumber | '1237' is a magic number. | 214 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 216 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 217 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 221 |
|
misc | FinalParameters | Parameter obj should be final. | 222 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 223 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 225 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 227 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 231 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 233 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 236 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 238 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 241 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 243 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 246 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 248 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 251 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 253 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 256 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 258 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 261 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 263 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 265 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 268 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 270 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 272 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 274 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 277 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 279 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 282 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 284 |
|
design | DesignForExtension | Class 'Product' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Product' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 289 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 291 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 292 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 293 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 294 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 295 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 296 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 297 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 298 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 299 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 300 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 301 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 302 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 303 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 304 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 305 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 14 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 14 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 20 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 24 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 28 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 28 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
coding | MagicNumber | '15' is a magic number. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
coding | MagicNumber | '4' is a magic number. | 35 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 38 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
misc | FinalParameters | Parameter id should be final. | 45 |
|
coding | HiddenField | 'id' hides a field. | 45 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'getProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'getProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'setProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'setProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 53 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 53 |
|
misc | FinalParameters | Parameter product should be final. | 53 |
|
coding | HiddenField | 'product' hides a field. | 53 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'getOptionId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'getOptionId' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'setOptionId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'setOptionId' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
misc | FinalParameters | Parameter optionId should be final. | 61 |
|
coding | HiddenField | 'optionId' hides a field. | 61 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'getValueId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'getValueId' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'setValueId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'setValueId' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 69 |
|
misc | FinalParameters | Parameter valueId should be final. | 69 |
|
coding | HiddenField | 'valueId' hides a field. | 69 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'getPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'getPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 73 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 73 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'setPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'setPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 77 |
|
misc | FinalParameters | Parameter price should be final. | 77 |
|
coding | HiddenField | 'price' hides a field. | 77 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'getPricePrefix' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'getPricePrefix' static/final/abstract/empty, or adding allowed annotation for the method. | 81 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 81 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'setPricePrefix' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'setPricePrefix' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 85 |
|
misc | FinalParameters | Parameter pricePrefix should be final. | 85 |
|
coding | HiddenField | 'pricePrefix' hides a field. | 85 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 89 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 93 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
|
coding | MagicNumber | '32' is a magic number. | 101 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 102 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 104 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 105 |
|
coding | MagicNumber | '32' is a magic number. | 106 |
|
design | DesignForExtension | Class 'ProductAttribute' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttribute' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
|
misc | FinalParameters | Parameter obj should be final. | 111 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 112 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 114 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 116 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 120 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 122 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 124 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 127 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 129 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 132 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 134 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 137 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 139 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 141 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 145 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 14 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 14 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 17 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 17 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 25 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 25 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 28 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 36 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 37 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'getProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'getProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'setProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'setProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
misc | FinalParameters | Parameter product should be final. | 44 |
|
coding | HiddenField | 'product' hides a field. | 44 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
|
misc | FinalParameters | Parameter language should be final. | 52 |
|
coding | HiddenField | 'language' hides a field. | 52 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'getViewed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'getViewed' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'setViewed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'setViewed' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
|
misc | FinalParameters | Parameter viewed should be final. | 60 |
|
coding | HiddenField | 'viewed' hides a field. | 60 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'getDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'getDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 64 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'setDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'setDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
|
misc | FinalParameters | Parameter description should be final. | 68 |
|
coding | HiddenField | 'description' hides a field. | 68 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'getProductsUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'getProductsUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'setProductsUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'setProductsUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
|
misc | FinalParameters | Parameter products_url should be final. | 76 |
|
naming | ParameterName | Name 'products_url' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 76 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 80 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 80 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 84 |
|
misc | FinalParameters | Parameter name should be final. | 84 |
|
coding | HiddenField | 'name' hides a field. | 84 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 92 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
|
misc | FinalParameters | Parameter o should be final. | 97 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 98 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 99 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 103 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 103 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 104 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 104 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 109 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 112 |
|
coding | MagicNumber | '31' is a magic number. | 112 |
|
design | DesignForExtension | Class 'ProductDescription' looks like designed for extension (can be subclassed), but the method 'incViewed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescription' final or making the method 'incViewed' static/final/abstract/empty, or adding allowed annotation for the method. | 116 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 116 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 7 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 7 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
|
design | DesignForExtension | Class 'ProductDescriptionId' looks like designed for extension (can be subclassed), but the method 'getProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionId' final or making the method 'getProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
design | DesignForExtension | Class 'ProductDescriptionId' looks like designed for extension (can be subclassed), but the method 'setProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionId' final or making the method 'setProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
misc | FinalParameters | Parameter product should be final. | 19 |
|
coding | HiddenField | 'product' hides a field. | 19 |
|
design | DesignForExtension | Class 'ProductDescriptionId' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionId' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
design | DesignForExtension | Class 'ProductDescriptionId' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionId' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 27 |
|
misc | FinalParameters | Parameter language should be final. | 27 |
|
coding | HiddenField | 'language' hides a field. | 27 |
|
design | DesignForExtension | Class 'ProductDescriptionId' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionId' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 33 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 36 |
|
design | DesignForExtension | Class 'ProductDescriptionId' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionId' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 43 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 44 |
|
design | DesignForExtension | Class 'ProductDescriptionId' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionId' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
misc | FinalParameters | Parameter obj should be final. | 49 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 50 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 52 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 54 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 58 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 60 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 63 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 65 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 5 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
coding | MagicNumber | '64' is a magic number. | 30 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 33 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 36 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 36 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 43 |
|
misc | FinalParameters | Parameter id should be final. | 43 |
|
coding | HiddenField | 'id' hides a field. | 43 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'getProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'getProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 47 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'setProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'setProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 51 |
|
misc | FinalParameters | Parameter product should be final. | 51 |
|
coding | HiddenField | 'product' hides a field. | 51 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'getImage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'getImage' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'setImage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'setImage' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 59 |
|
misc | FinalParameters | Parameter image should be final. | 59 |
|
coding | HiddenField | 'image' hides a field. | 59 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'getHtmlContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'getHtmlContent' static/final/abstract/empty, or adding allowed annotation for the method. | 63 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'setHtmlContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'setHtmlContent' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 67 |
|
misc | FinalParameters | Parameter htmlContent should be final. | 67 |
|
coding | HiddenField | 'htmlContent' hides a field. | 67 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'getSequence' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'getSequence' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 71 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'setSequence' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'setSequence' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 75 |
|
misc | FinalParameters | Parameter sortOrder should be final. | 75 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
misc | FinalParameters | Parameter o should be final. | 80 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 81 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 82 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 86 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 87 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 87 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 89 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 89 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 90 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 90 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
coding | MagicNumber | '31' is a magic number. | 98 |
|
coding | MagicNumber | '31' is a magic number. | 99 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 100 |
|
coding | MagicNumber | '31' is a magic number. | 100 |
|
coding | MagicNumber | '31' is a magic number. | 101 |
|
coding | MagicNumber | '32' is a magic number. | 101 |
|
design | DesignForExtension | Class 'ProductImage' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductImage' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 107 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 108 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 109 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 110 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 111 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 112 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 15 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 15 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 18 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 18 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 22 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 28 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 28 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 35 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
misc | FinalParameters | Parameter id should be final. | 39 |
|
coding | HiddenField | 'id' hides a field. | 39 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 43 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 47 |
|
misc | FinalParameters | Parameter language should be final. | 47 |
|
coding | HiddenField | 'language' hides a field. | 47 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 51 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
|
misc | FinalParameters | Parameter name should be final. | 55 |
|
coding | HiddenField | 'name' hides a field. | 55 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 61 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 71 |
|
design | DesignForExtension | Class 'ProductOption' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOption' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
misc | FinalParameters | Parameter obj should be final. | 76 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 77 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 79 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 81 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 85 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 87 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 90 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 92 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 96 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 5 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 7 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 7 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
design | DesignForExtension | Class 'ProductOptionId' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionId' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
design | DesignForExtension | Class 'ProductOptionId' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionId' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
misc | FinalParameters | Parameter id should be final. | 18 |
|
coding | HiddenField | 'id' hides a field. | 18 |
|
design | DesignForExtension | Class 'ProductOptionId' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionId' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
design | DesignForExtension | Class 'ProductOptionId' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionId' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
misc | FinalParameters | Parameter language should be final. | 26 |
|
coding | HiddenField | 'language' hides a field. | 26 |
|
design | DesignForExtension | Class 'ProductOptionId' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionId' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 32 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 34 |
|
design | DesignForExtension | Class 'ProductOptionId' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionId' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 41 |
|
design | DesignForExtension | Class 'ProductOptionId' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionId' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
misc | FinalParameters | Parameter obj should be final. | 46 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 47 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 49 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 51 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 55 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 57 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 60 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 62 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 20 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 23 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 25 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 29 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 29 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 33 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 33 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 33 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
misc | FinalParameters | Parameter id should be final. | 40 |
|
coding | HiddenField | 'id' hides a field. | 40 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
|
misc | FinalParameters | Parameter language should be final. | 48 |
|
coding | HiddenField | 'language' hides a field. | 48 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
|
misc | FinalParameters | Parameter name should be final. | 56 |
|
coding | HiddenField | 'name' hides a field. | 56 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 65 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 73 |
|
design | DesignForExtension | Class 'ProductOptionValue' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
misc | FinalParameters | Parameter obj should be final. | 78 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 79 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 81 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 83 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 87 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 89 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 92 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 94 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 13 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 13 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 18 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 18 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 20 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 26 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
|
misc | FinalParameters | Parameter id should be final. | 33 |
|
coding | HiddenField | 'id' hides a field. | 33 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'getOptionId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'getOptionId' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'setOptionId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'setOptionId' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
|
misc | FinalParameters | Parameter optionId should be final. | 41 |
|
coding | HiddenField | 'optionId' hides a field. | 41 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'getValueId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'getValueId' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'setValueId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'setValueId' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
misc | FinalParameters | Parameter valueId should be final. | 49 |
|
coding | HiddenField | 'valueId' hides a field. | 49 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 55 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
coding | MagicNumber | '32' is a magic number. | 64 |
|
coding | MagicNumber | '32' is a magic number. | 65 |
|
design | DesignForExtension | Class 'ProductOptionValue2ProductOption' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValue2ProductOption' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
misc | FinalParameters | Parameter obj should be final. | 70 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 71 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 73 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 75 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 77 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 79 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 81 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 83 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 85 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 89 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 90 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 7 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
design | DesignForExtension | Class 'ProductOptionValueId' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValueId' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 10 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
|
design | DesignForExtension | Class 'ProductOptionValueId' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValueId' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 13 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
|
misc | FinalParameters | Parameter id should be final. | 13 |
|
coding | HiddenField | 'id' hides a field. | 13 |
|
design | DesignForExtension | Class 'ProductOptionValueId' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValueId' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
design | DesignForExtension | Class 'ProductOptionValueId' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValueId' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
misc | FinalParameters | Parameter language should be final. | 19 |
|
coding | HiddenField | 'language' hides a field. | 19 |
|
design | DesignForExtension | Class 'ProductOptionValueId' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValueId' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 24 |
|
design | DesignForExtension | Class 'ProductOptionValueId' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValueId' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 33 |
|
design | DesignForExtension | Class 'ProductOptionValueId' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionValueId' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
misc | FinalParameters | Parameter obj should be final. | 37 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 38 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 40 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 42 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 46 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 48 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 51 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 53 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 57 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 58 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 6 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 28 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 28 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 49 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 49 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 52 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 55 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'increaseReviewsRead' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'increaseReviewsRead' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
|
misc | FinalParameters | Parameter id should be final. | 66 |
|
coding | HiddenField | 'id' hides a field. | 66 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 74 |
|
misc | FinalParameters | Parameter product should be final. | 74 |
|
coding | HiddenField | 'product' hides a field. | 74 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getCustomersId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getCustomersId' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 78 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setCustomersId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setCustomersId' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 82 |
|
misc | FinalParameters | Parameter customersId should be final. | 82 |
|
coding | HiddenField | 'customersId' hides a field. | 82 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getCustomersName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getCustomersName' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 86 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setCustomersName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setCustomersName' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 90 |
|
misc | FinalParameters | Parameter customersName should be final. | 90 |
|
coding | HiddenField | 'customersName' hides a field. | 90 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getRating' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getRating' static/final/abstract/empty, or adding allowed annotation for the method. | 94 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 94 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setRating' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setRating' static/final/abstract/empty, or adding allowed annotation for the method. | 98 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 98 |
|
misc | FinalParameters | Parameter rating should be final. | 98 |
|
coding | HiddenField | 'rating' hides a field. | 98 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 102 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 102 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 106 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 106 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 106 |
|
coding | HiddenField | 'dateAdded' hides a field. | 106 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 110 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 114 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 114 |
|
misc | FinalParameters | Parameter lastModified should be final. | 114 |
|
coding | HiddenField | 'lastModified' hides a field. | 114 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 118 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 118 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 122 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 122 |
|
misc | FinalParameters | Parameter status should be final. | 122 |
|
coding | HiddenField | 'status' hides a field. | 122 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'getReviewsRead' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'getReviewsRead' static/final/abstract/empty, or adding allowed annotation for the method. | 126 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 126 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'setReviewsRead' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'setReviewsRead' static/final/abstract/empty, or adding allowed annotation for the method. | 130 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 130 |
|
misc | FinalParameters | Parameter reviewsRead should be final. | 130 |
|
coding | HiddenField | 'reviewsRead' hides a field. | 130 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 134 |
|
misc | FinalParameters | Parameter o should be final. | 135 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 136 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 137 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 141 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 142 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 143 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 143 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 144 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 144 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 146 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 146 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 147 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 147 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 148 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 148 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 150 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 150 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 151 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 151 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 156 |
|
coding | MagicNumber | '31' is a magic number. | 159 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 160 |
|
coding | MagicNumber | '31' is a magic number. | 160 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 161 |
|
coding | MagicNumber | '31' is a magic number. | 161 |
|
coding | MagicNumber | '31' is a magic number. | 162 |
|
coding | MagicNumber | '31' is a magic number. | 163 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 164 |
|
coding | MagicNumber | '31' is a magic number. | 164 |
|
coding | MagicNumber | '31' is a magic number. | 165 |
|
coding | MagicNumber | '31' is a magic number. | 166 |
|
design | DesignForExtension | Class 'Review' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Review' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 170 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 172 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 173 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 174 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 175 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 176 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 177 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 178 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 179 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 180 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 181 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 5 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 34 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'getReviewTextShort' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'getReviewTextShort' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 37 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 39 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'getReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'getReview' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'setReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'setReview' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
misc | FinalParameters | Parameter review should be final. | 49 |
|
coding | HiddenField | 'review' hides a field. | 49 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 53 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 53 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
|
misc | FinalParameters | Parameter language should be final. | 57 |
|
coding | HiddenField | 'language' hides a field. | 57 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'getReviewText' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'getReviewText' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'setReviewText' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'setReviewText' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
|
misc | FinalParameters | Parameter reviewText should be final. | 65 |
|
coding | HiddenField | 'reviewText' hides a field. | 65 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
misc | FinalParameters | Parameter o should be final. | 70 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 71 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 76 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 77 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 77 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 78 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 78 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
coding | MagicNumber | '31' is a magic number. | 86 |
|
coding | MagicNumber | '31' is a magic number. | 87 |
|
design | DesignForExtension | Class 'ReviewDescription' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescription' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 93 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 94 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 95 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 96 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
design | DesignForExtension | Class 'ReviewDescriptionId' looks like designed for extension (can be subclassed), but the method 'getReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionId' final or making the method 'getReview' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
design | DesignForExtension | Class 'ReviewDescriptionId' looks like designed for extension (can be subclassed), but the method 'setReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionId' final or making the method 'setReview' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
misc | FinalParameters | Parameter review should be final. | 18 |
|
coding | HiddenField | 'review' hides a field. | 18 |
|
design | DesignForExtension | Class 'ReviewDescriptionId' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionId' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
design | DesignForExtension | Class 'ReviewDescriptionId' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionId' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
misc | FinalParameters | Parameter language should be final. | 26 |
|
coding | HiddenField | 'language' hides a field. | 26 |
|
design | DesignForExtension | Class 'ReviewDescriptionId' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionId' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
misc | FinalParameters | Parameter o should be final. | 31 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 32 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 37 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 38 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 38 |
|
design | DesignForExtension | Class 'ReviewDescriptionId' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionId' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
coding | MagicNumber | '31' is a magic number. | 46 |
|
design | DesignForExtension | Class 'ReviewDescriptionId' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionId' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 52 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 53 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 54 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 6 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 8 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 9 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 10 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 13 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 14 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 15 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 16 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 18 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 19 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
coding | MagicNumber | '15' is a magic number. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
coding | MagicNumber | '4' is a magic number. | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 46 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 46 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 50 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 54 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 54 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
misc | FinalParameters | Parameter id should be final. | 61 |
|
coding | HiddenField | 'id' hides a field. | 61 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'getProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'getProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'setProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'setProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 69 |
|
misc | FinalParameters | Parameter product should be final. | 69 |
|
coding | HiddenField | 'product' hides a field. | 69 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'getNewPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'getNewPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 73 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 73 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'setNewPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'setNewPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 77 |
|
misc | FinalParameters | Parameter newPrice should be final. | 77 |
|
coding | HiddenField | 'newPrice' hides a field. | 77 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'getAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'getAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 81 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 81 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'setAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'setAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 85 |
|
misc | FinalParameters | Parameter added should be final. | 85 |
|
coding | HiddenField | 'added' hides a field. | 85 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 89 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 89 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 93 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 93 |
|
misc | FinalParameters | Parameter lastModified should be final. | 93 |
|
coding | HiddenField | 'lastModified' hides a field. | 93 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'getExpires' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'getExpires' static/final/abstract/empty, or adding allowed annotation for the method. | 97 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 97 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'setExpires' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'setExpires' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 101 |
|
misc | FinalParameters | Parameter expires should be final. | 101 |
|
coding | HiddenField | 'expires' hides a field. | 101 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'getStatusChanged' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'getStatusChanged' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 105 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'setStatusChanged' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'setStatusChanged' static/final/abstract/empty, or adding allowed annotation for the method. | 109 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 109 |
|
misc | FinalParameters | Parameter statusChanged should be final. | 109 |
|
coding | HiddenField | 'statusChanged' hides a field. | 109 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'getStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'getStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 113 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 114 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 114 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'setStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'setStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 117 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 117 |
|
misc | FinalParameters | Parameter status should be final. | 117 |
|
coding | HiddenField | 'status' hides a field. | 117 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 118 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 118 |
|
whitespace | WhitespaceAround | '?' is not followed by whitespace. | 118 |
|
whitespace | WhitespaceAround | '?' is not preceded with whitespace. | 118 |
|
whitespace | WhitespaceAround | ':' is not followed by whitespace. | 118 |
|
whitespace | WhitespaceAround | ':' is not preceded with whitespace. | 118 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 121 |
|
misc | FinalParameters | Parameter o should be final. | 122 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 123 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 124 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 129 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 130 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 131 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 131 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 132 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 132 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 134 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 134 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 135 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 135 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 136 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 136 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 142 |
|
coding | MagicNumber | '31' is a magic number. | 145 |
|
coding | MagicNumber | '31' is a magic number. | 146 |
|
coding | MagicNumber | '31' is a magic number. | 147 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 148 |
|
coding | MagicNumber | '31' is a magic number. | 148 |
|
coding | MagicNumber | '31' is a magic number. | 149 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 150 |
|
coding | MagicNumber | '31' is a magic number. | 150 |
|
coding | MagicNumber | '31' is a magic number. | 151 |
|
design | DesignForExtension | Class 'Special' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Special' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 155 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 157 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 158 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 159 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 160 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 161 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 162 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 163 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 164 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 165 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 35 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'getSearchKeywords' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'getSearchKeywords' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'setSearchKeywords' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'setSearchKeywords' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 43 |
|
misc | FinalParameters | Parameter searchKeywords should be final. | 43 |
|
coding | HiddenField | 'searchKeywords' hides a field. | 43 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'getCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'getCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 47 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'setCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'setCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 51 |
|
misc | FinalParameters | Parameter category should be final. | 51 |
|
coding | HiddenField | 'category' hides a field. | 51 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'getIncludeSubcategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'getIncludeSubcategories' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'setIncludeSubcategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'setIncludeSubcategories' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 59 |
|
misc | FinalParameters | Parameter includeSubcategories should be final. | 59 |
|
coding | HiddenField | 'includeSubcategories' hides a field. | 59 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'getManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'getManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 63 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'setManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'setManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 67 |
|
misc | FinalParameters | Parameter manufacturer should be final. | 67 |
|
coding | HiddenField | 'manufacturer' hides a field. | 67 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'getPriceFrom' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'getPriceFrom' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 71 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'setPriceFrom' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'setPriceFrom' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 75 |
|
misc | FinalParameters | Parameter priceFrom should be final. | 75 |
|
coding | HiddenField | 'priceFrom' hides a field. | 75 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'getPriceTo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'getPriceTo' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'setPriceTo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'setPriceTo' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
|
misc | FinalParameters | Parameter priceTo should be final. | 83 |
|
coding | HiddenField | 'priceTo' hides a field. | 83 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'getDateFrom' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'getDateFrom' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 87 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'setDateFrom' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'setDateFrom' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 91 |
|
misc | FinalParameters | Parameter dateFrom should be final. | 91 |
|
coding | HiddenField | 'dateFrom' hides a field. | 91 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'getDateTo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'getDateTo' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'setDateTo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'setDateTo' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
misc | FinalParameters | Parameter dateTo should be final. | 99 |
|
coding | HiddenField | 'dateTo' hides a field. | 99 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
misc | FinalParameters | Parameter o should be final. | 104 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 105 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 106 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 110 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 110 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 111 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 112 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 135). | 113 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 115 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 115 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 116 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 117 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 117 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 118 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 118 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 124 |
|
coding | MagicNumber | '31' is a magic number. | 127 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 128 |
|
coding | MagicNumber | '31' is a magic number. | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 129 |
|
coding | MagicNumber | '31' is a magic number. | 129 |
|
coding | MagicNumber | '31' is a magic number. | 130 |
|
coding | MagicNumber | '31' is a magic number. | 131 |
|
coding | MagicNumber | '31' is a magic number. | 132 |
|
coding | MagicNumber | '31' is a magic number. | 133 |
|
design | DesignForExtension | Class 'AdvancedSearchBean' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AdvancedSearchBean' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 137 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 139 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 140 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 141 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 142 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 143 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 144 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 145 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 146 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 147 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 15 |
|
design | DesignForExtension | Class 'CategoriesBean' looks like designed for extension (can be subclassed), but the method 'getCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoriesBean' final or making the method 'getCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
design | DesignForExtension | Class 'CategoriesBean' looks like designed for extension (can be subclassed), but the method 'setCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoriesBean' final or making the method 'setCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
misc | FinalParameters | Parameter categories should be final. | 21 |
|
coding | HiddenField | 'categories' hides a field. | 21 |
|
design | DesignForExtension | Class 'CategoriesBean' looks like designed for extension (can be subclassed), but the method 'getCategory2level' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoriesBean' final or making the method 'getCategory2level' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 29 |
|
design | DesignForExtension | Class 'CategoriesBean' looks like designed for extension (can be subclassed), but the method 'setCategory2level' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoriesBean' final or making the method 'setCategory2level' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
misc | FinalParameters | Parameter category2level should be final. | 29 |
|
coding | HiddenField | 'category2level' hides a field. | 29 |
|
design | DesignForExtension | Class 'CategoriesBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoriesBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
|
misc | FinalParameters | Parameter o should be final. | 34 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 35 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 40 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 111). | 41 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 41 |
|
design | DesignForExtension | Class 'CategoriesBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoriesBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 50 |
|
coding | MagicNumber | '31' is a magic number. | 50 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 14 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 15 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'getThisLevelCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'getThisLevelCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 18 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 19 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 19 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 22 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 23 |
|
sizes | LineLength | Line is longer than 80 characters (found 150). | 24 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 24 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 24 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'getChildren' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'getChildren' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 116). | 35 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 46 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'getCategoriesMenuList' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'getCategoriesMenuList' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 61 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'setCategoriesMenuList' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'setCategoriesMenuList' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
misc | FinalParameters | Parameter categoriesMenuList should be final. | 61 |
|
coding | HiddenField | 'categoriesMenuList' hides a field. | 61 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'getThisCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'getThisCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'setThisCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'setThisCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 69 |
|
misc | FinalParameters | Parameter thisCategory should be final. | 69 |
|
coding | HiddenField | 'thisCategory' hides a field. | 69 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'getThisCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'getThisCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 73 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 73 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'setThisCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'setThisCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 77 |
|
misc | FinalParameters | Parameter thisCategoryId should be final. | 77 |
|
coding | HiddenField | 'thisCategoryId' hides a field. | 77 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'getCategoryIdToNumberOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'getCategoryIdToNumberOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 81 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 81 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 85 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'setCategoryIdToNumberOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'setCategoryIdToNumberOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 85 |
|
misc | FinalParameters | Parameter categoryIdToNumberOfProducts should be final. | 85 |
|
coding | HiddenField | 'categoryIdToNumberOfProducts' hides a field. | 85 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 86 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'getHasChildrenMap' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'getHasChildrenMap' static/final/abstract/empty, or adding allowed annotation for the method. | 89 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 89 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'setHasChildrenMap' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'setHasChildrenMap' static/final/abstract/empty, or adding allowed annotation for the method. | 93 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 93 |
|
misc | FinalParameters | Parameter hasChildrenMap should be final. | 93 |
|
coding | HiddenField | 'hasChildrenMap' hides a field. | 93 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'getBreadcrumb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'getBreadcrumb' static/final/abstract/empty, or adding allowed annotation for the method. | 97 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 97 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'setBreadcrumb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'setBreadcrumb' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 101 |
|
misc | FinalParameters | Parameter breadcrumb should be final. | 101 |
|
coding | HiddenField | 'breadcrumb' hides a field. | 101 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
|
misc | FinalParameters | Parameter o should be final. | 106 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 107 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 108 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 113 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 135). | 114 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 114 |
|
sizes | LineLength | Line is longer than 80 characters (found 175). | 116 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 119). | 118 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 118 |
|
sizes | LineLength | Line is longer than 80 characters (found 125). | 120 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 120 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 125 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 127 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 128 |
|
coding | MagicNumber | '31' is a magic number. | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 129 |
|
coding | MagicNumber | '31' is a magic number. | 129 |
|
coding | MagicNumber | '32' is a magic number. | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 130 |
|
coding | MagicNumber | '31' is a magic number. | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 131 |
|
coding | MagicNumber | '31' is a magic number. | 131 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 132 |
|
coding | MagicNumber | '31' is a magic number. | 132 |
|
design | DesignForExtension | Class 'CategoryTree' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTree' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 136 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 138 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 139 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 140 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 141 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 142 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 142 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 143 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 144 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 6 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'getCategoryDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'getCategoryDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 14 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'setCategoryDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'setCategoryDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
misc | FinalParameters | Parameter categoryDescription should be final. | 14 |
|
coding | HiddenField | 'categoryDescription' hides a field. | 14 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'getLevel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'getLevel' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'setLevel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'setLevel' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
misc | FinalParameters | Parameter level should be final. | 20 |
|
coding | HiddenField | 'level' hides a field. | 20 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'getNumberOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'getNumberOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'setNumberOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'setNumberOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
misc | FinalParameters | Parameter numberOfProducts should be final. | 26 |
|
coding | HiddenField | 'numberOfProducts' hides a field. | 26 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'isHasChildCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'isHasChildCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'setHasChildCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'setHasChildCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
|
misc | FinalParameters | Parameter hasChildCategories should be final. | 32 |
|
coding | HiddenField | 'hasChildCategories' hides a field. | 32 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'getNumberOfChildCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'getNumberOfChildCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'setNumberOfChildCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'setNumberOfChildCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
misc | FinalParameters | Parameter numberOfChildCategories should be final. | 40 |
|
coding | HiddenField | 'numberOfChildCategories' hides a field. | 40 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
misc | FinalParameters | Parameter o should be final. | 45 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 46 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 47 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 51 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 53 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 53 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 139). | 55 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 55 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 63 |
|
coding | MagicNumber | '31' is a magic number. | 64 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 65 |
|
coding | MagicNumber | '31' is a magic number. | 65 |
|
coding | MagicNumber | '32' is a magic number. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 66 |
|
coding | MagicNumber | '31' is a magic number. | 66 |
|
coding | MagicNumber | '32' is a magic number. | 66 |
|
coding | MagicNumber | '31' is a magic number. | 67 |
|
design | DesignForExtension | Class 'CategoryTreeNode' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryTreeNode' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 73 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 74 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 75 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 77 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 77 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 78 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 8 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 11 |
|
design | DesignForExtension | Class 'Manufacturers' looks like designed for extension (can be subclassed), but the method 'getManufacturers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturers' final or making the method 'getManufacturers' static/final/abstract/empty, or adding allowed annotation for the method. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
design | DesignForExtension | Class 'Manufacturers' looks like designed for extension (can be subclassed), but the method 'setManufacturers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturers' final or making the method 'setManufacturers' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
misc | FinalParameters | Parameter manufacturers should be final. | 15 |
|
coding | HiddenField | 'manufacturers' hides a field. | 15 |
|
design | DesignForExtension | Class 'Manufacturers' looks like designed for extension (can be subclassed), but the method 'getManufacturerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturers' final or making the method 'getManufacturerId' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
design | DesignForExtension | Class 'Manufacturers' looks like designed for extension (can be subclassed), but the method 'setManufacturerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturers' final or making the method 'setManufacturerId' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 21 |
|
coding | HiddenField | 'manufacturerId' hides a field. | 21 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 24 |
|
design | DesignForExtension | Class 'Manufacturers' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Manufacturers' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 30 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 11 |
|
design | DesignForExtension | Class 'ProductAttributes' looks like designed for extension (can be subclassed), but the method 'getProductDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttributes' final or making the method 'getProductDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 15 |
|
design | DesignForExtension | Class 'ProductAttributes' looks like designed for extension (can be subclassed), but the method 'setProductDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttributes' final or making the method 'setProductDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
misc | FinalParameters | Parameter productDescription should be final. | 15 |
|
coding | HiddenField | 'productDescription' hides a field. | 15 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 18 |
|
design | DesignForExtension | Class 'ProductAttributes' looks like designed for extension (can be subclassed), but the method 'getMapProductOptionAttribute' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttributes' final or making the method 'getMapProductOptionAttribute' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
design | DesignForExtension | Class 'ProductAttributes' looks like designed for extension (can be subclassed), but the method 'setMapProductOptionAttribute' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttributes' final or making the method 'setMapProductOptionAttribute' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 22 |
|
misc | FinalParameters | Parameter mapProductOptionAttribute should be final. | 22 |
|
coding | HiddenField | 'mapProductOptionAttribute' hides a field. | 22 |
|
design | DesignForExtension | Class 'ProductAttributes' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttributes' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 35 |
|
design | DesignForExtension | Class 'ProductAttributes' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttributes' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
misc | FinalParameters | Parameter obj should be final. | 40 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 41 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 43 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 45 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 49 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 51 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 55 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 57 |
|
design | DesignForExtension | Class 'ProductAttributes' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductAttributes' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 64 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 8 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'getProductAttribute' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'getProductAttribute' static/final/abstract/empty, or adding allowed annotation for the method. | 13 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'setProductAttribute' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'setProductAttribute' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
misc | FinalParameters | Parameter productAttribute should be final. | 16 |
|
coding | HiddenField | 'productAttribute' hides a field. | 16 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'getProductOption' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'getProductOption' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'setProductOption' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'setProductOption' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
misc | FinalParameters | Parameter productOption should be final. | 22 |
|
coding | HiddenField | 'productOption' hides a field. | 22 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'getProductOptionValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'getProductOptionValue' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 28 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'setProductOptionValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'setProductOptionValue' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
misc | FinalParameters | Parameter productOptionValue should be final. | 28 |
|
coding | HiddenField | 'productOptionValue' hides a field. | 28 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'getOptionValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'getOptionValue' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'setOptionValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'setOptionValue' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
|
misc | FinalParameters | Parameter optionValue should be final. | 34 |
|
coding | HiddenField | 'optionValue' hides a field. | 34 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 42 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 45 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 47 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 50 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
misc | FinalParameters | Parameter obj should be final. | 55 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 56 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 58 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 60 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 64 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 66 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 69 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 71 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 74 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 76 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 79 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 81 |
|
design | DesignForExtension | Class 'ProductOptionAttribute' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductOptionAttribute' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 89 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 91 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 9 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'getProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'getProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'setProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'setProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
misc | FinalParameters | Parameter products should be final. | 20 |
|
coding | HiddenField | 'products' hides a field. | 20 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'getThisCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'getThisCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'setThisCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'setThisCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
misc | FinalParameters | Parameter thisCategory should be final. | 28 |
|
coding | HiddenField | 'thisCategory' hides a field. | 28 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'getChildCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'getChildCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 36 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'setChildCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'setChildCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
misc | FinalParameters | Parameter childCategories should be final. | 36 |
|
coding | HiddenField | 'childCategories' hides a field. | 36 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'getManufacturers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'getManufacturers' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'setManufacturers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'setManufacturers' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
misc | FinalParameters | Parameter manufacturers should be final. | 44 |
|
coding | HiddenField | 'manufacturers' hides a field. | 44 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'getManufacturerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'getManufacturerId' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'setManufacturerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'setManufacturerId' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 52 |
|
coding | HiddenField | 'manufacturerId' hides a field. | 52 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
misc | FinalParameters | Parameter o should be final. | 57 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 58 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 59 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 123). | 64 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 64 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 66 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 66 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 68 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 125). | 69 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 69 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 77 |
|
coding | MagicNumber | '31' is a magic number. | 77 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 78 |
|
coding | MagicNumber | '31' is a magic number. | 78 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 79 |
|
coding | MagicNumber | '31' is a magic number. | 79 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 80 |
|
coding | MagicNumber | '31' is a magic number. | 80 |
|
coding | MagicNumber | '32' is a magic number. | 80 |
|
design | DesignForExtension | Class 'ProductsByCategory' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByCategory' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 86 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 87 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 88 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 89 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 90 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 91 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
design | DesignForExtension | Class 'ProductsByManufacturer' looks like designed for extension (can be subclassed), but the method 'getProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByManufacturer' final or making the method 'getProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 13 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
|
design | DesignForExtension | Class 'ProductsByManufacturer' looks like designed for extension (can be subclassed), but the method 'setProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByManufacturer' final or making the method 'setProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
misc | FinalParameters | Parameter products should be final. | 17 |
|
coding | HiddenField | 'products' hides a field. | 17 |
|
design | DesignForExtension | Class 'ProductsByManufacturer' looks like designed for extension (can be subclassed), but the method 'getCategoriesOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByManufacturer' final or making the method 'getCategoriesOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
design | DesignForExtension | Class 'ProductsByManufacturer' looks like designed for extension (can be subclassed), but the method 'setCategoriesOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByManufacturer' final or making the method 'setCategoriesOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
|
misc | FinalParameters | Parameter categoriesOfProducts should be final. | 26 |
|
coding | HiddenField | 'categoriesOfProducts' hides a field. | 26 |
|
design | DesignForExtension | Class 'ProductsByManufacturer' looks like designed for extension (can be subclassed), but the method 'getCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByManufacturer' final or making the method 'getCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
design | DesignForExtension | Class 'ProductsByManufacturer' looks like designed for extension (can be subclassed), but the method 'setCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByManufacturer' final or making the method 'setCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
|
misc | FinalParameters | Parameter categoryId should be final. | 34 |
|
coding | HiddenField | 'categoryId' hides a field. | 34 |
|
design | DesignForExtension | Class 'ProductsByManufacturer' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductsByManufacturer' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 41 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 44 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 45 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
design | DesignForExtension | Class 'ReviewProduct' looks like designed for extension (can be subclassed), but the method 'getReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewProduct' final or making the method 'getReview' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
design | DesignForExtension | Class 'ReviewProduct' looks like designed for extension (can be subclassed), but the method 'setReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewProduct' final or making the method 'setReview' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
misc | FinalParameters | Parameter review should be final. | 18 |
|
coding | HiddenField | 'review' hides a field. | 18 |
|
design | DesignForExtension | Class 'ReviewProduct' looks like designed for extension (can be subclassed), but the method 'getProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewProduct' final or making the method 'getProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
design | DesignForExtension | Class 'ReviewProduct' looks like designed for extension (can be subclassed), but the method 'setProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewProduct' final or making the method 'setProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
misc | FinalParameters | Parameter product should be final. | 26 |
|
coding | HiddenField | 'product' hides a field. | 26 |
|
design | DesignForExtension | Class 'ReviewProduct' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewProduct' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
misc | FinalParameters | Parameter o should be final. | 31 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 32 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 37 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 38 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 38 |
|
design | DesignForExtension | Class 'ReviewProduct' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewProduct' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
coding | MagicNumber | '31' is a magic number. | 46 |
|
design | DesignForExtension | Class 'ReviewProduct' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewProduct' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 52 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 53 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 54 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'getProductName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'getProductName' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'setProductName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'setProductName' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
misc | FinalParameters | Parameter productName should be final. | 22 |
|
coding | HiddenField | 'productName' hides a field. | 22 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'getProductUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'getProductUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'setProductUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'setProductUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
misc | FinalParameters | Parameter productUrl should be final. | 30 |
|
coding | HiddenField | 'productUrl' hides a field. | 30 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'getProductImageUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'getProductImageUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'setProductImageUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'setProductImageUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
|
misc | FinalParameters | Parameter productImageUrl should be final. | 38 |
|
coding | HiddenField | 'productImageUrl' hides a field. | 38 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
|
misc | FinalParameters | Parameter o should be final. | 43 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 44 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 45 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 49 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 51 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 51 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 52 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 52 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
coding | MagicNumber | '31' is a magic number. | 60 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 61 |
|
coding | MagicNumber | '31' is a magic number. | 61 |
|
design | DesignForExtension | Class 'ShareProductBean' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ShareProductBean' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 67 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 68 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 69 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 70 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'isSpecialProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'isSpecialProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 14 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'getPercentage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'getPercentage' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
coding | MagicNumber | '100.0d' is a magic number. | 21 |
|
whitespace | WhitespaceAround | '*' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '*' is not preceded with whitespace. | 21 |
|
whitespace | WhitespaceAround | '/' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '/' is not preceded with whitespace. | 21 |
|
coding | MagicNumber | '100L' is a magic number. | 22 |
|
whitespace | WhitespaceAround | '-' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '-' is not preceded with whitespace. | 22 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'getSpecial' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'getSpecial' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'setSpecial' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'setSpecial' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
misc | FinalParameters | Parameter special should be final. | 29 |
|
coding | HiddenField | 'special' hides a field. | 29 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'getProductDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'getProductDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'setProductDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'setProductDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
|
misc | FinalParameters | Parameter productDescription should be final. | 37 |
|
coding | HiddenField | 'productDescription' hides a field. | 37 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
misc | FinalParameters | Parameter o should be final. | 42 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 43 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 127). | 48 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 48 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 50 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 50 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 58 |
|
coding | MagicNumber | '31' is a magic number. | 58 |
|
design | DesignForExtension | Class 'SpecialProduct' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialProduct' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 64 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 65 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 66 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 |
|
coding | MagicNumber | '50' is a magic number. | 18 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
coding | MagicNumber | '5' is a magic number. | 24 |
|
design | DesignForExtension | Class 'WriteReviewBean' looks like designed for extension (can be subclassed), but the method 'getReviewText' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WriteReviewBean' final or making the method 'getReviewText' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
design | DesignForExtension | Class 'WriteReviewBean' looks like designed for extension (can be subclassed), but the method 'setReviewText' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WriteReviewBean' final or making the method 'setReviewText' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
|
misc | FinalParameters | Parameter reviewText should be final. | 32 |
|
coding | HiddenField | 'reviewText' hides a field. | 32 |
|
design | DesignForExtension | Class 'WriteReviewBean' looks like designed for extension (can be subclassed), but the method 'getRating' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WriteReviewBean' final or making the method 'getRating' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
design | DesignForExtension | Class 'WriteReviewBean' looks like designed for extension (can be subclassed), but the method 'setRating' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WriteReviewBean' final or making the method 'setRating' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
misc | FinalParameters | Parameter rating should be final. | 40 |
|
coding | HiddenField | 'rating' hides a field. | 40 |
|
design | DesignForExtension | Class 'WriteReviewBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WriteReviewBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
misc | FinalParameters | Parameter o should be final. | 45 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 46 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 47 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 51 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 52 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 52 |
|
design | DesignForExtension | Class 'WriteReviewBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WriteReviewBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
coding | MagicNumber | '31' is a magic number. | 60 |
|
design | DesignForExtension | Class 'WriteReviewBean' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'WriteReviewBean' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 66 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 67 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 68 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 7 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 10 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 14 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 18 |
|
design | DesignForExtension | Class 'CategoryDescriptionRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findRootCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionRepositoryDaoImpl' final or making the method 'findRootCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
misc | FinalParameters | Parameter language should be final. | 19 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 19 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 20 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
|
design | DesignForExtension | Class 'CategoryDescriptionRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findCategoriesByParentId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionRepositoryDaoImpl' final or making the method 'findCategoriesByParentId' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 24 |
|
misc | FinalParameters | Parameter parentId should be final. | 24 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 24 |
|
misc | FinalParameters | Parameter language should be final. | 24 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 24 |
|
sizes | LineLength | Line is longer than 80 characters (found 163). | 25 |
|
design | DesignForExtension | Class 'CategoryDescriptionRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findByCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryDescriptionRepositoryDaoImpl' final or making the method 'findByCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
misc | FinalParameters | Parameter categoryId should be final. | 33 |
|
misc | FinalParameters | Parameter language should be final. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 129). | 35 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 41 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 8 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 9 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 9 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 6 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 8 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 8 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
|
design | DesignForExtension | Class 'ManufacturerInfoDaoImpl' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerInfoDaoImpl' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
misc | FinalParameters | Parameter manufacturerInfo should be final. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 9 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 9 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 9 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 10 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 10 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
|
design | DesignForExtension | Class 'ProductDescriptionDaoImpl' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionDaoImpl' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
misc | FinalParameters | Parameter productDescription should be final. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 7 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 8 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 8 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 9 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 11 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 16 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 18 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 20 |
|
design | DesignForExtension | Class 'ProductDescriptionRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findByLanguageOrderByDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionRepositoryDaoImpl' final or making the method 'findByLanguageOrderByDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 23 |
|
misc | FinalParameters | Parameter language should be final. | 23 |
|
misc | FinalParameters | Parameter limitation should be final. | 23 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 23 |
|
sizes | LineLength | Line is longer than 80 characters (found 140). | 24 |
|
design | DesignForExtension | Class 'ProductDescriptionRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findByManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionRepositoryDaoImpl' final or making the method 'findByManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
misc | FinalParameters | Parameter manufacturer should be final. | 33 |
|
misc | FinalParameters | Parameter language should be final. | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 167). | 34 |
|
design | DesignForExtension | Class 'ProductDescriptionRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findByProductIdAndLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionRepositoryDaoImpl' final or making the method 'findByProductIdAndLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
misc | FinalParameters | Parameter productId should be final. | 41 |
|
misc | FinalParameters | Parameter language should be final. | 42 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 43 |
|
design | DesignForExtension | Class 'ProductDescriptionRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findByCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionRepositoryDaoImpl' final or making the method 'findByCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
misc | FinalParameters | Parameter thisCategory should be final. | 51 |
|
misc | FinalParameters | Parameter language should be final. | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 185). | 53 |
|
design | DesignForExtension | Class 'ProductDescriptionRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findByCategoryAndManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductDescriptionRepositoryDaoImpl' final or making the method 'findByCategoryAndManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 61 |
|
misc | FinalParameters | Parameter category should be final. | 61 |
|
misc | FinalParameters | Parameter manufacturer should be final. | 61 |
|
misc | FinalParameters | Parameter language should be final. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 226). | 62 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 12 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 7 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 8 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 8 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 6 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 7 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 7 |
|
whitespace | GenericWhitespace | '>' is followed by an illegal character. | 7 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 7 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 8 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 8 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 145). | 14 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
|
design | DesignForExtension | Class 'ProductRepositoryDaoImpl' looks like designed for extension (can be subclassed), but the method 'findByCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductRepositoryDaoImpl' final or making the method 'findByCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
misc | FinalParameters | Parameter categoryId should be final. | 21 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 23 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 24 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 29 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 30 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
|
design | DesignForExtension | Class 'ReviewDescriptionDaoImpl' looks like designed for extension (can be subclassed), but the method 'create' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionDaoImpl' final or making the method 'create' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
misc | FinalParameters | Parameter reviewDescription should be final. | 23 |
|
design | DesignForExtension | Class 'ReviewDescriptionDaoImpl' looks like designed for extension (can be subclassed), but the method 'findReviewsForProductAndLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionDaoImpl' final or making the method 'findReviewsForProductAndLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 29 |
|
misc | FinalParameters | Parameter product should be final. | 29 |
|
misc | FinalParameters | Parameter language should be final. | 29 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 31 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 34 |
|
design | DesignForExtension | Class 'ReviewDescriptionDaoImpl' looks like designed for extension (can be subclassed), but the method 'findReviewsForReviewIdAndLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewDescriptionDaoImpl' final or making the method 'findReviewsForReviewIdAndLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 39 |
|
misc | FinalParameters | Parameter reviewId should be final. | 39 |
|
misc | FinalParameters | Parameter language should be final. | 39 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 41 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 44 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 25 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.entities.*. | 5 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.model.*. | 6 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.repositories.*. | 7 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.*. | 11 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
design | DesignForExtension | Class 'CategoryServiceImpl' looks like designed for extension (can be subclassed), but the method 'getAllCategories' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryServiceImpl' final or making the method 'getAllCategories' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
misc | FinalParameters | Parameter language should be final. | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 42 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 44 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 45 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
misc | FinalParameters | Parameter parent should be final. | 56 |
|
misc | FinalParameters | Parameter level should be final. | 57 |
|
misc | FinalParameters | Parameter categories should be final. | 58 |
|
misc | FinalParameters | Parameter category2level should be final. | 59 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 59 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 125). | 61 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 62 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 62 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 64 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 65 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 65 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 65 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 65 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 65 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 65 |
|
design | DesignForExtension | Class 'CategoryServiceImpl' looks like designed for extension (can be subclassed), but the method 'findCategoryById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryServiceImpl' final or making the method 'findCategoryById' static/final/abstract/empty, or adding allowed annotation for the method. | 69 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 70 |
|
misc | FinalParameters | Parameter categoryId should be final. | 70 |
|
misc | FinalParameters | Parameter language should be final. | 70 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 136). | 74 |
|
whitespace | WhitespaceAfter | 'while' is not followed by whitespace. | 79 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 79 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 79 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 79 |
|
sizes | LineLength | Line is longer than 80 characters (found 127). | 80 |
|
design | DesignForExtension | Class 'CategoryServiceImpl' looks like designed for extension (can be subclassed), but the method 'getCategoriesTree' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryServiceImpl' final or making the method 'getCategoriesTree' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
misc | FinalParameters | Parameter categoryId should be final. | 88 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 88 |
|
misc | FinalParameters | Parameter language should be final. | 88 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 88 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 92 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 94 |
|
sizes | LineLength | Line is longer than 80 characters (found 132). | 95 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 96 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 119). | 104 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 107 |
|
whitespace | WhitespaceAfter | 'while' is not followed by whitespace. | 111 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 112 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 117 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 117 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 118 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 118 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 120 |
|
whitespace | WhitespaceAfter | 'while' is not followed by whitespace. | 121 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 121 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 126 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 127 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 127 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 139 |
|
misc | FinalParameters | Parameter stack should be final. | 139 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 139 |
|
misc | FinalParameters | Parameter level should be final. | 139 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 139 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 141 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 141 |
|
sizes | LineLength | Line is longer than 80 characters (found 188). | 143 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 144 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 144 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 149 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 149 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 150 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 150 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 151 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 151 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 151 |
|
sizes | LineLength | Line is longer than 80 characters (found 193). | 153 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 154 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 154 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 154 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 156 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 156 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 158 |
|
design | DesignForExtension | Class 'CategoryServiceImpl' looks like designed for extension (can be subclassed), but the method 'getNumberOfProductsPerCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryServiceImpl' final or making the method 'getNumberOfProductsPerCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 168 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 168 |
|
misc | FinalParameters | Parameter tree should be final. | 168 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 168 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 170 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 170 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 171 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 171 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 173 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 173 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 177 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 177 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 182 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 182 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 184 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 184 |
|
whitespace | WhitespaceAfter | 'while' is not followed by whitespace. | 186 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 186 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 186 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 186 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 187 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 190 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 198 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 198 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 199 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 199 |
|
design | DesignForExtension | Class 'CategoryServiceImpl' looks like designed for extension (can be subclassed), but the method 'getProductsByCategoryAndManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryServiceImpl' final or making the method 'getProductsByCategoryAndManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 208 |
|
misc | FinalParameters | Parameter categoryId should be final. | 210 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 210 |
|
misc | FinalParameters | Parameter language should be final. | 210 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 214 |
|
sizes | LineLength | Line is longer than 80 characters (found 147). | 216 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 216 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 216 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 216 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 216 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 217 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 217 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 220 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 226 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 226 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 227 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 227 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 232 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 235 |
|
sizes | LineLength | Line is longer than 80 characters (found 132). | 237 |
|
design | DesignForExtension | Class 'CategoryServiceImpl' looks like designed for extension (can be subclassed), but the method 'getProductsByCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CategoryServiceImpl' final or making the method 'getProductsByCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 242 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 243 |
|
misc | FinalParameters | Parameter categoryId should be final. | 243 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 243 |
|
misc | FinalParameters | Parameter language should be final. | 243 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 243 |
|
sizes | LineLength | Line is longer than 80 characters (found 120). | 247 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 247 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 247 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 248 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 248 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 251 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 257 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 257 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 258 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 258 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 263 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 266 |
|
sizes | LineLength | Line is longer than 80 characters (found 132). | 268 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
|
design | DesignForExtension | Class 'LanguageServiceImpl' looks like designed for extension (can be subclassed), but the method 'findLanguageByCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LanguageServiceImpl' final or making the method 'findLanguageByCode' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
misc | FinalParameters | Parameter code should be final. | 23 |
|
design | DesignForExtension | Class 'LanguageServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllLanguages' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LanguageServiceImpl' final or making the method 'findAllLanguages' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
|
design | DesignForExtension | Class 'LanguageServiceImpl' looks like designed for extension (can be subclassed), but the method 'findLanguageById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LanguageServiceImpl' final or making the method 'findLanguageById' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
misc | FinalParameters | Parameter languageId should be final. | 33 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
design | DesignForExtension | Class 'ManufacturerServiceImpl' looks like designed for extension (can be subclassed), but the method 'getAllManufacturers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerServiceImpl' final or making the method 'getAllManufacturers' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
design | DesignForExtension | Class 'ManufacturerServiceImpl' looks like designed for extension (can be subclassed), but the method 'getManufacturerById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerServiceImpl' final or making the method 'getManufacturerById' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 41 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 45 |
|
design | DesignForExtension | Class 'ManufacturerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findManufacturers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerServiceImpl' final or making the method 'findManufacturers' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 55 |
|
design | DesignForExtension | Class 'ManufacturerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findManufacturerById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerServiceImpl' final or making the method 'findManufacturerById' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 57 |
|
design | DesignForExtension | Class 'ManufacturerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findManufacturerInfo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerServiceImpl' final or making the method 'findManufacturerInfo' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 62 |
|
misc | FinalParameters | Parameter manufacturerId should be final. | 62 |
|
misc | FinalParameters | Parameter language should be final. | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 63 |
|
design | DesignForExtension | Class 'ManufacturerServiceImpl' looks like designed for extension (can be subclassed), but the method 'clickManufacturerUrl' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ManufacturerServiceImpl' final or making the method 'clickManufacturerUrl' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 71 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 72 |
|
misc | FinalParameters | Parameter manufacturerInfo should be final. | 72 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.entities.*. | 6 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.repositories.*. | 9 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'countProductsOfThisManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'countProductsOfThisManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
misc | FinalParameters | Parameter thisManufacturer should be final. | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 50 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'findProductsViewed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'findProductsViewed' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
misc | FinalParameters | Parameter language should be final. | 55 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 56 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'findProductsByCategoryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'findProductsByCategoryId' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 61 |
|
misc | FinalParameters | Parameter categoryId should be final. | 61 |
|
misc | FinalParameters | Parameter language should be final. | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 63 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 64 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 68 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'setProductActive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'setProductActive' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 75 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 75 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 75 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 75 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 75 |
|
misc | FinalParameters | Parameter productId should be final. | 76 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'setProductInactive' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'setProductInactive' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 83 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 83 |
|
misc | FinalParameters | Parameter productId should be final. | 84 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'findProductById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'findProductById' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 91 |
|
misc | FinalParameters | Parameter productId should be final. | 91 |
|
misc | FinalParameters | Parameter language should be final. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 92 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'recommenderNewProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'recommenderNewProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
misc | FinalParameters | Parameter language should be final. | 96 |
|
coding | MagicNumber | '9' is a magic number. | 97 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 100 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 101 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 101 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 104 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'getRandomNewProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'getRandomNewProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
misc | FinalParameters | Parameter language should be final. | 112 |
|
coding | MagicNumber | '100' is a magic number. | 113 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 122 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'viewProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'viewProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 127 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 128 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 128 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 128 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 128 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 128 |
|
misc | FinalParameters | Parameter thisProduct should be final. | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 130 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'findProductsByManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'findProductsByManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. | 137 |
|
misc | FinalParameters | Parameter manufacturer should be final. | 139 |
|
misc | FinalParameters | Parameter language should be final. | 139 |
|
sizes | LineLength | Line is longer than 80 characters (found 119). | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 141 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 144 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 144 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 145 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 146 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 146 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 147 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 147 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 152 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 152 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 153 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 153 |
|
design | DesignForExtension | Class 'ProductServiceImpl' looks like designed for extension (can be subclassed), but the method 'findProductsByManufacturerAndCategory' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductServiceImpl' final or making the method 'findProductsByManufacturerAndCategory' static/final/abstract/empty, or adding allowed annotation for the method. | 164 |
|
misc | FinalParameters | Parameter manufacturer should be final. | 166 |
|
misc | FinalParameters | Parameter categoryId should be final. | 166 |
|
misc | FinalParameters | Parameter language should be final. | 166 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 167 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 167 |
|
sizes | LineLength | Line is longer than 80 characters (found 142). | 168 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 168 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 168 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 169 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 172 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 172 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 173 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 174 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 174 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 175 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 175 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 180 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 180 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 180 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 181 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 181 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.entities.*. | 3 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
sizes | LineLength | Line is longer than 80 characters (found 121). | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 27 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.entities.*. | 5 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.catalog.repositories.*. | 8 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
design | DesignForExtension | Class 'ReviewServiceImpl' looks like designed for extension (can be subclassed), but the method 'getReviewById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewServiceImpl' final or making the method 'getReviewById' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
misc | FinalParameters | Parameter reviewId should be final. | 44 |
|
misc | FinalParameters | Parameter language should be final. | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 53 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
design | DesignForExtension | Class 'ReviewServiceImpl' looks like designed for extension (can be subclassed), but the method 'getAllReviews' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewServiceImpl' final or making the method 'getAllReviews' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
misc | FinalParameters | Parameter language should be final. | 61 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 65 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 70 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 70 |
|
design | DesignForExtension | Class 'ReviewServiceImpl' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewServiceImpl' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 77 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 78 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 78 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 78 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 78 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 78 |
|
misc | FinalParameters | Parameter review should be final. | 79 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 80 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 80 |
|
design | DesignForExtension | Class 'ReviewServiceImpl' looks like designed for extension (can be subclassed), but the method 'saveReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewServiceImpl' final or making the method 'saveReview' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 86 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 86 |
|
misc | FinalParameters | Parameter writeReviewBean should be final. | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 88 |
|
misc | FinalParameters | Parameter product should be final. | 88 |
|
misc | FinalParameters | Parameter customer should be final. | 88 |
|
misc | FinalParameters | Parameter language should be final. | 88 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 89 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 92 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 92 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 98 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 98 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 98 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 98 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 98 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 103 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 103 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 107 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 107 |
|
design | DesignForExtension | Class 'ReviewServiceImpl' looks like designed for extension (can be subclassed), but the method 'findReviewsForProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewServiceImpl' final or making the method 'findReviewsForProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 112 |
|
misc | FinalParameters | Parameter productDescription should be final. | 112 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 114 |
|
design | DesignForExtension | Class 'ReviewServiceImpl' looks like designed for extension (can be subclassed), but the method 'findReviewById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewServiceImpl' final or making the method 'findReviewById' static/final/abstract/empty, or adding allowed annotation for the method. | 117 |
|
misc | FinalParameters | Parameter reviewId should be final. | 118 |
|
misc | FinalParameters | Parameter language should be final. | 118 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 119 |
|
design | DesignForExtension | Class 'ReviewServiceImpl' looks like designed for extension (can be subclassed), but the method 'getRandomReview' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ReviewServiceImpl' final or making the method 'getRandomReview' static/final/abstract/empty, or adding allowed annotation for the method. | 122 |
|
misc | FinalParameters | Parameter language should be final. | 123 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 124 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 124 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 129 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
design | DesignForExtension | Class 'SpecialServiceImpl' looks like designed for extension (can be subclassed), but the method 'updateSpecial' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialServiceImpl' final or making the method 'updateSpecial' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
misc | FinalParameters | Parameter special should be final. | 33 |
|
design | DesignForExtension | Class 'SpecialServiceImpl' looks like designed for extension (can be subclassed), but the method 'findSpecialProductById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialServiceImpl' final or making the method 'findSpecialProductById' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 38 |
|
misc | FinalParameters | Parameter productId should be final. | 38 |
|
misc | FinalParameters | Parameter language should be final. | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 41 |
|
design | DesignForExtension | Class 'SpecialServiceImpl' looks like designed for extension (can be subclassed), but the method 'getRandomSpecial' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialServiceImpl' final or making the method 'getRandomSpecial' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
misc | FinalParameters | Parameter language should be final. | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 59 |
|
design | DesignForExtension | Class 'SpecialServiceImpl' looks like designed for extension (can be subclassed), but the method 'getSpecialProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SpecialServiceImpl' final or making the method 'getSpecialProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
|
misc | FinalParameters | Parameter language should be final. | 65 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 68 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 68 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 73 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 12 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 13 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 15 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 41 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 41 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 41 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 45 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 48 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 54 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 56 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 57 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 58 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 60 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 63 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 66 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 67 |
|
design | DesignForExtension | Class 'CheckoutServiceImpl' looks like designed for extension (can be subclassed), but the method 'transformPersistentAddressToBean' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutServiceImpl' final or making the method 'transformPersistentAddressToBean' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 67 |
|
misc | FinalParameters | Parameter choosenAddress should be final. | 67 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 70 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 77 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 81 |
|
design | DesignForExtension | Class 'CheckoutServiceImpl' looks like designed for extension (can be subclassed), but the method 'transformBeanToPersistentAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutServiceImpl' final or making the method 'transformBeanToPersistentAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 84 |
|
misc | FinalParameters | Parameter newAddress should be final. | 84 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 85 |
|
misc | FinalParameters | Parameter country should be final. | 85 |
|
misc | FinalParameters | Parameter customer should be final. | 86 |
|
design | DesignForExtension | Class 'CheckoutServiceImpl' looks like designed for extension (can be subclassed), but the method 'placeOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutServiceImpl' final or making the method 'placeOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 102 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 102 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 102 |
|
misc | FinalParameters | Parameter checkout should be final. | 103 |
|
misc | FinalParameters | Parameter transientBasket should be final. | 104 |
|
misc | FinalParameters | Parameter customer should be final. | 104 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 106 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 106 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 111 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 117 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 117 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 117 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 120 |
|
sizes | LineLength | Line is longer than 80 characters (found 120). | 121 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 122 |
|
sizes | LineLength | Line is longer than 80 characters (found 120). | 123 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 125 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 126 |
|
whitespace | WhitespaceAround | '*' is not followed by whitespace. | 126 |
|
whitespace | WhitespaceAround | '*' is not preceded with whitespace. | 126 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 127 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 125). | 130 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 130 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 131 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 133 |
|
sizes | LineLength | Line is longer than 80 characters (found 131). | 134 |
|
sizes | LineLength | Line is longer than 80 characters (found 132). | 135 |
|
sizes | LineLength | Line is longer than 80 characters (found 124). | 136 |
|
sizes | LineLength | Line is longer than 80 characters (found 134). | 137 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 138 |
|
coding | MagicNumber | '5.0d' is a magic number. | 143 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 145 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 145 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 145 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 145 |
|
sizes | LineLength | Line is longer than 80 characters (found 100). | 146 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 146 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 146 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 147 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 147 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 147 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 148 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 148 |
|
misc | TodoComment | Comment matches to-do format 'TODO:'. | 148 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 155 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 155 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 162 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 162 |
|
coding | MagicNumber | '4' is a magic number. | 167 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 169 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 169 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 169 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 173 |
|
sizes | LineLength | Line is longer than 80 characters (found 131). | 178 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 178 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 178 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 179 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 181 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 181 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 181 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 187 |
|
misc | FinalParameters | Parameter checkout should be final. | 187 |
|
misc | FinalParameters | Parameter order should be final. | 187 |
|
misc | FinalParameters | Parameter customer should be final. | 187 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 189 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 190 |
|
sizes | LineLength | Line is longer than 80 characters (found 125). | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 192 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 194 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 195 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 196 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 198 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 199 |
|
sizes | LineLength | Line is longer than 80 characters (found 127). | 200 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 200 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 200 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 201 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 202 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 203 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 205 |
|
sizes | LineLength | Line is longer than 80 characters (found 128). | 206 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 206 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 206 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 207 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 208 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 209 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 210 |
|
sizes | LineLength | Line is longer than 80 characters (found 110). | 211 |
|
sizes | LineLength | Line is longer than 80 characters (found 136). | 212 |
|
sizes | LineLength | Line is longer than 80 characters (found 138). | 213 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 215 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 216 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 19 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 27 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 37 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 37 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
design | VisibilityModifier | Variable 'catalogService' must be private and have accessor methods. | 46 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 54 |
|
design | DesignForExtension | Class 'OrderServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllOrderStatuses' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderServiceImpl' final or making the method 'findAllOrderStatuses' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
misc | FinalParameters | Parameter language should be final. | 59 |
|
design | DesignForExtension | Class 'OrderServiceImpl' looks like designed for extension (can be subclassed), but the method 'findOrderStatusById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderServiceImpl' final or making the method 'findOrderStatusById' static/final/abstract/empty, or adding allowed annotation for the method. | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 64 |
|
misc | FinalParameters | Parameter ordersStatusId should be final. | 64 |
|
design | DesignForExtension | Class 'OrderServiceImpl' looks like designed for extension (can be subclassed), but the method 'getAllOrders' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderServiceImpl' final or making the method 'getAllOrders' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
misc | FinalParameters | Parameter language should be final. | 69 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 72 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 72 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 77 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 77 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 82 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 82 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 82 |
|
design | DesignForExtension | Class 'OrderServiceImpl' looks like designed for extension (can be subclassed), but the method 'findOrderById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderServiceImpl' final or making the method 'findOrderById' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
misc | FinalParameters | Parameter orderId should be final. | 91 |
|
misc | FinalParameters | Parameter language should be final. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 98 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 98 |
|
sizes | LineLength | Line is longer than 80 characters (found 106). | 103 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 104 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 104 |
|
design | DesignForExtension | Class 'OrderServiceImpl' looks like designed for extension (can be subclassed), but the method 'findOrdersForCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderServiceImpl' final or making the method 'findOrdersForCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
|
misc | FinalParameters | Parameter customer should be final. | 111 |
|
design | DesignForExtension | Class 'OrderServiceImpl' looks like designed for extension (can be subclassed), but the method 'findOrderDetailsById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderServiceImpl' final or making the method 'findOrderDetailsById' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 116 |
|
misc | FinalParameters | Parameter orderId should be final. | 116 |
|
misc | FinalParameters | Parameter language should be final. | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 119 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 125 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 129). | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 131 |
|
design | DesignForExtension | Class 'OrderServiceImpl' looks like designed for extension (can be subclassed), but the method 'getOrderHistoryForCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderServiceImpl' final or making the method 'getOrderHistoryForCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 137 |
|
sizes | LineLength | Line is longer than 80 characters (found 103). | 138 |
|
misc | FinalParameters | Parameter customer should be final. | 138 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 138 |
|
misc | FinalParameters | Parameter language should be final. | 138 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 139 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 142 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 142 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 143 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 143 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 144 |
|
sizes | LineLength | Line is longer than 80 characters (found 114). | 148 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 151 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 151 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 152 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 154 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 156 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 158 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 165 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 166 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 21 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 24 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 26 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 27 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 29 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 30 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 31 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 38 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 39 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 41 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 42 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 43 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 44 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 45 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 46 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 47 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 48 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 49 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 50 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 51 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 55 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 56 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 57 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 58 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 59 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 60 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 61 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 63 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 64 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 65 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 66 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 69 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 71 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 76 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 79 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 79 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 80 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 80 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 81 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 81 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 81 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 83 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 84 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 86 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 88 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 89 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 90 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 90 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 90 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 91 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 92 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 93 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 93 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 93 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 93 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 94 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 95 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 97 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 97 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 97 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 97 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 98 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 99 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 100 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 100 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 100 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 100 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 101 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 102 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 103 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 104 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 104 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 104 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 105 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 106 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 107 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 108 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 108 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 108 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 109 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 110 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 111 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 111 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 111 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 111 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 112 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 113 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 114 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 115 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 115 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 115 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 117 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 118 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 119 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 119 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 119 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 121 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 122 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 123 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 123 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 123 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 123 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 124 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 125 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 126 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 127 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 127 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 129 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 130 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 131 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 131 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 131 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 132 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 133 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 134 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 135 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 135 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 135 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 135 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 136 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 137 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 138 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 139 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 139 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 139 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 139 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 140 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 141 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 142 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 143 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 143 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 143 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 143 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 144 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 145 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 146 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 147 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 147 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 147 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 148 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 149 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 150 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 151 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 151 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 151 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 152 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 153 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 154 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 155 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 155 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 155 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 155 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 156 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 157 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 158 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 159 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 159 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 159 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 161 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 162 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 163 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 163 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 165 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 166 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 167 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 167 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 167 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 168 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 169 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 170 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 171 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 171 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 171 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 171 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 172 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 173 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 174 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 175 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 175 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 175 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 176 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 177 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 178 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 179 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 179 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 179 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 179 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 180 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 181 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 182 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 183 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 183 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 183 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 184 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 185 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 186 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 187 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 187 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 187 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 188 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 189 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 190 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 190 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 190 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 190 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 191 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 192 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 193 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 194 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 194 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 194 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 196 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 197 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 198 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 198 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 200 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 201 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 202 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 202 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 202 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 204 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 205 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 206 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 206 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 206 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 206 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 207 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 208 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 209 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 210 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 210 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 210 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 210 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 211 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 212 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 213 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 214 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 214 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 214 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 214 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 216 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 217 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 218 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 218 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 218 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 218 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 219 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 220 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 221 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 222 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 223 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 223 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 223 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 224 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 225 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 226 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 227 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 227 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 227 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 229 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 230 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 231 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 231 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 231 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 233 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 234 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 235 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 236 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 236 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 236 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 238 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 239 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 240 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 240 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 240 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 240 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 242 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 243 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 244 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 244 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 244 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 244 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getFormattedDeliveryAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getFormattedDeliveryAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 247 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 247 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 248 |
|
sizes | LineLength | Line is longer than 80 characters (found 132). | 249 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 249 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 249 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 251 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getFormattedBillingAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getFormattedBillingAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 252 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 252 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 253 |
|
sizes | LineLength | Line is longer than 80 characters (found 127). | 254 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 254 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 254 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 256 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 257 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 257 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 261 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 261 |
|
misc | FinalParameters | Parameter id should be final. | 261 |
|
coding | HiddenField | 'id' hides a field. | 261 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 265 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 265 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 269 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 269 |
|
misc | FinalParameters | Parameter customer should be final. | 269 |
|
coding | HiddenField | 'customer' hides a field. | 269 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersName' static/final/abstract/empty, or adding allowed annotation for the method. | 273 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 273 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersName' static/final/abstract/empty, or adding allowed annotation for the method. | 277 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 277 |
|
misc | FinalParameters | Parameter customersName should be final. | 277 |
|
coding | HiddenField | 'customersName' hides a field. | 277 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 281 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 281 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 285 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 285 |
|
misc | FinalParameters | Parameter customersCompany should be final. | 285 |
|
coding | HiddenField | 'customersCompany' hides a field. | 285 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 289 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 289 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 293 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 293 |
|
misc | FinalParameters | Parameter customersStreetAddress should be final. | 293 |
|
coding | HiddenField | 'customersStreetAddress' hides a field. | 293 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 297 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 297 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 301 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 301 |
|
misc | FinalParameters | Parameter customersSuburb should be final. | 301 |
|
coding | HiddenField | 'customersSuburb' hides a field. | 301 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersCity' static/final/abstract/empty, or adding allowed annotation for the method. | 305 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 305 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersCity' static/final/abstract/empty, or adding allowed annotation for the method. | 309 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 309 |
|
misc | FinalParameters | Parameter customersCity should be final. | 309 |
|
coding | HiddenField | 'customersCity' hides a field. | 309 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 313 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 313 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 317 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 317 |
|
misc | FinalParameters | Parameter customersPostcode should be final. | 317 |
|
coding | HiddenField | 'customersPostcode' hides a field. | 317 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersState' static/final/abstract/empty, or adding allowed annotation for the method. | 321 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 321 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersState' static/final/abstract/empty, or adding allowed annotation for the method. | 325 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 325 |
|
misc | FinalParameters | Parameter customersState should be final. | 325 |
|
coding | HiddenField | 'customersState' hides a field. | 325 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 329 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 329 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 333 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 333 |
|
misc | FinalParameters | Parameter customersCountry should be final. | 333 |
|
coding | HiddenField | 'customersCountry' hides a field. | 333 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersTelephone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersTelephone' static/final/abstract/empty, or adding allowed annotation for the method. | 337 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 337 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersTelephone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersTelephone' static/final/abstract/empty, or adding allowed annotation for the method. | 341 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 341 |
|
misc | FinalParameters | Parameter customersTelephone should be final. | 341 |
|
coding | HiddenField | 'customersTelephone' hides a field. | 341 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersEmailAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersEmailAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 345 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 345 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersEmailAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersEmailAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 349 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 349 |
|
misc | FinalParameters | Parameter customersEmailAddress should be final. | 349 |
|
coding | HiddenField | 'customersEmailAddress' hides a field. | 349 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCustomersAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCustomersAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 353 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 353 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 357 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCustomersAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCustomersAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 357 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 357 |
|
misc | FinalParameters | Parameter customersAddressFormat should be final. | 357 |
|
coding | HiddenField | 'customersAddressFormat' hides a field. | 357 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliveryName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliveryName' static/final/abstract/empty, or adding allowed annotation for the method. | 361 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 361 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliveryName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliveryName' static/final/abstract/empty, or adding allowed annotation for the method. | 365 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 365 |
|
misc | FinalParameters | Parameter deliveryName should be final. | 365 |
|
coding | HiddenField | 'deliveryName' hides a field. | 365 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliveryCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliveryCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 369 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 369 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliveryCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliveryCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 373 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 373 |
|
misc | FinalParameters | Parameter deliveryCompany should be final. | 373 |
|
coding | HiddenField | 'deliveryCompany' hides a field. | 373 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliveryStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliveryStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 377 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 377 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliveryStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliveryStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 381 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 381 |
|
misc | FinalParameters | Parameter deliveryStreetAddress should be final. | 381 |
|
coding | HiddenField | 'deliveryStreetAddress' hides a field. | 381 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliverySuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliverySuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 385 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 385 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliverySuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliverySuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 389 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 389 |
|
misc | FinalParameters | Parameter deliverySuburb should be final. | 389 |
|
coding | HiddenField | 'deliverySuburb' hides a field. | 389 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliveryCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliveryCity' static/final/abstract/empty, or adding allowed annotation for the method. | 393 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 393 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliveryCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliveryCity' static/final/abstract/empty, or adding allowed annotation for the method. | 397 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 397 |
|
misc | FinalParameters | Parameter deliveryCity should be final. | 397 |
|
coding | HiddenField | 'deliveryCity' hides a field. | 397 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliveryPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliveryPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 401 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 401 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliveryPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliveryPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 405 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 405 |
|
misc | FinalParameters | Parameter deliveryPostcode should be final. | 405 |
|
coding | HiddenField | 'deliveryPostcode' hides a field. | 405 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliveryState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliveryState' static/final/abstract/empty, or adding allowed annotation for the method. | 409 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 409 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliveryState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliveryState' static/final/abstract/empty, or adding allowed annotation for the method. | 413 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 413 |
|
misc | FinalParameters | Parameter deliveryState should be final. | 413 |
|
coding | HiddenField | 'deliveryState' hides a field. | 413 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliveryCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliveryCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 417 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 417 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliveryCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliveryCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 421 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 421 |
|
misc | FinalParameters | Parameter deliveryCountry should be final. | 421 |
|
coding | HiddenField | 'deliveryCountry' hides a field. | 421 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDeliveryAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDeliveryAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 425 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 425 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 429 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDeliveryAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDeliveryAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 429 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 429 |
|
misc | FinalParameters | Parameter deliveryAddressFormat should be final. | 429 |
|
coding | HiddenField | 'deliveryAddressFormat' hides a field. | 429 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingName' static/final/abstract/empty, or adding allowed annotation for the method. | 433 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 433 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingName' static/final/abstract/empty, or adding allowed annotation for the method. | 437 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 437 |
|
misc | FinalParameters | Parameter billingName should be final. | 437 |
|
coding | HiddenField | 'billingName' hides a field. | 437 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 441 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 441 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 445 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 445 |
|
misc | FinalParameters | Parameter billingCompany should be final. | 445 |
|
coding | HiddenField | 'billingCompany' hides a field. | 445 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 449 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 449 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 453 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 453 |
|
misc | FinalParameters | Parameter billingStreetAddress should be final. | 453 |
|
coding | HiddenField | 'billingStreetAddress' hides a field. | 453 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 457 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 457 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 461 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 461 |
|
misc | FinalParameters | Parameter billingSuburb should be final. | 461 |
|
coding | HiddenField | 'billingSuburb' hides a field. | 461 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingCity' static/final/abstract/empty, or adding allowed annotation for the method. | 465 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 465 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingCity' static/final/abstract/empty, or adding allowed annotation for the method. | 469 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 469 |
|
misc | FinalParameters | Parameter billingCity should be final. | 469 |
|
coding | HiddenField | 'billingCity' hides a field. | 469 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 473 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 473 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 477 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 477 |
|
misc | FinalParameters | Parameter billingPostcode should be final. | 477 |
|
coding | HiddenField | 'billingPostcode' hides a field. | 477 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingState' static/final/abstract/empty, or adding allowed annotation for the method. | 481 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 481 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingState' static/final/abstract/empty, or adding allowed annotation for the method. | 485 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 485 |
|
misc | FinalParameters | Parameter billingState should be final. | 485 |
|
coding | HiddenField | 'billingState' hides a field. | 485 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 489 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 489 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 493 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 493 |
|
misc | FinalParameters | Parameter billingCountry should be final. | 493 |
|
coding | HiddenField | 'billingCountry' hides a field. | 493 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getBillingAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getBillingAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 497 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 497 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 501 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setBillingAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setBillingAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 501 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 501 |
|
misc | FinalParameters | Parameter billingAddressFormat should be final. | 501 |
|
coding | HiddenField | 'billingAddressFormat' hides a field. | 501 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getPaymentMethod' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getPaymentMethod' static/final/abstract/empty, or adding allowed annotation for the method. | 505 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 505 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setPaymentMethod' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setPaymentMethod' static/final/abstract/empty, or adding allowed annotation for the method. | 509 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 509 |
|
misc | FinalParameters | Parameter paymentMethod should be final. | 509 |
|
coding | HiddenField | 'paymentMethod' hides a field. | 509 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCcType' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCcType' static/final/abstract/empty, or adding allowed annotation for the method. | 513 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 513 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCcType' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCcType' static/final/abstract/empty, or adding allowed annotation for the method. | 517 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 517 |
|
misc | FinalParameters | Parameter ccType should be final. | 517 |
|
coding | HiddenField | 'ccType' hides a field. | 517 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCcOwner' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCcOwner' static/final/abstract/empty, or adding allowed annotation for the method. | 521 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 521 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCcOwner' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCcOwner' static/final/abstract/empty, or adding allowed annotation for the method. | 525 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 525 |
|
misc | FinalParameters | Parameter ccOwner should be final. | 525 |
|
coding | HiddenField | 'ccOwner' hides a field. | 525 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCcNumber' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCcNumber' static/final/abstract/empty, or adding allowed annotation for the method. | 529 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 529 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCcNumber' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCcNumber' static/final/abstract/empty, or adding allowed annotation for the method. | 533 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 533 |
|
misc | FinalParameters | Parameter ccNumber should be final. | 533 |
|
coding | HiddenField | 'ccNumber' hides a field. | 533 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCcExpires' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCcExpires' static/final/abstract/empty, or adding allowed annotation for the method. | 537 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 537 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCcExpires' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCcExpires' static/final/abstract/empty, or adding allowed annotation for the method. | 541 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 541 |
|
misc | FinalParameters | Parameter ccExpires should be final. | 541 |
|
coding | HiddenField | 'ccExpires' hides a field. | 541 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 545 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 545 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 549 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 549 |
|
misc | FinalParameters | Parameter lastModified should be final. | 549 |
|
coding | HiddenField | 'lastModified' hides a field. | 549 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getDatePurchased' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getDatePurchased' static/final/abstract/empty, or adding allowed annotation for the method. | 553 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 553 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setDatePurchased' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setDatePurchased' static/final/abstract/empty, or adding allowed annotation for the method. | 557 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 557 |
|
misc | FinalParameters | Parameter datePurchased should be final. | 557 |
|
coding | HiddenField | 'datePurchased' hides a field. | 557 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getOrdersStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getOrdersStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 561 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 561 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setOrdersStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setOrdersStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 565 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 565 |
|
misc | FinalParameters | Parameter ordersStatus should be final. | 565 |
|
coding | HiddenField | 'ordersStatus' hides a field. | 565 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getOrdersDateFinished' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getOrdersDateFinished' static/final/abstract/empty, or adding allowed annotation for the method. | 569 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 569 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setOrdersDateFinished' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setOrdersDateFinished' static/final/abstract/empty, or adding allowed annotation for the method. | 573 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 573 |
|
misc | FinalParameters | Parameter ordersDateFinished should be final. | 573 |
|
coding | HiddenField | 'ordersDateFinished' hides a field. | 573 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCurrency' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCurrency' static/final/abstract/empty, or adding allowed annotation for the method. | 577 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 577 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCurrency' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCurrency' static/final/abstract/empty, or adding allowed annotation for the method. | 581 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 581 |
|
misc | FinalParameters | Parameter currency should be final. | 581 |
|
coding | HiddenField | 'currency' hides a field. | 581 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'getCurrencyValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'getCurrencyValue' static/final/abstract/empty, or adding allowed annotation for the method. | 585 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 585 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'setCurrencyValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'setCurrencyValue' static/final/abstract/empty, or adding allowed annotation for the method. | 589 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 589 |
|
misc | FinalParameters | Parameter currencyValue should be final. | 589 |
|
coding | HiddenField | 'currencyValue' hides a field. | 589 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 593 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 599 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 602 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 604 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 606 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 608 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 610 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 612 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 615 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 618 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 620 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 622 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 623 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 624 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 626 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 628 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 630 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 634 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 636 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 639 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 642 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 645 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 648 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 651 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 654 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 658 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 660 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 663 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 666 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 669 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 672 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 674 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 676 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 678 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 681 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 683 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 686 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 689 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 692 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 695 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 697 |
|
coding | MagicNumber | '32' is a magic number. | 697 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 699 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 703 |
|
sizes | MethodLength | Method equals length is 217 lines (max allowed is 150). | 703 |
|
misc | FinalParameters | Parameter obj should be final. | 704 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 705 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 707 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 709 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 713 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 715 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 715 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 718 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 720 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 723 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 725 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 728 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 730 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 733 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 735 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 738 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 740 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 743 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 745 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 748 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 750 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 750 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 753 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 755 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 758 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 760 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 763 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 765 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 768 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 770 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 773 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 775 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 778 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 780 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 783 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 785 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 788 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 790 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 793 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 795 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 795 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 798 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 800 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 803 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 805 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 808 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 810 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 813 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 815 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 815 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 818 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 820 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 823 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 825 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 828 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 830 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 833 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 835 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 835 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 838 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 840 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 843 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 845 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 848 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 850 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 853 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 855 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 855 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 858 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 860 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 863 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 865 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 868 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 870 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 873 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 875 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 878 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 880 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 883 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 885 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 888 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 890 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 890 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 893 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 895 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 898 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 900 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 903 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 905 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 908 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 910 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 912 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 915 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 917 |
|
design | DesignForExtension | Class 'Order' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Order' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 922 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 925 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 928 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 930 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 932 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 933 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 934 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 936 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 937 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 938 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 939 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 941 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 943 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 944 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 945 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 946 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 948 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 949 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 950 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 951 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 952 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 957 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 5 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 13 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 39 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 41 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 46 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 49 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 49 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 55 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 56 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 58 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 62 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 64 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 64 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 66 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 68 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 68 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 70 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 71 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 72 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 72 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 72 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 74 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 75 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 76 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 76 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
|
misc | FinalParameters | Parameter id should be final. | 83 |
|
coding | HiddenField | 'id' hides a field. | 83 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 87 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 91 |
|
misc | FinalParameters | Parameter order should be final. | 91 |
|
coding | HiddenField | 'order' hides a field. | 91 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
misc | FinalParameters | Parameter product should be final. | 99 |
|
coding | HiddenField | 'product' hides a field. | 99 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getProductsModel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getProductsModel' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 103 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setProductsModel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setProductsModel' static/final/abstract/empty, or adding allowed annotation for the method. | 107 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 107 |
|
misc | FinalParameters | Parameter productsModel should be final. | 107 |
|
coding | HiddenField | 'productsModel' hides a field. | 107 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getProductsName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getProductsName' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 111 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setProductsName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setProductsName' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 115 |
|
misc | FinalParameters | Parameter productsName should be final. | 115 |
|
coding | HiddenField | 'productsName' hides a field. | 115 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getProductsPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getProductsPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 119 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 119 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setProductsPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setProductsPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 123 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 123 |
|
misc | FinalParameters | Parameter productsPrice should be final. | 123 |
|
coding | HiddenField | 'productsPrice' hides a field. | 123 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getFinalPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getFinalPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 127 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 127 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setFinalPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setFinalPrice' static/final/abstract/empty, or adding allowed annotation for the method. | 131 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 131 |
|
misc | FinalParameters | Parameter finalPrice should be final. | 131 |
|
coding | HiddenField | 'finalPrice' hides a field. | 131 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getProductsTax' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getProductsTax' static/final/abstract/empty, or adding allowed annotation for the method. | 135 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 135 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setProductsTax' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setProductsTax' static/final/abstract/empty, or adding allowed annotation for the method. | 139 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 139 |
|
misc | FinalParameters | Parameter productsTax should be final. | 139 |
|
coding | HiddenField | 'productsTax' hides a field. | 139 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getProductsQuantity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getProductsQuantity' static/final/abstract/empty, or adding allowed annotation for the method. | 143 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 143 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'getOrderProductAttribute' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'getOrderProductAttribute' static/final/abstract/empty, or adding allowed annotation for the method. | 148 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 148 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 152 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setOrderProductAttribute' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setOrderProductAttribute' static/final/abstract/empty, or adding allowed annotation for the method. | 152 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 152 |
|
misc | FinalParameters | Parameter orderProductAttribute should be final. | 152 |
|
coding | HiddenField | 'orderProductAttribute' hides a field. | 152 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'setProductsQuantity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'setProductsQuantity' static/final/abstract/empty, or adding allowed annotation for the method. | 156 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 156 |
|
misc | FinalParameters | Parameter productsQuantity should be final. | 156 |
|
coding | HiddenField | 'productsQuantity' hides a field. | 156 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 160 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 165 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 167 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 168 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 170 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 172 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 174 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 177 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 181 |
|
misc | FinalParameters | Parameter obj should be final. | 182 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 183 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 185 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 187 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 191 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 193 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 196 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 198 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 201 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 203 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 206 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 208 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 211 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 213 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 216 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 218 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 221 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 223 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 225 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 228 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 230 |
|
design | DesignForExtension | Class 'OrderProduct' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProduct' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 235 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 237 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 239 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 241 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 245 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 246 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 247 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 6 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 7 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 9 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 10 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 13 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 14 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 15 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 16 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 18 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 19 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 31 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 36 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 38 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 40 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 40 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 49 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 53 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 55 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 57 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 57 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 57 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 64 |
|
misc | FinalParameters | Parameter id should be final. | 64 |
|
coding | HiddenField | 'id' hides a field. | 64 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'getOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'getOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'setOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'setOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
misc | FinalParameters | Parameter order should be final. | 72 |
|
coding | HiddenField | 'order' hides a field. | 72 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'getOrderProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'getOrderProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'setOrderProduct' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'setOrderProduct' static/final/abstract/empty, or adding allowed annotation for the method. | 80 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 80 |
|
misc | FinalParameters | Parameter orderProduct should be final. | 80 |
|
coding | HiddenField | 'orderProduct' hides a field. | 80 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'getProductOption' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'getProductOption' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 84 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'setProductOption' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'setProductOption' static/final/abstract/empty, or adding allowed annotation for the method. | 88 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 88 |
|
misc | FinalParameters | Parameter productOption should be final. | 88 |
|
coding | HiddenField | 'productOption' hides a field. | 88 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'getProductOptionValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'getProductOptionValue' static/final/abstract/empty, or adding allowed annotation for the method. | 92 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 92 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'setProductOptionValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'setProductOptionValue' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 96 |
|
misc | FinalParameters | Parameter productOptionValue should be final. | 96 |
|
coding | HiddenField | 'productOptionValue' hides a field. | 96 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'getOptionValuePrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'getOptionValuePrice' static/final/abstract/empty, or adding allowed annotation for the method. | 100 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'setOptionValuePrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'setOptionValuePrice' static/final/abstract/empty, or adding allowed annotation for the method. | 104 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 104 |
|
misc | FinalParameters | Parameter optionValuePrice should be final. | 104 |
|
coding | HiddenField | 'optionValuePrice' hides a field. | 104 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'getPricePrefix' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'getPricePrefix' static/final/abstract/empty, or adding allowed annotation for the method. | 108 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 108 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'setPricePrefix' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'setPricePrefix' static/final/abstract/empty, or adding allowed annotation for the method. | 112 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 112 |
|
misc | FinalParameters | Parameter pricePrefix should be final. | 112 |
|
coding | HiddenField | 'pricePrefix' hides a field. | 112 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 123 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 124 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 126 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 128 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 133 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 138 |
|
misc | FinalParameters | Parameter obj should be final. | 139 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 140 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 142 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 144 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 148 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 150 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 153 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 155 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 158 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 160 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 163 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 165 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 168 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 170 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 173 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 175 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 178 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 180 |
|
design | DesignForExtension | Class 'OrderProductAttribute' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderProductAttribute' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 185 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 188 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 191 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 193 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 17 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 18 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 42 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 50 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 52 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 54 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 56 |
|
naming | MemberName | Name 'public_flag' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 57 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 57 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 57 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 58 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 60 |
|
naming | MemberName | Name 'downloads_flag' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 61 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 61 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 63 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 67 |
|
misc | FinalParameters | Parameter id should be final. | 67 |
|
coding | HiddenField | 'id' hides a field. | 67 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 71 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 75 |
|
misc | FinalParameters | Parameter language should be final. | 75 |
|
coding | HiddenField | 'language' hides a field. | 75 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'getOrdersStatusName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'getOrdersStatusName' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'setOrdersStatusName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'setOrdersStatusName' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
|
misc | FinalParameters | Parameter ordersStatusName should be final. | 83 |
|
coding | HiddenField | 'ordersStatusName' hides a field. | 83 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'getPublic_flag' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'getPublic_flag' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 87 |
|
naming | MethodName | Name 'getPublic_flag' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 87 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'setPublic_flag' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'setPublic_flag' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 91 |
|
naming | MethodName | Name 'setPublic_flag' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 91 |
|
misc | FinalParameters | Parameter public_flag should be final. | 91 |
|
coding | HiddenField | 'public_flag' hides a field. | 91 |
|
naming | ParameterName | Name 'public_flag' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 91 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'getDownloads_flag' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'getDownloads_flag' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
naming | MethodName | Name 'getDownloads_flag' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 95 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'setDownloads_flag' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'setDownloads_flag' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
naming | MethodName | Name 'setDownloads_flag' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 99 |
|
misc | FinalParameters | Parameter downloads_flag should be final. | 99 |
|
coding | HiddenField | 'downloads_flag' hides a field. | 99 |
|
naming | ParameterName | Name 'downloads_flag' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 99 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 108 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 114 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 116 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
|
misc | FinalParameters | Parameter obj should be final. | 121 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 122 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 124 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 126 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 130 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 132 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 135 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 137 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 140 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 142 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 145 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 147 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 150 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 152 |
|
design | DesignForExtension | Class 'OrderStatus' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatus' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 157 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 160 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 161 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 163 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 164 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 18 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 19 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 49 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 54 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 56 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 57 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 58 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 58 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 58 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 60 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 62 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 62 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 62 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 64 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 65 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 65 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 65 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 65 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 67 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 68 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 68 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 71 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 75 |
|
misc | FinalParameters | Parameter id should be final. | 75 |
|
coding | HiddenField | 'id' hides a field. | 75 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'getOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'getOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'setOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'setOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
|
misc | FinalParameters | Parameter order should be final. | 83 |
|
coding | HiddenField | 'order' hides a field. | 83 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'getOrdersStatusId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'getOrdersStatusId' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 87 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'setOrdersStatusId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'setOrdersStatusId' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 91 |
|
misc | FinalParameters | Parameter ordersStatusId should be final. | 91 |
|
coding | HiddenField | 'ordersStatusId' hides a field. | 91 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 99 |
|
coding | HiddenField | 'dateAdded' hides a field. | 99 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'getCustomerNotified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'getCustomerNotified' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 103 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'setCustomerNotified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'setCustomerNotified' static/final/abstract/empty, or adding allowed annotation for the method. | 107 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 107 |
|
misc | FinalParameters | Parameter customerNotified should be final. | 107 |
|
coding | HiddenField | 'customerNotified' hides a field. | 107 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'getComments' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'getComments' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 111 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'setComments' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'setComments' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 115 |
|
misc | FinalParameters | Parameter comments should be final. | 115 |
|
coding | HiddenField | 'comments' hides a field. | 115 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 119 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 124 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 127 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 129 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 131 |
|
coding | MagicNumber | '32' is a magic number. | 131 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 135 |
|
misc | FinalParameters | Parameter obj should be final. | 136 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 137 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 139 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 141 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 145 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 147 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 149 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 152 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 154 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 157 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 159 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 162 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 164 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 166 |
|
design | DesignForExtension | Class 'OrderStatusHistory' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistory' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 171 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 174 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 175 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 178 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 179 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 9 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 9 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 14 |
|
design | DesignForExtension | Class 'OrderStatusId' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusId' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
design | DesignForExtension | Class 'OrderStatusId' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusId' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
misc | FinalParameters | Parameter id should be final. | 18 |
|
coding | HiddenField | 'id' hides a field. | 18 |
|
design | DesignForExtension | Class 'OrderStatusId' looks like designed for extension (can be subclassed), but the method 'getLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusId' final or making the method 'getLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
design | DesignForExtension | Class 'OrderStatusId' looks like designed for extension (can be subclassed), but the method 'setLanguage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusId' final or making the method 'setLanguage' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
misc | FinalParameters | Parameter language should be final. | 24 |
|
coding | HiddenField | 'language' hides a field. | 24 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 27 |
|
design | DesignForExtension | Class 'OrderStatusId' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusId' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 34 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 37 |
|
design | DesignForExtension | Class 'OrderStatusId' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusId' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
misc | FinalParameters | Parameter obj should be final. | 39 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 40 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 42 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 44 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 48 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 50 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 53 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 55 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 59 |
|
design | DesignForExtension | Class 'OrderStatusId' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusId' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 62 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 64 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 14 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 16 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 18 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 19 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 20 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 22 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 23 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 24 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 26 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 27 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 28 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 53 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 55 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 58 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 58 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 60 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 61 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 61 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 63 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 64 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 64 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 66 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 67 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 67 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 67 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 70 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 70 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 70 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 70 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 73 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 73 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 80 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 80 |
|
misc | FinalParameters | Parameter id should be final. | 80 |
|
coding | HiddenField | 'id' hides a field. | 80 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'getOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'getOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 84 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'setOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'setOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 88 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 88 |
|
misc | FinalParameters | Parameter order should be final. | 88 |
|
coding | HiddenField | 'order' hides a field. | 88 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'getTitle' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'getTitle' static/final/abstract/empty, or adding allowed annotation for the method. | 92 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 92 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'setTitle' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'setTitle' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 96 |
|
misc | FinalParameters | Parameter title should be final. | 96 |
|
coding | HiddenField | 'title' hides a field. | 96 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'getText' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'getText' static/final/abstract/empty, or adding allowed annotation for the method. | 100 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'setText' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'setText' static/final/abstract/empty, or adding allowed annotation for the method. | 104 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 104 |
|
misc | FinalParameters | Parameter text should be final. | 104 |
|
coding | HiddenField | 'text' hides a field. | 104 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'getValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'getValue' static/final/abstract/empty, or adding allowed annotation for the method. | 108 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 108 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'setValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'setValue' static/final/abstract/empty, or adding allowed annotation for the method. | 112 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 112 |
|
misc | FinalParameters | Parameter value should be final. | 112 |
|
coding | HiddenField | 'value' hides a field. | 112 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'getTotalClass' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'getTotalClass' static/final/abstract/empty, or adding allowed annotation for the method. | 116 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 116 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'setTotalClass' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'setTotalClass' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 120 |
|
misc | FinalParameters | Parameter totalClass should be final. | 120 |
|
coding | HiddenField | 'totalClass' hides a field. | 120 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'getSortOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'getSortOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 124 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 124 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'setSortOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'setSortOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 128 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 128 |
|
misc | FinalParameters | Parameter sortOrder should be final. | 128 |
|
coding | HiddenField | 'sortOrder' hides a field. | 128 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 132 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 137 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 138 |
|
coding | MagicNumber | '32' is a magic number. | 138 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 139 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 142 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 143 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 147 |
|
misc | FinalParameters | Parameter obj should be final. | 148 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 149 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 151 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 153 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 157 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 159 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 162 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 164 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 166 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 169 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 171 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 174 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 176 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 179 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 181 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 184 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 186 |
|
design | DesignForExtension | Class 'OrderTotal' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderTotal' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 191 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 193 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 194 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 197 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 198 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 14 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 20 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 23 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 27 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 29 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 35 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 36 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 38 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 41 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 45 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
|
javadoc | JavadocMethod | @return tag should be present and have description. | 53 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 53 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 54 |
|
blocks | LeftCurly | '{' at column 27 should have line break after. | 54 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 54 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 55 |
|
blocks | LeftCurly | '{' at column 26 should have line break after. | 55 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 56 |
|
blocks | LeftCurly | '{' at column 25 should have line break after. | 56 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 57 |
|
blocks | LeftCurly | '{' at column 31 should have line break after. | 57 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 57 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 58 |
|
blocks | LeftCurly | '{' at column 24 should have line break after. | 58 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 58 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 59 |
|
blocks | LeftCurly | '{' at column 22 should have line break after. | 59 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 59 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 60 |
|
blocks | LeftCurly | '{' at column 26 should have line break after. | 60 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 60 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 61 |
|
blocks | LeftCurly | '{' at column 23 should have line break after. | 61 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 61 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 62 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 62 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 62 |
|
blocks | LeftCurly | '{' at column 18 should have line break after. | 62 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 62 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 65 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'validate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'validate' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
|
misc | FinalParameters | Parameter result should be final. | 66 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 66 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 66 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 67 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 67 |
|
blocks | LeftCurly | '{' at column 26 should have line break after. | 67 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 67 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 67 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 68 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 68 |
|
blocks | LeftCurly | '{' at column 25 should have line break after. | 68 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 68 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 68 |
|
sizes | LineLength | Line is longer than 80 characters (found 123). | 69 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 69 |
|
blocks | LeftCurly | '{' at column 30 should have line break after. | 69 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 69 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 69 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 70 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 70 |
|
blocks | LeftCurly | '{' at column 21 should have line break after. | 70 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 70 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 70 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 70 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 71 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 71 |
|
blocks | LeftCurly | '{' at column 25 should have line break after. | 71 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 71 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 71 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 72 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 72 |
|
blocks | LeftCurly | '{' at column 22 should have line break after. | 72 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 72 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 72 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 72 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 73 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 118). | 74 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 74 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 76 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 76 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 77 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 79 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 79 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 79 |
|
coding | MagicNumber | '6' is a magic number. | 79 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 79 |
|
sizes | LineLength | Line is longer than 80 characters (found 122). | 80 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 80 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 80 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 82 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 82 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 82 |
|
coding | MagicNumber | '3' is a magic number. | 82 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 82 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 83 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 85 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 85 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 85 |
|
coding | MagicNumber | '4' is a magic number. | 85 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 85 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 86 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 86 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 88 |
|
whitespace | WhitespaceAround | '<' is not followed by whitespace. | 88 |
|
whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 88 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 88 |
|
sizes | LineLength | Line is longer than 80 characters (found 114). | 89 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 89 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 89 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getFormattedAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getFormattedAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 93 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 93 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 93 |
|
sizes | LineLength | Line is longer than 80 characters (found 114). | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 94 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 94 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 96 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getGender' static/final/abstract/empty, or adding allowed annotation for the method. | 97 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 97 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setGender' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 101 |
|
misc | FinalParameters | Parameter gender should be final. | 101 |
|
coding | HiddenField | 'gender' hides a field. | 101 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 105 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 105 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 109 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 109 |
|
misc | FinalParameters | Parameter firstname should be final. | 109 |
|
coding | HiddenField | 'firstname' hides a field. | 109 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 113 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 117 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 117 |
|
misc | FinalParameters | Parameter lastname should be final. | 117 |
|
coding | HiddenField | 'lastname' hides a field. | 117 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 121 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 121 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 125 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 125 |
|
misc | FinalParameters | Parameter company should be final. | 125 |
|
coding | HiddenField | 'company' hides a field. | 125 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 129 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 129 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 133 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 133 |
|
misc | FinalParameters | Parameter streetAddress should be final. | 133 |
|
coding | HiddenField | 'streetAddress' hides a field. | 133 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 137 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 137 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 141 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 141 |
|
misc | FinalParameters | Parameter suburb should be final. | 141 |
|
coding | HiddenField | 'suburb' hides a field. | 141 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 145 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 145 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 149 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 149 |
|
misc | FinalParameters | Parameter postcode should be final. | 149 |
|
coding | HiddenField | 'postcode' hides a field. | 149 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getCity' static/final/abstract/empty, or adding allowed annotation for the method. | 153 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 153 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setCity' static/final/abstract/empty, or adding allowed annotation for the method. | 157 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 157 |
|
misc | FinalParameters | Parameter city should be final. | 157 |
|
coding | HiddenField | 'city' hides a field. | 157 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getState' static/final/abstract/empty, or adding allowed annotation for the method. | 161 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 161 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setState' static/final/abstract/empty, or adding allowed annotation for the method. | 165 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 165 |
|
misc | FinalParameters | Parameter state should be final. | 165 |
|
coding | HiddenField | 'state' hides a field. | 165 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getCountryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getCountryId' static/final/abstract/empty, or adding allowed annotation for the method. | 169 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 169 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setCountryId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setCountryId' static/final/abstract/empty, or adding allowed annotation for the method. | 173 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 173 |
|
misc | FinalParameters | Parameter countryId should be final. | 173 |
|
coding | HiddenField | 'countryId' hides a field. | 173 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getCountryName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getCountryName' static/final/abstract/empty, or adding allowed annotation for the method. | 177 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 177 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setCountryName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setCountryName' static/final/abstract/empty, or adding allowed annotation for the method. | 181 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 181 |
|
misc | FinalParameters | Parameter countryName should be final. | 181 |
|
coding | HiddenField | 'countryName' hides a field. | 181 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 185 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 188 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'getChoosenAddressId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'getChoosenAddressId' static/final/abstract/empty, or adding allowed annotation for the method. | 189 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 189 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'setChoosenAddressId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'setChoosenAddressId' static/final/abstract/empty, or adding allowed annotation for the method. | 193 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 193 |
|
misc | FinalParameters | Parameter choosenAddressId should be final. | 193 |
|
coding | HiddenField | 'choosenAddressId' hides a field. | 193 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 197 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 201 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 202 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 203 |
|
coding | MagicNumber | '32' is a magic number. | 203 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 205 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 207 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 208 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 210 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 212 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 213 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 215 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 216 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 220 |
|
misc | FinalParameters | Parameter obj should be final. | 221 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 222 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 224 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 226 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 230 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 232 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 235 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 237 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 239 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 242 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 244 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 247 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 249 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 252 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 254 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 257 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 259 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 262 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 264 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 267 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 269 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 272 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 274 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 277 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 279 |
|
design | DesignForExtension | Class 'AddressBean' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBean' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 284 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 286 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 287 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 288 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 289 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 290 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 291 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 5 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 5 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
|
design | DesignForExtension | Class 'CheckoutBean' looks like designed for extension (can be subclassed), but the method 'getCustomersAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutBean' final or making the method 'getCustomersAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 8 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 8 |
|
design | DesignForExtension | Class 'CheckoutBean' looks like designed for extension (can be subclassed), but the method 'setCustomersAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutBean' final or making the method 'setCustomersAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
misc | FinalParameters | Parameter customersAddress should be final. | 11 |
|
coding | HiddenField | 'customersAddress' hides a field. | 11 |
|
design | DesignForExtension | Class 'CheckoutBean' looks like designed for extension (can be subclassed), but the method 'getShippingAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutBean' final or making the method 'getShippingAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
design | DesignForExtension | Class 'CheckoutBean' looks like designed for extension (can be subclassed), but the method 'setShippingAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutBean' final or making the method 'setShippingAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
misc | FinalParameters | Parameter shippingAddress should be final. | 17 |
|
coding | HiddenField | 'shippingAddress' hides a field. | 17 |
|
design | DesignForExtension | Class 'CheckoutBean' looks like designed for extension (can be subclassed), but the method 'getPaymentAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutBean' final or making the method 'getPaymentAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
design | DesignForExtension | Class 'CheckoutBean' looks like designed for extension (can be subclassed), but the method 'setPaymentAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckoutBean' final or making the method 'setPaymentAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
misc | FinalParameters | Parameter paymentAddress should be final. | 23 |
|
coding | HiddenField | 'paymentAddress' hides a field. | 23 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 27 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 6 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'getOrderId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'getOrderId' static/final/abstract/empty, or adding allowed annotation for the method. | 12 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'setOrderId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'setOrderId' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
misc | FinalParameters | Parameter orderId should be final. | 15 |
|
coding | HiddenField | 'orderId' hides a field. | 15 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'getStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'getStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'setStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'setStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
misc | FinalParameters | Parameter status should be final. | 21 |
|
coding | HiddenField | 'status' hides a field. | 21 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'getShippedTo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'getShippedTo' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'setShippedTo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'setShippedTo' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 27 |
|
misc | FinalParameters | Parameter shippedTo should be final. | 27 |
|
coding | HiddenField | 'shippedTo' hides a field. | 27 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'getQuantityOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'getQuantityOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'setQuantityOfProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'setQuantityOfProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
|
misc | FinalParameters | Parameter quantityOfProducts should be final. | 33 |
|
coding | HiddenField | 'quantityOfProducts' hides a field. | 33 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'getCost' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'getCost' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'setCost' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'setCost' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
misc | FinalParameters | Parameter cost should be final. | 39 |
|
coding | HiddenField | 'cost' hides a field. | 39 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'getDate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'getDate' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 42 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'setDate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'setDate' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
misc | FinalParameters | Parameter date should be final. | 45 |
|
coding | HiddenField | 'date' hides a field. | 45 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 53 |
|
coding | MagicNumber | '32' is a magic number. | 54 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 57 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 58 |
|
design | DesignForExtension | Class 'OrderHistoryBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
misc | FinalParameters | Parameter obj should be final. | 62 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 63 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 65 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 67 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 71 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 73 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 76 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 78 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 80 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 82 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 85 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 87 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 90 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 92 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 96 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'getOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'getOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'setOrder' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'setOrder' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
misc | FinalParameters | Parameter order should be final. | 20 |
|
coding | HiddenField | 'order' hides a field. | 20 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'getOrderStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'getOrderStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'setOrderStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'setOrderStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
misc | FinalParameters | Parameter orderStatus should be final. | 26 |
|
coding | HiddenField | 'orderStatus' hides a field. | 26 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'getOrderTotal' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'getOrderTotal' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'setOrderTotal' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'setOrderTotal' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
|
misc | FinalParameters | Parameter orderTotal should be final. | 32 |
|
coding | HiddenField | 'orderTotal' hides a field. | 32 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'getOrderProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'getOrderProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 35 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'setOrderProducts' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'setOrderProducts' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
|
misc | FinalParameters | Parameter orderProducts should be final. | 38 |
|
coding | HiddenField | 'orderProducts' hides a field. | 38 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'getOrderStatusHistoryBeans' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'getOrderStatusHistoryBeans' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
|
design | DesignForExtension | Class 'OrderHistoryDetailsBean' looks like designed for extension (can be subclassed), but the method 'setOrderStatusHistoryBeans' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderHistoryDetailsBean' final or making the method 'setOrderStatusHistoryBeans' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
misc | FinalParameters | Parameter orderStatusHistoryBeans should be final. | 45 |
|
coding | HiddenField | 'orderStatusHistoryBeans' hides a field. | 45 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 48 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 6 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 6 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 10 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 11 |
|
coding | HiddenField | 'dateAdded' hides a field. | 11 |
|
misc | FinalParameters | Parameter status should be final. | 11 |
|
coding | HiddenField | 'status' hides a field. | 11 |
|
misc | FinalParameters | Parameter comments should be final. | 11 |
|
coding | HiddenField | 'comments' hides a field. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 26 |
|
coding | HiddenField | 'dateAdded' hides a field. | 26 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'getStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'getStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'setStatus' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'setStatus' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
|
misc | FinalParameters | Parameter status should be final. | 34 |
|
coding | HiddenField | 'status' hides a field. | 34 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'getComments' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'getComments' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'setComments' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'setComments' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 42 |
|
misc | FinalParameters | Parameter comments should be final. | 42 |
|
coding | HiddenField | 'comments' hides a field. | 42 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 51 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 53 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 54 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
misc | FinalParameters | Parameter obj should be final. | 59 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 60 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 62 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 64 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 68 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 70 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 73 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 75 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 78 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 80 |
|
design | DesignForExtension | Class 'OrderStatusHistoryBean' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrderStatusHistoryBean' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 87 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 90 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 91 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 6 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 9 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 13 |
|
sizes | LineLength | Line is longer than 80 characters (found 263). | 15 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 16 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 10 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 10 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.customer.entities.*. | 8 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 15 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 27 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 35 |
|
sizes | LineLength | Line is longer than 80 characters (found 115). | 37 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 43 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 47 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.customer.entities.*. | 24 |
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.woehlke.greenshop.oodm.customer.repository.*. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 35 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 35 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 36 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 48 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 58 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'createNewCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'createNewCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 71 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 71 |
|
misc | FinalParameters | Parameter createNewCustomerFormBean should be final. | 73 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 74 |
|
sizes | LineLength | Line is longer than 80 characters (found 110). | 76 |
|
sizes | LineLength | Line is longer than 80 characters (found 98). | 78 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 82 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 82 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 83 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 83 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 119). | 92 |
|
misc | FinalParameters | Parameter createNewCustomerFormBean should be final. | 92 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 92 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 98 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 99 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 101 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 106 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 107 |
|
misc | FinalParameters | Parameter createNewCustomerFormBean should be final. | 107 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 107 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 111 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 116 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 117 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findCustomerByEmail' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'findCustomerByEmail' static/final/abstract/empty, or adding allowed annotation for the method. | 123 |
|
misc | FinalParameters | Parameter email should be final. | 124 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'deleteCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'deleteCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 128 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 129 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 129 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 129 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 129 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 129 |
|
misc | FinalParameters | Parameter c should be final. | 130 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 131 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 132 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 132 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'loadUserByUsername' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'loadUserByUsername' static/final/abstract/empty, or adding allowed annotation for the method. | 139 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 140 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 140 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 140 |
|
misc | FinalParameters | Parameter username should be final. | 141 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 143 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 144 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 144 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 144 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 145 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'updateCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'updateCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 152 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 153 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 153 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 153 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 153 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 153 |
|
misc | FinalParameters | Parameter customer should be final. | 154 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 155 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 158 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 158 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAddressBookForCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'findAddressBookForCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 161 |
|
misc | FinalParameters | Parameter customer should be final. | 162 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAddressById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'findAddressById' static/final/abstract/empty, or adding allowed annotation for the method. | 166 |
|
misc | FinalParameters | Parameter addressId should be final. | 167 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'updateAddressBook' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'updateAddressBook' static/final/abstract/empty, or adding allowed annotation for the method. | 172 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 173 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 173 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 173 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 173 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 173 |
|
misc | FinalParameters | Parameter persistentAddress should be final. | 174 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 175 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 175 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 175 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'deleteAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'deleteAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 178 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 179 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 179 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 179 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 179 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 179 |
|
misc | FinalParameters | Parameter customersAddress should be final. | 180 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'addAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'addAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 184 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 185 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 185 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 185 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 185 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 185 |
|
misc | FinalParameters | Parameter transientAddress should be final. | 186 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 187 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 187 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 187 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 187 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findCustomerInfoByCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'findCustomerInfoByCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 190 |
|
misc | FinalParameters | Parameter customer should be final. | 191 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'updateCustomerInfo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'updateCustomerInfo' static/final/abstract/empty, or adding allowed annotation for the method. | 195 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 196 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 196 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 196 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 196 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 196 |
|
misc | FinalParameters | Parameter myCustomerInfo should be final. | 197 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllProductNotificationsForCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'findAllProductNotificationsForCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 201 |
|
sizes | LineLength | Line is longer than 80 characters (found 122). | 202 |
|
misc | FinalParameters | Parameter customer should be final. | 202 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 202 |
|
misc | FinalParameters | Parameter language should be final. | 202 |
|
sizes | LineLength | Line is longer than 80 characters (found 140). | 203 |
|
sizes | LineLength | Line is longer than 80 characters (found 107). | 204 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 205 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 205 |
|
sizes | LineLength | Line is longer than 80 characters (found 104). | 206 |
|
sizes | LineLength | Line is longer than 80 characters (found 102). | 210 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 210 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 210 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 211 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'addProductNotification' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'addProductNotification' static/final/abstract/empty, or adding allowed annotation for the method. | 219 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 220 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 220 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 220 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 220 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 220 |
|
misc | FinalParameters | Parameter product should be final. | 221 |
|
misc | FinalParameters | Parameter customer should be final. | 221 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 225 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 226 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 232 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'updateProductNotifications' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'updateProductNotifications' static/final/abstract/empty, or adding allowed annotation for the method. | 237 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 238 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 238 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 238 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 238 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 238 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 239 |
|
misc | FinalParameters | Parameter customer should be final. | 239 |
|
misc | FinalParameters | Parameter productNotification should be final. | 239 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 242 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 242 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 242 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 242 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 242 |
|
sizes | LineLength | Line is longer than 80 characters (found 140). | 247 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 248 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 248 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 250 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 250 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 251 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 255 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 255 |
|
sizes | LineLength | Line is longer than 80 characters (found 92). | 256 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllCustomers' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'findAllCustomers' static/final/abstract/empty, or adding allowed annotation for the method. | 264 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 268 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 268 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'getNumberOfReviewsForCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'getNumberOfReviewsForCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 278 |
|
misc | FinalParameters | Parameter customer should be final. | 279 |
|
design | DesignForExtension | Class 'CustomerServiceImpl' looks like designed for extension (can be subclassed), but the method 'getCustomerById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerServiceImpl' final or making the method 'getCustomerById' static/final/abstract/empty, or adding allowed annotation for the method. | 283 |
|
misc | FinalParameters | Parameter customerId should be final. | 284 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 14 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 15 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 17 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 18 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 19 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 20 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 21 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 23 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 24 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 25 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 29 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 36 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 43 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 46 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 49 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 50 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 50 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 52 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 55 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 56 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 58 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 59 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 59 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 61 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 62 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 62 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 62 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 64 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 65 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 65 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 65 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 67 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 69 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 71 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 72 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 72 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 72 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 73 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 73 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 75 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 75 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
|
misc | FinalParameters | Parameter id should be final. | 79 |
|
coding | HiddenField | 'id' hides a field. | 79 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 83 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 87 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 87 |
|
misc | FinalParameters | Parameter customer should be final. | 87 |
|
coding | HiddenField | 'customer' hides a field. | 87 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getGender' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 91 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setGender' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
misc | FinalParameters | Parameter gender should be final. | 95 |
|
coding | HiddenField | 'gender' hides a field. | 95 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 103 |
|
misc | FinalParameters | Parameter company should be final. | 103 |
|
coding | HiddenField | 'company' hides a field. | 103 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 107 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 107 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 111 |
|
misc | FinalParameters | Parameter firstname should be final. | 111 |
|
coding | HiddenField | 'firstname' hides a field. | 111 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 115 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 119 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 119 |
|
misc | FinalParameters | Parameter lastname should be final. | 119 |
|
coding | HiddenField | 'lastname' hides a field. | 119 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 123 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 123 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 127 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 127 |
|
misc | FinalParameters | Parameter streetAddress should be final. | 127 |
|
coding | HiddenField | 'streetAddress' hides a field. | 127 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 131 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 131 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 135 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 135 |
|
misc | FinalParameters | Parameter suburb should be final. | 135 |
|
coding | HiddenField | 'suburb' hides a field. | 135 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 139 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 139 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 143 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 143 |
|
misc | FinalParameters | Parameter postcode should be final. | 143 |
|
coding | HiddenField | 'postcode' hides a field. | 143 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getCity' static/final/abstract/empty, or adding allowed annotation for the method. | 147 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 147 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setCity' static/final/abstract/empty, or adding allowed annotation for the method. | 151 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 151 |
|
misc | FinalParameters | Parameter city should be final. | 151 |
|
coding | HiddenField | 'city' hides a field. | 151 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getState' static/final/abstract/empty, or adding allowed annotation for the method. | 155 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 155 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setState' static/final/abstract/empty, or adding allowed annotation for the method. | 159 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 159 |
|
misc | FinalParameters | Parameter state should be final. | 159 |
|
coding | HiddenField | 'state' hides a field. | 159 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 163 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 163 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 167 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 167 |
|
misc | FinalParameters | Parameter country should be final. | 167 |
|
coding | HiddenField | 'country' hides a field. | 167 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 170 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getZoneId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getZoneId' static/final/abstract/empty, or adding allowed annotation for the method. | 171 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 171 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'setZoneId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'setZoneId' static/final/abstract/empty, or adding allowed annotation for the method. | 175 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 175 |
|
misc | FinalParameters | Parameter zoneId should be final. | 175 |
|
coding | HiddenField | 'zoneId' hides a field. | 175 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 179 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 181 |
|
sizes | LineLength | Line is longer than 80 characters (found 94). | 182 |
|
sizes | LineLength | Line is longer than 80 characters (found 95). | 183 |
|
sizes | LineLength | Line is longer than 80 characters (found 93). | 184 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 185 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 188 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'getFormattedAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'getFormattedAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 189 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 189 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 190 |
|
sizes | LineLength | Line is longer than 80 characters (found 120). | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 191 |
|
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 191 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 193 |
|
design | DesignForExtension | Class 'AddressBook' looks like designed for extension (can be subclassed), but the method 'isPrimaryAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressBook' final or making the method 'isPrimaryAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 194 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 194 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 195 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 196 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 196 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 13 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 14 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 15 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 23 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 25 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
coding | MagicNumber | '128' is a magic number. | 26 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
coding | MagicNumber | '48' is a magic number. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
misc | FinalParameters | Parameter id should be final. | 40 |
|
coding | HiddenField | 'id' hides a field. | 40 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'getFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'getFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'setFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'setFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
|
misc | FinalParameters | Parameter format should be final. | 48 |
|
coding | HiddenField | 'format' hides a field. | 48 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'getSummary' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'getSummary' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'setSummary' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'setSummary' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
|
misc | FinalParameters | Parameter summary should be final. | 56 |
|
coding | HiddenField | 'summary' hides a field. | 56 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 64 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 66 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
misc | FinalParameters | Parameter obj should be final. | 71 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 72 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 74 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 76 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 80 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 82 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 85 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 87 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 90 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 92 |
|
design | DesignForExtension | Class 'AddressFormat' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormat' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 97 |
|
sizes | LineLength | Line is longer than 80 characters (found 86). | 99 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 101 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 102 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 17 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 32 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
coding | MagicNumber | '128' is a magic number. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 44 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
coding | MagicNumber | '3' is a magic number. | 48 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
coding | MagicNumber | '3' is a magic number. | 48 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 49 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 49 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 49 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 49 |
|
coding | MagicNumber | '3' is a magic number. | 49 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 49 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
|
misc | FinalParameters | Parameter id should be final. | 62 |
|
coding | HiddenField | 'id' hides a field. | 62 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
misc | FinalParameters | Parameter name should be final. | 70 |
|
coding | HiddenField | 'name' hides a field. | 70 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'getIsoCode2' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'getIsoCode2' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 74 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'setIsoCode2' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'setIsoCode2' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 78 |
|
misc | FinalParameters | Parameter isoCode2 should be final. | 78 |
|
coding | HiddenField | 'isoCode2' hides a field. | 78 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'getIsoCode3' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'getIsoCode3' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 82 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'setIsoCode3' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'setIsoCode3' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 86 |
|
misc | FinalParameters | Parameter isoCode3 should be final. | 86 |
|
coding | HiddenField | 'isoCode3' hides a field. | 86 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'getAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'getAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 90 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'setAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'setAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 94 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 94 |
|
misc | FinalParameters | Parameter addressFormat should be final. | 94 |
|
coding | HiddenField | 'addressFormat' hides a field. | 94 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 98 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 103 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 106 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 108 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 109 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
|
misc | FinalParameters | Parameter obj should be final. | 114 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 115 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 117 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 119 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 123 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 125 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 128 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 130 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 133 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 135 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 138 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 140 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 143 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 145 |
|
design | DesignForExtension | Class 'Country' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Country' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 150 |
|
sizes | LineLength | Line is longer than 80 characters (found 90). | 153 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 156 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 18 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 20 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 22 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 23 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 24 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 26 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 27 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 28 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 29 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 30 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 31 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 32 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 99). | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 37 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 40 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 45 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 45 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 50 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 54 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 55 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 56 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 56 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 60 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 60 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 61 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 62 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 64 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 64 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 68 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 68 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 70 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 71 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 71 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 71 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 74 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 75 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 75 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 77 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 78 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 78 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 78 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'isMale' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'isMale' static/final/abstract/empty, or adding allowed annotation for the method. | 81 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 82 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 85 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'isFemale' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'isFemale' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 90 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 91 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 91 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
misc | FinalParameters | Parameter id should be final. | 95 |
|
coding | HiddenField | 'id' hides a field. | 95 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getGender' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setGender' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 103 |
|
misc | FinalParameters | Parameter gender should be final. | 103 |
|
coding | HiddenField | 'gender' hides a field. | 103 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 107 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 107 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 111 |
|
misc | FinalParameters | Parameter firstname should be final. | 111 |
|
coding | HiddenField | 'firstname' hides a field. | 111 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 115 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 119 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 119 |
|
misc | FinalParameters | Parameter lastname should be final. | 119 |
|
coding | HiddenField | 'lastname' hides a field. | 119 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getDob' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getDob' static/final/abstract/empty, or adding allowed annotation for the method. | 123 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 123 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setDob' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setDob' static/final/abstract/empty, or adding allowed annotation for the method. | 127 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 127 |
|
misc | FinalParameters | Parameter dob should be final. | 127 |
|
coding | HiddenField | 'dob' hides a field. | 127 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getEmailAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getEmailAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 131 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 131 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setEmailAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setEmailAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 135 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 135 |
|
misc | FinalParameters | Parameter emailAddress should be final. | 135 |
|
coding | HiddenField | 'emailAddress' hides a field. | 135 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getDefaultAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getDefaultAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 139 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 139 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setDefaultAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setDefaultAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 143 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 143 |
|
misc | FinalParameters | Parameter defaultAddress should be final. | 143 |
|
coding | HiddenField | 'defaultAddress' hides a field. | 143 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getTelephone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getTelephone' static/final/abstract/empty, or adding allowed annotation for the method. | 147 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 147 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setTelephone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setTelephone' static/final/abstract/empty, or adding allowed annotation for the method. | 151 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 151 |
|
misc | FinalParameters | Parameter telephone should be final. | 151 |
|
coding | HiddenField | 'telephone' hides a field. | 151 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getFax' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getFax' static/final/abstract/empty, or adding allowed annotation for the method. | 155 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 155 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setFax' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setFax' static/final/abstract/empty, or adding allowed annotation for the method. | 159 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 159 |
|
misc | FinalParameters | Parameter fax should be final. | 159 |
|
coding | HiddenField | 'fax' hides a field. | 159 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 163 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 163 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 167 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 167 |
|
misc | FinalParameters | Parameter password should be final. | 167 |
|
coding | HiddenField | 'password' hides a field. | 167 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'getNewsletter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'getNewsletter' static/final/abstract/empty, or adding allowed annotation for the method. | 171 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 171 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'setNewsletter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'setNewsletter' static/final/abstract/empty, or adding allowed annotation for the method. | 175 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 175 |
|
misc | FinalParameters | Parameter newsletter should be final. | 175 |
|
coding | HiddenField | 'newsletter' hides a field. | 175 |
|
whitespace | WhitespaceAround | '?' is not followed by whitespace. | 176 |
|
whitespace | WhitespaceAround | '?' is not preceded with whitespace. | 176 |
|
whitespace | WhitespaceAround | ':' is not followed by whitespace. | 176 |
|
whitespace | WhitespaceAround | ':' is not preceded with whitespace. | 176 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 179 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 181 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 182 |
|
sizes | LineLength | Line is longer than 80 characters (found 112). | 183 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 184 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 187 |
|
sizes | LineLength | Line is longer than 80 characters (found 89). | 192 |
|
design | DesignForExtension | Class 'Customer' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Customer' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 197 |
|
misc | FinalParameters | Parameter obj should be final. | 198 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 199 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 201 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 203 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 207 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 209 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 212 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 214 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 218 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 |
|
javadoc | JavadocStyle | First sentence should end with a period. | 6 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 8 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 9 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 10 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 11 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 12 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 13 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 14 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 15 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 16 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 17 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 18 |
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 19 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 26 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 29 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 29 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 30 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 33 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 33 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 36 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 36 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 37 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 37 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 37 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 40 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 41 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 44 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 44 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 44 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 47 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 47 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 50 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 50 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 51 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 54 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
|
misc | FinalParameters | Parameter id should be final. | 58 |
|
coding | HiddenField | 'id' hides a field. | 58 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'getLastLogin' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'getLastLogin' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'setLastLogin' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'setLastLogin' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
|
misc | FinalParameters | Parameter lastLogin should be final. | 66 |
|
coding | HiddenField | 'lastLogin' hides a field. | 66 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'getNumberOfLogons' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'getNumberOfLogons' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'setNumberOfLogons' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'setNumberOfLogons' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 74 |
|
misc | FinalParameters | Parameter numberOfLogons should be final. | 74 |
|
coding | HiddenField | 'numberOfLogons' hides a field. | 74 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'getAccountCreated' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'getAccountCreated' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 78 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'setAccountCreated' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'setAccountCreated' static/final/abstract/empty, or adding allowed annotation for the method. | 82 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 82 |
|
misc | FinalParameters | Parameter accountCreated should be final. | 82 |
|
coding | HiddenField | 'accountCreated' hides a field. | 82 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'getAccountLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'getAccountLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 86 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'setAccountLastModified' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'setAccountLastModified' static/final/abstract/empty, or adding allowed annotation for the method. | 90 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 90 |
|
misc | FinalParameters | Parameter accountLastModified should be final. | 90 |
|
coding | HiddenField | 'accountLastModified' hides a field. | 90 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'getGlobalProductNotifications' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'getGlobalProductNotifications' static/final/abstract/empty, or adding allowed annotation for the method. | 94 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 94 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 95 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 95 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 95 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 95 |
|
whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 96 |
|
whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 96 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 99 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'setGlobalProductNotifications' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'setGlobalProductNotifications' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 99 |
|
misc | FinalParameters | Parameter globalProductNotifications should be final. | 99 |
|
coding | HiddenField | 'globalProductNotifications' hides a field. | 99 |
|
whitespace | WhitespaceAround | '?' is not followed by whitespace. | 100 |
|
whitespace | WhitespaceAround | '?' is not preceded with whitespace. | 100 |
|
whitespace | WhitespaceAround | ':' is not followed by whitespace. | 100 |
|
whitespace | WhitespaceAround | ':' is not preceded with whitespace. | 100 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'getPasswordResetKey' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'getPasswordResetKey' static/final/abstract/empty, or adding allowed annotation for the method. | 103 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 103 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'setPasswordResetKey' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'setPasswordResetKey' static/final/abstract/empty, or adding allowed annotation for the method. | 107 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 107 |
|
misc | FinalParameters | Parameter passwordResetKey should be final. | 107 |
|
coding | HiddenField | 'passwordResetKey' hides a field. | 107 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'getPasswordResetDate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'getPasswordResetDate' static/final/abstract/empty, or adding allowed annotation for the method. | 111 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 111 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'setPasswordResetDate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'setPasswordResetDate' static/final/abstract/empty, or adding allowed annotation for the method. | 115 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 115 |
|
misc | FinalParameters | Parameter passwordResetDate should be final. | 115 |
|
coding | HiddenField | 'passwordResetDate' hides a field. | 115 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 119 |
|
misc | FinalParameters | Parameter o should be final. | 120 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 121 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 122 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 126 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 131 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 136 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 138 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 139 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 140 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 141 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 142 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 143 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 144 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 145 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 146 |
|
design | DesignForExtension | Class 'CustomerInfo' looks like designed for extension (can be subclassed), but the method 'incNumberOfLogons' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerInfo' final or making the method 'incNumberOfLogons' static/final/abstract/empty, or adding allowed annotation for the method. | 150 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 150 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 151 |
|
whitespace | WhitespaceAround | '==' is not followed by whitespace. | 151 |
|
whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 151 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 151 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 152 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 152 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 10 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
design | VisibilityModifier | Variable 'id' must be private and have accessor methods. | 25 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 28 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 28 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 28 |
|
design | DesignForExtension | Class 'ProductNotification' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotification' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
|
design | DesignForExtension | Class 'ProductNotification' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotification' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 35 |
|
misc | FinalParameters | Parameter id should be final. | 35 |
|
coding | HiddenField | 'id' hides a field. | 35 |
|
design | DesignForExtension | Class 'ProductNotification' looks like designed for extension (can be subclassed), but the method 'getDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotification' final or making the method 'getDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
|
design | DesignForExtension | Class 'ProductNotification' looks like designed for extension (can be subclassed), but the method 'setDateAdded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotification' final or making the method 'setDateAdded' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 43 |
|
misc | FinalParameters | Parameter dateAdded should be final. | 43 |
|
coding | HiddenField | 'dateAdded' hides a field. | 43 |
|
design | DesignForExtension | Class 'ProductNotification' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotification' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
misc | FinalParameters | Parameter o should be final. | 48 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 49 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 50 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 54 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 54 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 55 |
|
design | DesignForExtension | Class 'ProductNotification' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotification' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
coding | MagicNumber | '31' is a magic number. | 63 |
|
design | DesignForExtension | Class 'ProductNotification' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotification' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 69 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 70 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 71 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 22 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 26 |
|
design | DesignForExtension | Class 'ProductNotificationId' looks like designed for extension (can be subclassed), but the method 'getProductId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationId' final or making the method 'getProductId' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
|
design | DesignForExtension | Class 'ProductNotificationId' looks like designed for extension (can be subclassed), but the method 'setProductId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationId' final or making the method 'setProductId' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
|
misc | FinalParameters | Parameter productId should be final. | 33 |
|
coding | HiddenField | 'productId' hides a field. | 33 |
|
design | DesignForExtension | Class 'ProductNotificationId' looks like designed for extension (can be subclassed), but the method 'getCustomerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationId' final or making the method 'getCustomerId' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
|
design | DesignForExtension | Class 'ProductNotificationId' looks like designed for extension (can be subclassed), but the method 'setCustomerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationId' final or making the method 'setCustomerId' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
|
misc | FinalParameters | Parameter customerId should be final. | 41 |
|
coding | HiddenField | 'customerId' hides a field. | 41 |
|
design | DesignForExtension | Class 'ProductNotificationId' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationId' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
|
misc | FinalParameters | Parameter o should be final. | 46 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 47 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 48 |
|
sizes | LineLength | Line is longer than 80 characters (found 109). | 52 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 52 |
|
sizes | LineLength | Line is longer than 80 characters (found 105). | 53 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 53 |
|
design | DesignForExtension | Class 'ProductNotificationId' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationId' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
coding | MagicNumber | '31' is a magic number. | 61 |
|
design | DesignForExtension | Class 'ProductNotificationId' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationId' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 65 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 67 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 68 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 69 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocStyle | First sentence should end with a period. | 14 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 31 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
coding | MagicNumber | '32' is a magic number. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
coding | MagicNumber | '255' is a magic number. | 42 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'getId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'getId' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 46 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'setId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'setId' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 50 |
|
misc | FinalParameters | Parameter id should be final. | 50 |
|
coding | HiddenField | 'id' hides a field. | 50 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'getCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'getCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 54 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'setCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'setCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
|
misc | FinalParameters | Parameter country should be final. | 58 |
|
coding | HiddenField | 'country' hides a field. | 58 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'setName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'setName' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
|
misc | FinalParameters | Parameter name should be final. | 66 |
|
coding | HiddenField | 'name' hides a field. | 66 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'getCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'getCode' static/final/abstract/empty, or adding allowed annotation for the method. | 70 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 70 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'setCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'setCode' static/final/abstract/empty, or adding allowed annotation for the method. | 74 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 74 |
|
misc | FinalParameters | Parameter code should be final. | 74 |
|
coding | HiddenField | 'code' hides a field. | 74 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 80 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
misc | FinalParameters | Parameter o should be final. | 85 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 86 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 87 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 91 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 91 |
|
sizes | LineLength | Line is longer than 80 characters (found 97). | 92 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 92 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 93 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 94 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 94 |
|
design | DesignForExtension | Class 'Zone' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zone' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 99 |
|
coding | MagicNumber | '31' is a magic number. | 102 |
|
coding | MagicNumber | '31' is a magic number. | 103 |
|
coding | MagicNumber | '31' is a magic number. | 104 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 12 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 12 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 12 |
|
coding | MagicNumber | '5' is a magic number. | 12 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 |
|
coding | MagicNumber | '5' is a magic number. | 17 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
coding | MagicNumber | '5' is a magic number. | 22 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'getPasswordCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'getPasswordCurrent' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 27 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 30 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'getPasswordCurrentEncoded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'getPasswordCurrentEncoded' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'setPasswordCurrent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'setPasswordCurrent' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
|
misc | FinalParameters | Parameter passwordCurrent should be final. | 36 |
|
coding | HiddenField | 'passwordCurrent' hides a field. | 36 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'getPasswordNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'getPasswordNew' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 43 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'getPasswordNewEncoded' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'getPasswordNewEncoded' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'setPasswordNew' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'setPasswordNew' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 49 |
|
misc | FinalParameters | Parameter passwordNew should be final. | 49 |
|
coding | HiddenField | 'passwordNew' hides a field. | 49 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'getPasswordConfirmation' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'getPasswordConfirmation' static/final/abstract/empty, or adding allowed annotation for the method. | 53 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 53 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'setPasswordConfirmation' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'setPasswordConfirmation' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 57 |
|
misc | FinalParameters | Parameter passwordConfirmation should be final. | 57 |
|
coding | HiddenField | 'passwordConfirmation' hides a field. | 57 |
|
design | DesignForExtension | Class 'ChangePasswordBean' looks like designed for extension (can be subclassed), but the method 'isConfirmed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangePasswordBean' final or making the method 'isConfirmed' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 64 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 65 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
regexp | RegexpSingleline | Line has trailing spaces. | 15 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 15 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 19 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 20 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 24 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 25 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 25 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 33 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 34 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 34 |
|
coding | MagicNumber | '6' is a magic number. | 34 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 39 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
coding | MagicNumber | '5' is a magic number. | 43 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 50 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 51 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 51 |
|
coding | MagicNumber | '4' is a magic number. | 51 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 55 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 56 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 56 |
|
coding | MagicNumber | '3' is a magic number. | 56 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 60 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 61 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 61 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 65 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 66 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 68 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 69 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 69 |
|
coding | MagicNumber | '3' is a magic number. | 69 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 73 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 75 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 76 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 77 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 77 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 77 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 78 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 79 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 79 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 79 |
|
coding | MagicNumber | '5' is a magic number. | 79 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 83 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 84 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 84 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 84 |
|
coding | MagicNumber | '5' is a magic number. | 84 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 86 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 88 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getGender' static/final/abstract/empty, or adding allowed annotation for the method. | 89 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 89 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setGender' static/final/abstract/empty, or adding allowed annotation for the method. | 92 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 92 |
|
misc | FinalParameters | Parameter gender should be final. | 92 |
|
coding | HiddenField | 'gender' hides a field. | 92 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 95 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 95 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 98 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 98 |
|
misc | FinalParameters | Parameter firstname should be final. | 98 |
|
coding | HiddenField | 'firstname' hides a field. | 98 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 101 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 101 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 104 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 104 |
|
misc | FinalParameters | Parameter lastname should be final. | 104 |
|
coding | HiddenField | 'lastname' hides a field. | 104 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getDob' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getDob' static/final/abstract/empty, or adding allowed annotation for the method. | 107 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 107 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setDob' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setDob' static/final/abstract/empty, or adding allowed annotation for the method. | 110 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 110 |
|
misc | FinalParameters | Parameter dob should be final. | 110 |
|
coding | HiddenField | 'dob' hides a field. | 110 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getEmailAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getEmailAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 113 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setEmailAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setEmailAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 116 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 116 |
|
misc | FinalParameters | Parameter emailAddress should be final. | 116 |
|
coding | HiddenField | 'emailAddress' hides a field. | 116 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 119 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 119 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 122 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 122 |
|
misc | FinalParameters | Parameter company should be final. | 122 |
|
coding | HiddenField | 'company' hides a field. | 122 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 125 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 125 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 128 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 128 |
|
misc | FinalParameters | Parameter streetAddress should be final. | 128 |
|
coding | HiddenField | 'streetAddress' hides a field. | 128 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 131 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 131 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 134 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 134 |
|
misc | FinalParameters | Parameter suburb should be final. | 134 |
|
coding | HiddenField | 'suburb' hides a field. | 134 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 137 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 137 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 140 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 140 |
|
misc | FinalParameters | Parameter postcode should be final. | 140 |
|
coding | HiddenField | 'postcode' hides a field. | 140 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getCity' static/final/abstract/empty, or adding allowed annotation for the method. | 143 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 143 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setCity' static/final/abstract/empty, or adding allowed annotation for the method. | 146 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 146 |
|
misc | FinalParameters | Parameter city should be final. | 146 |
|
coding | HiddenField | 'city' hides a field. | 146 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getState' static/final/abstract/empty, or adding allowed annotation for the method. | 149 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 149 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setState' static/final/abstract/empty, or adding allowed annotation for the method. | 152 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 152 |
|
misc | FinalParameters | Parameter state should be final. | 152 |
|
coding | HiddenField | 'state' hides a field. | 152 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 155 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 155 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 158 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 158 |
|
misc | FinalParameters | Parameter country should be final. | 158 |
|
coding | HiddenField | 'country' hides a field. | 158 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getTelephone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getTelephone' static/final/abstract/empty, or adding allowed annotation for the method. | 161 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 161 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setTelephone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setTelephone' static/final/abstract/empty, or adding allowed annotation for the method. | 164 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 164 |
|
misc | FinalParameters | Parameter telephone should be final. | 164 |
|
coding | HiddenField | 'telephone' hides a field. | 164 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getFax' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getFax' static/final/abstract/empty, or adding allowed annotation for the method. | 167 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 167 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setFax' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setFax' static/final/abstract/empty, or adding allowed annotation for the method. | 170 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 170 |
|
misc | FinalParameters | Parameter fax should be final. | 170 |
|
coding | HiddenField | 'fax' hides a field. | 170 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getNewsletter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getNewsletter' static/final/abstract/empty, or adding allowed annotation for the method. | 173 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 173 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setNewsletter' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setNewsletter' static/final/abstract/empty, or adding allowed annotation for the method. | 176 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 176 |
|
misc | FinalParameters | Parameter newsletter should be final. | 176 |
|
coding | HiddenField | 'newsletter' hides a field. | 176 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 179 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 179 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 182 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 182 |
|
misc | FinalParameters | Parameter password should be final. | 182 |
|
coding | HiddenField | 'password' hides a field. | 182 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'getConfirmation' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'getConfirmation' static/final/abstract/empty, or adding allowed annotation for the method. | 185 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 185 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'setConfirmation' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'setConfirmation' static/final/abstract/empty, or adding allowed annotation for the method. | 188 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 188 |
|
misc | FinalParameters | Parameter confirmation should be final. | 188 |
|
coding | HiddenField | 'confirmation' hides a field. | 188 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 191 |
|
design | DesignForExtension | Class 'CreateNewCustomerFormBean' looks like designed for extension (can be subclassed), but the method 'passwordsMatch' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CreateNewCustomerFormBean' final or making the method 'passwordsMatch' static/final/abstract/empty, or adding allowed annotation for the method. | 192 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 192 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 196 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 13 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 13 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 13 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 29 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 |
|
coding | MagicNumber | '5' is a magic number. | 30 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 34 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 37 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
coding | MagicNumber | '4' is a magic number. | 38 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 42 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 43 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 43 |
|
coding | MagicNumber | '3' is a magic number. | 43 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 48 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 48 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 52 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getGender' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setGender' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setGender' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
|
misc | FinalParameters | Parameter gender should be final. | 60 |
|
coding | HiddenField | 'gender' hides a field. | 60 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 64 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setFirstname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setFirstname' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
|
misc | FinalParameters | Parameter firstname should be final. | 68 |
|
coding | HiddenField | 'firstname' hides a field. | 68 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setLastname' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setLastname' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
|
misc | FinalParameters | Parameter lastname should be final. | 76 |
|
coding | HiddenField | 'lastname' hides a field. | 76 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 80 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 80 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setCompany' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setCompany' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 84 |
|
misc | FinalParameters | Parameter company should be final. | 84 |
|
coding | HiddenField | 'company' hides a field. | 84 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 88 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 88 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setStreetAddress' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setStreetAddress' static/final/abstract/empty, or adding allowed annotation for the method. | 92 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 92 |
|
misc | FinalParameters | Parameter streetAddress should be final. | 92 |
|
coding | HiddenField | 'streetAddress' hides a field. | 92 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 96 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setSuburb' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setSuburb' static/final/abstract/empty, or adding allowed annotation for the method. | 100 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
|
misc | FinalParameters | Parameter suburb should be final. | 100 |
|
coding | HiddenField | 'suburb' hides a field. | 100 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 104 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 104 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setPostcode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setPostcode' static/final/abstract/empty, or adding allowed annotation for the method. | 108 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 108 |
|
misc | FinalParameters | Parameter postcode should be final. | 108 |
|
coding | HiddenField | 'postcode' hides a field. | 108 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getCity' static/final/abstract/empty, or adding allowed annotation for the method. | 112 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 112 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setCity' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setCity' static/final/abstract/empty, or adding allowed annotation for the method. | 116 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 116 |
|
misc | FinalParameters | Parameter city should be final. | 116 |
|
coding | HiddenField | 'city' hides a field. | 116 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getState' static/final/abstract/empty, or adding allowed annotation for the method. | 120 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 120 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setState' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setState' static/final/abstract/empty, or adding allowed annotation for the method. | 124 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 124 |
|
misc | FinalParameters | Parameter state should be final. | 124 |
|
coding | HiddenField | 'state' hides a field. | 124 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'getCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'getCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 128 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 128 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'setCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'setCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 132 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 132 |
|
misc | FinalParameters | Parameter country should be final. | 132 |
|
coding | HiddenField | 'country' hides a field. | 132 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 136 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 140 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 141 |
|
coding | MagicNumber | '32' is a magic number. | 142 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 144 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 145 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 147 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 149 |
|
sizes | LineLength | Line is longer than 80 characters (found 83). | 150 |
|
sizes | LineLength | Line is longer than 80 characters (found 91). | 152 |
|
sizes | LineLength | Line is longer than 80 characters (found 85). | 153 |
|
design | DesignForExtension | Class 'CustomerAddressBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerAddressBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 157 |
|
misc | FinalParameters | Parameter obj should be final. | 158 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 159 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 161 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 163 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 167 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 169 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 172 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 174 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 176 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 179 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 181 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 184 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 186 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 189 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 191 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 194 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 196 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 199 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 201 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 204 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 206 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 209 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 211 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 215 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 216 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
|
design | DesignForExtension | Class 'CustomerBean' looks like designed for extension (can be subclassed), but the method 'getCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerBean' final or making the method 'getCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
design | DesignForExtension | Class 'CustomerBean' looks like designed for extension (can be subclassed), but the method 'setCustomer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerBean' final or making the method 'setCustomer' static/final/abstract/empty, or adding allowed annotation for the method. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
misc | FinalParameters | Parameter customer should be final. | 18 |
|
coding | HiddenField | 'customer' hides a field. | 18 |
|
design | DesignForExtension | Class 'CustomerBean' looks like designed for extension (can be subclassed), but the method 'getCustomerInfo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerBean' final or making the method 'getCustomerInfo' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
design | DesignForExtension | Class 'CustomerBean' looks like designed for extension (can be subclassed), but the method 'setCustomerInfo' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerBean' final or making the method 'setCustomerInfo' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
|
misc | FinalParameters | Parameter customerInfo should be final. | 26 |
|
coding | HiddenField | 'customerInfo' hides a field. | 26 |
|
design | DesignForExtension | Class 'CustomerBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
|
misc | FinalParameters | Parameter o should be final. | 31 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 32 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 33 |
|
sizes | LineLength | Line is longer than 80 characters (found 101). | 37 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 37 |
|
sizes | LineLength | Line is longer than 80 characters (found 117). | 38 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 38 |
|
design | DesignForExtension | Class 'CustomerBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 46 |
|
coding | MagicNumber | '31' is a magic number. | 46 |
|
design | DesignForExtension | Class 'CustomerBean' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CustomerBean' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 52 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 53 |
|
whitespace | OperatorWrap | '+' should be on a new line. | 54 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
|
design | DesignForExtension | Class 'ProductNotificationBean' looks like designed for extension (can be subclassed), but the method 'getProductId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationBean' final or making the method 'getProductId' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
|
design | DesignForExtension | Class 'ProductNotificationBean' looks like designed for extension (can be subclassed), but the method 'setProductId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationBean' final or making the method 'setProductId' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
misc | FinalParameters | Parameter productId should be final. | 15 |
|
coding | HiddenField | 'productId' hides a field. | 15 |
|
design | DesignForExtension | Class 'ProductNotificationBean' looks like designed for extension (can be subclassed), but the method 'getProductName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationBean' final or making the method 'getProductName' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
design | DesignForExtension | Class 'ProductNotificationBean' looks like designed for extension (can be subclassed), but the method 'setProductName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationBean' final or making the method 'setProductName' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
misc | FinalParameters | Parameter productName should be final. | 23 |
|
coding | HiddenField | 'productName' hides a field. | 23 |
|
design | DesignForExtension | Class 'ProductNotificationBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
|
misc | FinalParameters | Parameter o should be final. | 28 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 29 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 30 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 34 |
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 35 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 35 |
|
design | DesignForExtension | Class 'ProductNotificationBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
|
coding | MagicNumber | '32' is a magic number. | 42 |
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 43 |
|
coding | MagicNumber | '31' is a magic number. | 43 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 14 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
misc | FinalParameters | Parameter customer should be final. | 19 |
|
regexp | RegexpSingleline | Line has trailing spaces. | 24 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'getAuthorities' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'getAuthorities' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
sizes | LineLength | Line is longer than 80 characters (found 87). | 27 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'getPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'getPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'getUsername' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'getUsername' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'isAccountNonExpired' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'isAccountNonExpired' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'isAccountNonLocked' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'isAccountNonLocked' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'isCredentialsNonExpired' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'isCredentialsNonExpired' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'isEnabled' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'isEnabled' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 67 |
|
sizes | LineLength | Line is longer than 80 characters (found 81). | 69 |
|
design | DesignForExtension | Class 'UserDetailsBean' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UserDetailsBean' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. | 73 |
|
misc | FinalParameters | Parameter obj should be final. | 74 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 75 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 77 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 79 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 83 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 85 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 88 |
|
blocks | NeedBraces | 'if' construct must use '{}'s. | 90 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 9 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 84). | 6 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 6 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 6 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 82). | 9 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 9 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 6 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 8 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 8 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 88). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
|
design | DesignForExtension | Class 'ProductNotificationDaoImpl' looks like designed for extension (can be subclassed), but the method 'findAllProductNotificationsForCustomerId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProductNotificationDaoImpl' final or making the method 'findAllProductNotificationsForCustomerId' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
|
sizes | LineLength | Line is longer than 80 characters (found 96). | 21 |
|
misc | FinalParameters | Parameter customerId should be final. | 21 |
|
sizes | LineLength | Line is longer than 80 characters (found 114). | 23 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 25 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
sizes | LineLength | Line is longer than 80 characters (found 113). | 10 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 10 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 9 |
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
|
design | DesignForExtension | Class 'AddressFormatServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllAddressFormat' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AddressFormatServiceImpl' final or making the method 'findAllAddressFormat' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
|
design | DesignForExtension | Class 'CountryServiceImpl' looks like designed for extension (can be subclassed), but the method 'createCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryServiceImpl' final or making the method 'createCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 |
|
misc | FinalParameters | Parameter thisCountry should be final. | 27 |
|
design | DesignForExtension | Class 'CountryServiceImpl' looks like designed for extension (can be subclassed), but the method 'updateCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryServiceImpl' final or making the method 'updateCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 |
|
misc | FinalParameters | Parameter thisCountry should be final. | 33 |
|
design | DesignForExtension | Class 'CountryServiceImpl' looks like designed for extension (can be subclassed), but the method 'deleteCountry' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryServiceImpl' final or making the method 'deleteCountry' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 38 |
|
misc | FinalParameters | Parameter thisCountry should be final. | 39 |
|
design | DesignForExtension | Class 'CountryServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllCountriesOrderByName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryServiceImpl' final or making the method 'findAllCountriesOrderByName' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
|
misc | FinalParameters | Parameter pageRequest should be final. | 44 |
|
design | DesignForExtension | Class 'CountryServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAllCountriesOrderByName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryServiceImpl' final or making the method 'findAllCountriesOrderByName' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
|
design | DesignForExtension | Class 'CountryServiceImpl' looks like designed for extension (can be subclassed), but the method 'findCountryById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CountryServiceImpl' final or making the method 'findCountryById' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
|
misc | FinalParameters | Parameter countryId should be final. | 55 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
|
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 |
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
|
design | DesignForExtension | Class 'ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'findAll' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneServiceImpl' final or making the method 'findAll' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
|
misc | FinalParameters | Parameter pageRequest should be final. | 28 |
|
design | DesignForExtension | Class 'ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'getZoneMap' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneServiceImpl' final or making the method 'getZoneMap' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
|
whitespace | WhitespaceAfter | 'for' is not followed by whitespace. | 38 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 38 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 39 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 39 |
|
whitespace | WhitespaceAfter | 'if' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '>' is not followed by whitespace. | 40 |
|
whitespace | WhitespaceAround | '>' is not preceded with whitespace. | 40 |
|
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 40 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 41 |
|
design | DesignForExtension | Class 'ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'createZone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneServiceImpl' final or making the method 'createZone' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 52 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 52 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 52 |
|
misc | FinalParameters | Parameter thisZone should be final. | 53 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 54 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 54 |
|
design | DesignForExtension | Class 'ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'findById' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneServiceImpl' final or making the method 'findById' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
|
misc | FinalParameters | Parameter zoneId should be final. | 58 |
|
design | DesignForExtension | Class 'ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'update' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneServiceImpl' final or making the method 'update' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 63 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 63 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 63 |
|
misc | FinalParameters | Parameter thisZone should be final. | 64 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 65 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 65 |
|
design | DesignForExtension | Class 'ZoneServiceImpl' looks like designed for extension (can be subclassed), but the method 'delete' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZoneServiceImpl' final or making the method 'delete' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 69 |
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 69 |
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 69 |
|
misc | FinalParameters | Parameter thisZone should be final. | 70 |