PMD Results

The following document contains the results of PMD 6.49.0.

Violations By Priority

Priority 3

org/woehlke/greenshop/frontend/CheckoutController.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'customer'. 69

org/woehlke/greenshop/frontend/LoginController.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 15

org/woehlke/greenshop/frontend/SearchController.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'language'. 48

org/woehlke/greenshop/oodm/cart/CartServiceImpl.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'customersBasketAttributeRepository'. 39

org/woehlke/greenshop/oodm/cart/entities/CustomersBasket.java

Rule Violation Line
UnnecessaryConversionTemporary Avoid unnecessary temporaries when converting primitives to Strings 122
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 122

org/woehlke/greenshop/oodm/catalog/CatalogServiceImpl.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'productDescriptionRepositoryDao'. 19
UnusedPrivateField Avoid unused private fields such as 'manufacturerRepository'. 22
UnusedPrivateField Avoid unused private fields such as 'manufacturerInfoRepository'. 25
UnusedPrivateField Avoid unused private fields such as 'manufacturerInfoDao'. 28
UnusedPrivateField Avoid unused private fields such as 'specialRepository'. 46

org/woehlke/greenshop/oodm/checkout/CheckoutServiceImpl.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 41

org/woehlke/greenshop/oodm/checkout/OrderServiceImpl.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 37

org/woehlke/greenshop/oodm/customer/CustomerServiceImpl.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 35
UnusedLocalVariable Avoid unused local variables such as 'zones'. 75

Priority 4

org/woehlke/greenshop/conf/GreenshopWebSecurityConfig.java

Rule Violation Line
UselessParentheses Useless parentheses. 92

org/woehlke/greenshop/oodm/catalog/entities/Category.java

Rule Violation Line
UnnecessaryImport Unused import 'javax.persistence.FetchType' 11

org/woehlke/greenshop/oodm/catalog/entities/Product.java

Rule Violation Line
UnnecessaryImport Unused import 'javax.persistence.FetchType' 10

Files

org/woehlke/greenshop/conf/GreenshopWebSecurityConfig.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 92

org/woehlke/greenshop/frontend/CheckoutController.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'customer'. 3 69

org/woehlke/greenshop/frontend/LoginController.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 15

org/woehlke/greenshop/frontend/SearchController.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'language'. 3 48

org/woehlke/greenshop/oodm/cart/CartServiceImpl.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'customersBasketAttributeRepository'. 3 39

org/woehlke/greenshop/oodm/cart/entities/CustomersBasket.java

Rule Violation Priority Line
UnnecessaryConversionTemporary Avoid unnecessary temporaries when converting primitives to Strings 3 122
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 3 122

org/woehlke/greenshop/oodm/catalog/CatalogServiceImpl.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'productDescriptionRepositoryDao'. 3 19
UnusedPrivateField Avoid unused private fields such as 'manufacturerRepository'. 3 22
UnusedPrivateField Avoid unused private fields such as 'manufacturerInfoRepository'. 3 25
UnusedPrivateField Avoid unused private fields such as 'manufacturerInfoDao'. 3 28
UnusedPrivateField Avoid unused private fields such as 'specialRepository'. 3 46

org/woehlke/greenshop/oodm/catalog/entities/Category.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'javax.persistence.FetchType' 4 11

org/woehlke/greenshop/oodm/catalog/entities/Product.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'javax.persistence.FetchType' 4 10

org/woehlke/greenshop/oodm/checkout/CheckoutServiceImpl.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 41

org/woehlke/greenshop/oodm/checkout/OrderServiceImpl.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 37

org/woehlke/greenshop/oodm/customer/CustomerServiceImpl.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 35
UnusedLocalVariable Avoid unused local variables such as 'zones'. 3 75