The following document contains the results of SpotBugs
SpotBugs Version is 4.7.3
Threshold is medium
Effort is default
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
192 | 320 | 0 | 0 |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.woehlke.greenshop.GreenshopApplication implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | 10-19 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Possible null pointer dereference of thisReview in org.woehlke.greenshop.backend.catalog.ReviewController.reviews(Model) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 43 | Medium |
Possible null pointer dereference of thisReview in org.woehlke.greenshop.backend.catalog.ReviewController.reviewsId(long, Model) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 60 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The parameter thisTaxZone to org.woehlke.greenshop.backend.taxes.TaxZoneController.taxZoneDeletePerform(int, long, TaxZone, BindingResult, Model) is dead upon entry but overwritten | CORRECTNESS | IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN | 146 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class org.woehlke.greenshop.conf.GreenshopProperties defines non-transient non-serializable instance field userConfig | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class org.woehlke.greenshop.conf.GreenshopProperties defines non-transient non-serializable instance field webConfig | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class org.woehlke.greenshop.conf.GreenshopProperties defines non-transient non-serializable instance field webSecurity | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.conf.GreenshopProperties$WebConfig.getWebAddResourceHandlers() may expose internal representation by returning GreenshopProperties$WebConfig.webAddResourceHandlers | MALICIOUS_CODE | EI_EXPOSE_REP | 79 | Medium |
org.woehlke.greenshop.conf.GreenshopProperties$WebConfig.getWebAddResourceHandlersStatic() may expose internal representation by returning GreenshopProperties$WebConfig.webAddResourceHandlersStatic | MALICIOUS_CODE | EI_EXPOSE_REP | 82 | Medium |
org.woehlke.greenshop.conf.GreenshopProperties$WebConfig.setWebAddResourceHandlers(String[]) may expose internal representation by storing an externally mutable object into GreenshopProperties$WebConfig.webAddResourceHandlers | MALICIOUS_CODE | EI_EXPOSE_REP2 | 68 | Medium |
org.woehlke.greenshop.conf.GreenshopProperties$WebConfig.setWebAddResourceHandlersStatic(String[]) may expose internal representation by storing an externally mutable object into GreenshopProperties$WebConfig.webAddResourceHandlersStatic | MALICIOUS_CODE | EI_EXPOSE_REP2 | 68 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.conf.GreenshopProperties$WebSecurity.getAntMatchersPermitAll() may expose internal representation by returning GreenshopProperties$WebSecurity.antMatchersPermitAll | MALICIOUS_CODE | EI_EXPOSE_REP | 117 | Medium |
org.woehlke.greenshop.conf.GreenshopProperties$WebSecurity.setAntMatchersPermitAll(String[]) may expose internal representation by storing an externally mutable object into GreenshopProperties$WebSecurity.antMatchersPermitAll | MALICIOUS_CODE | EI_EXPOSE_REP2 | 88 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.woehlke.greenshop.conf.GreenshopWebMvcConfig(GreenshopProperties) may expose internal representation by storing an externally mutable object into GreenshopWebMvcConfig.greenshopProperties | MALICIOUS_CODE | EI_EXPOSE_REP2 | 39 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.woehlke.greenshop.conf.GreenshopWebSecurityConfig(AuthenticationManagerBuilder, UserDetailsService, GreenshopProperties) may expose internal representation by storing an externally mutable object into GreenshopWebSecurityConfig.authenticationManagerBuilder | MALICIOUS_CODE | EI_EXPOSE_REP2 | 39 | Medium |
new org.woehlke.greenshop.conf.GreenshopWebSecurityConfig(AuthenticationManagerBuilder, UserDetailsService, GreenshopProperties) may expose internal representation by storing an externally mutable object into GreenshopWebSecurityConfig.greenshopProperties | MALICIOUS_CODE | EI_EXPOSE_REP2 | 41 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.frontend.CartController.getOptionsAndValuesFromRequest(HttpServletRequest) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 137 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to customer in org.woehlke.greenshop.frontend.CheckoutController.checkoutPayment(CheckoutBean, TransientBasket, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 69 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to language in org.woehlke.greenshop.frontend.SearchController.showAdvancedSearchForm(String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Confusing to have methods org.woehlke.greenshop.oodm.admin.entities.Administrator.getUserName() and org.woehlke.greenshop.oodm.admin.model.AdministratorBean.getUsername() | BAD_PRACTICE | NM_CONFUSING | 39 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.admin.entities.TaxClass.getDateAdded() may expose internal representation by returning TaxClass.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 74 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxClass.getLastModified() may expose internal representation by returning TaxClass.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 66 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxClass.setDateAdded(Date) may expose internal representation by storing an externally mutable object into TaxClass.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 78 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxClass.setLastModified(Date) may expose internal representation by storing an externally mutable object into TaxClass.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 70 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.admin.entities.TaxRate.getDateAdded() may expose internal representation by returning TaxRate.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 115 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxRate.getLastModified() may expose internal representation by returning TaxRate.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 107 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxRate.getTaxClass() may expose internal representation by returning TaxRate.taxClass | MALICIOUS_CODE | EI_EXPOSE_REP | 75 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxRate.getTaxZone() may expose internal representation by returning TaxRate.taxZone | MALICIOUS_CODE | EI_EXPOSE_REP | 67 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxRate.setDateAdded(Date) may expose internal representation by storing an externally mutable object into TaxRate.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 119 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxRate.setLastModified(Date) may expose internal representation by storing an externally mutable object into TaxRate.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 111 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxRate.setTaxClass(TaxClass) may expose internal representation by storing an externally mutable object into TaxRate.taxClass | MALICIOUS_CODE | EI_EXPOSE_REP2 | 79 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxRate.setTaxZone(TaxZone) may expose internal representation by storing an externally mutable object into TaxRate.taxZone | MALICIOUS_CODE | EI_EXPOSE_REP2 | 71 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.admin.entities.TaxZone.getDateAdded() may expose internal representation by returning TaxZone.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 84 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone.getLastModified() may expose internal representation by returning TaxZone.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 76 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone.setDateAdded(Date) may expose internal representation by storing an externally mutable object into TaxZone.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 88 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone.setLastModified(Date) may expose internal representation by storing an externally mutable object into TaxZone.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 80 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.getDateAdded() may expose internal representation by returning TaxZone2Zone.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 97 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.getLastModified() may expose internal representation by returning TaxZone2Zone.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 89 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.getTaxZone() may expose internal representation by returning TaxZone2Zone.taxZone | MALICIOUS_CODE | EI_EXPOSE_REP | 81 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.getZone() may expose internal representation by returning TaxZone2Zone.zone | MALICIOUS_CODE | EI_EXPOSE_REP | 73 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.getZoneCountry() may expose internal representation by returning TaxZone2Zone.zoneCountry | MALICIOUS_CODE | EI_EXPOSE_REP | 65 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.setDateAdded(Date) may expose internal representation by storing an externally mutable object into TaxZone2Zone.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 101 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.setLastModified(Date) may expose internal representation by storing an externally mutable object into TaxZone2Zone.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 93 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.setTaxZone(TaxZone) may expose internal representation by storing an externally mutable object into TaxZone2Zone.taxZone | MALICIOUS_CODE | EI_EXPOSE_REP2 | 85 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.setZone(Zone) may expose internal representation by storing an externally mutable object into TaxZone2Zone.zone | MALICIOUS_CODE | EI_EXPOSE_REP2 | 77 | Medium |
org.woehlke.greenshop.oodm.admin.entities.TaxZone2Zone.setZoneCountry(Country) may expose internal representation by storing an externally mutable object into TaxZone2Zone.zoneCountry | MALICIOUS_CODE | EI_EXPOSE_REP2 | 69 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.admin.model.OrderAdminBean.getOrderPlaced() may expose internal representation by returning OrderAdminBean.orderPlaced | MALICIOUS_CODE | EI_EXPOSE_REP | 49 | Medium |
org.woehlke.greenshop.oodm.admin.model.OrderAdminBean.getOrderStatus() may expose internal representation by returning OrderAdminBean.orderStatus | MALICIOUS_CODE | EI_EXPOSE_REP | 57 | Medium |
org.woehlke.greenshop.oodm.admin.model.OrderAdminBean.setOrderPlaced(Date) may expose internal representation by storing an externally mutable object into OrderAdminBean.orderPlaced | MALICIOUS_CODE | EI_EXPOSE_REP2 | 53 | Medium |
org.woehlke.greenshop.oodm.admin.model.OrderAdminBean.setOrderStatus(OrderStatus) may expose internal representation by storing an externally mutable object into OrderAdminBean.orderStatus | MALICIOUS_CODE | EI_EXPOSE_REP2 | 61 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to thisAdministrator in org.woehlke.greenshop.oodm.admin.service.AdministratorServiceImpl.create(Administrator) | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
Dead store to thisAdministrator in org.woehlke.greenshop.oodm.admin.service.AdministratorServiceImpl.update(Administrator) | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to thisTaxClass in org.woehlke.greenshop.oodm.admin.service.TaxClassServiceImpl.create(TaxClass) | STYLE | DLS_DEAD_LOCAL_STORE | 44 | Medium |
Dead store to thisTaxClass in org.woehlke.greenshop.oodm.admin.service.TaxClassServiceImpl.update(TaxClass) | STYLE | DLS_DEAD_LOCAL_STORE | 51 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Suspicious comparison of Long references in org.woehlke.greenshop.oodm.cart.CartServiceImpl.getTransientProductFactory(long, Map, Language) | CORRECTNESS | RC_REF_COMPARISON | 97 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Primitive boxed just to call toString in org.woehlke.greenshop.oodm.cart.entities.CustomersBasket.setDateAdded(Date) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 122 | Medium |
org.woehlke.greenshop.oodm.cart.entities.CustomersBasket.setDateAdded(Date) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 122 | Medium |
org.woehlke.greenshop.oodm.cart.entities.CustomersBasket.getCustomer() may expose internal representation by returning CustomersBasket.customer | MALICIOUS_CODE | EI_EXPOSE_REP | 80 | Medium |
org.woehlke.greenshop.oodm.cart.entities.CustomersBasket.setCustomer(Customer) may expose internal representation by storing an externally mutable object into CustomersBasket.customer | MALICIOUS_CODE | EI_EXPOSE_REP2 | 84 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.cart.entities.CustomersBasketAttribute.getCustomer() may expose internal representation by returning CustomersBasketAttribute.customer | MALICIOUS_CODE | EI_EXPOSE_REP | 74 | Medium |
org.woehlke.greenshop.oodm.cart.entities.CustomersBasketAttribute.setCustomer(Customer) may expose internal representation by storing an externally mutable object into CustomersBasketAttribute.customer | MALICIOUS_CODE | EI_EXPOSE_REP2 | 78 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.cart.model.TransientBasket.getNumberOfProducts() may expose internal representation by returning TransientBasket.numberOfProducts | MALICIOUS_CODE | EI_EXPOSE_REP | 77 | Medium |
org.woehlke.greenshop.oodm.cart.model.TransientBasket.getTransientProducts() may expose internal representation by returning TransientBasket.transientProducts | MALICIOUS_CODE | EI_EXPOSE_REP | 69 | Medium |
org.woehlke.greenshop.oodm.cart.model.TransientBasket.setNumberOfProducts(Map) may expose internal representation by storing an externally mutable object into TransientBasket.numberOfProducts | MALICIOUS_CODE | EI_EXPOSE_REP2 | 81 | Medium |
org.woehlke.greenshop.oodm.cart.model.TransientBasket.setTransientProducts(List) may expose internal representation by storing an externally mutable object into TransientBasket.transientProducts | MALICIOUS_CODE | EI_EXPOSE_REP2 | 73 | Medium |
org.woehlke.greenshop.oodm.cart.model.TransientBasket.getSize() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 25 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.cart.model.TransientProduct.getProductDescription() may expose internal representation by returning TransientProduct.productDescription | MALICIOUS_CODE | EI_EXPOSE_REP | 53 | Medium |
org.woehlke.greenshop.oodm.cart.model.TransientProduct.getProductOptionAttributeList() may expose internal representation by returning TransientProduct.productOptionAttributeList | MALICIOUS_CODE | EI_EXPOSE_REP | 59 | Medium |
org.woehlke.greenshop.oodm.cart.model.TransientProduct.setProductDescription(ProductDescription) may expose internal representation by storing an externally mutable object into TransientProduct.productDescription | MALICIOUS_CODE | EI_EXPOSE_REP2 | 56 | Medium |
org.woehlke.greenshop.oodm.cart.model.TransientProduct.setProductOptionAttributeList(List) may expose internal representation by storing an externally mutable object into TransientProduct.productOptionAttributeList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 63 | Medium |
TransientProduct.productDescription not initialized in constructor and dereferenced in org.woehlke.greenshop.oodm.cart.model.TransientProduct.getPrice() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 15 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.Category.getDateAdded() may expose internal representation by returning Category.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 83 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Category.getLastModified() may expose internal representation by returning Category.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 91 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Category.getProducts() may expose internal representation by returning Category.products | MALICIOUS_CODE | EI_EXPOSE_REP | 99 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Category.setDateAdded(Date) may expose internal representation by storing an externally mutable object into Category.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 87 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Category.setLastModified(Date) may expose internal representation by storing an externally mutable object into Category.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 95 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Category.setProducts(List) may expose internal representation by storing an externally mutable object into Category.products | MALICIOUS_CODE | EI_EXPOSE_REP2 | 103 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.CategoryDescription.getCategory() may expose internal representation by returning CategoryDescription.category | MALICIOUS_CODE | EI_EXPOSE_REP | 30 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.CategoryDescription.getLanguage() may expose internal representation by returning CategoryDescription.language | MALICIOUS_CODE | EI_EXPOSE_REP | 38 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.CategoryDescription.setCategory(Category) may expose internal representation by storing an externally mutable object into CategoryDescription.category | MALICIOUS_CODE | EI_EXPOSE_REP2 | 34 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.CategoryDescription.setLanguage(Language) may expose internal representation by storing an externally mutable object into CategoryDescription.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 42 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.CategoryDescriptionId.getCategory() may expose internal representation by returning CategoryDescriptionId.category | MALICIOUS_CODE | EI_EXPOSE_REP | 12 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.CategoryDescriptionId.getLanguage() may expose internal representation by returning CategoryDescriptionId.language | MALICIOUS_CODE | EI_EXPOSE_REP | 18 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.CategoryDescriptionId.setCategory(Category) may expose internal representation by storing an externally mutable object into CategoryDescriptionId.category | MALICIOUS_CODE | EI_EXPOSE_REP2 | 15 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.CategoryDescriptionId.setLanguage(Language) may expose internal representation by storing an externally mutable object into CategoryDescriptionId.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 21 | Medium |
Class org.woehlke.greenshop.oodm.catalog.entities.CategoryDescriptionId defines non-transient non-serializable instance field category | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class org.woehlke.greenshop.oodm.catalog.entities.CategoryDescriptionId defines non-transient non-serializable instance field language | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.Manufacturer.getDateAdded() may expose internal representation by returning Manufacturer.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 122 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Manufacturer.getLastModified() may expose internal representation by returning Manufacturer.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 130 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Manufacturer.setDateAdded(Date) may expose internal representation by storing an externally mutable object into Manufacturer.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 126 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Manufacturer.setLastModified(Date) may expose internal representation by storing an externally mutable object into Manufacturer.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 134 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfo.getLanguage() may expose internal representation by returning ManufacturerInfo.language | MALICIOUS_CODE | EI_EXPOSE_REP | 54 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfo.getLastclick() may expose internal representation by returning ManufacturerInfo.lastclick | MALICIOUS_CODE | EI_EXPOSE_REP | 78 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfo.getManufacturer() may expose internal representation by returning ManufacturerInfo.manufacturer | MALICIOUS_CODE | EI_EXPOSE_REP | 46 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfo.setLanguage(Language) may expose internal representation by storing an externally mutable object into ManufacturerInfo.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 58 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfo.setLastclick(Date) may expose internal representation by storing an externally mutable object into ManufacturerInfo.lastclick | MALICIOUS_CODE | EI_EXPOSE_REP2 | 82 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfo.setManufacturer(Manufacturer) may expose internal representation by storing an externally mutable object into ManufacturerInfo.manufacturer | MALICIOUS_CODE | EI_EXPOSE_REP2 | 50 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfoId.getLanguage() may expose internal representation by returning ManufacturerInfoId.language | MALICIOUS_CODE | EI_EXPOSE_REP | 25 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfoId.getManufacturer() may expose internal representation by returning ManufacturerInfoId.manufacturer | MALICIOUS_CODE | EI_EXPOSE_REP | 17 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfoId.setLanguage(Language) may expose internal representation by storing an externally mutable object into ManufacturerInfoId.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 29 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfoId.setManufacturer(Manufacturer) may expose internal representation by storing an externally mutable object into ManufacturerInfoId.manufacturer | MALICIOUS_CODE | EI_EXPOSE_REP2 | 21 | Medium |
Class org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfoId defines non-transient non-serializable instance field language | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class org.woehlke.greenshop.oodm.catalog.entities.ManufacturerInfoId defines non-transient non-serializable instance field manufacturer | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.Product.getCategories() may expose internal representation by returning Product.categories | MALICIOUS_CODE | EI_EXPOSE_REP | 189 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.getDateAdded() may expose internal representation by returning Product.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 125 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.getDateAvailable() may expose internal representation by returning Product.dateAvailable | MALICIOUS_CODE | EI_EXPOSE_REP | 141 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.getLastModified() may expose internal representation by returning Product.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 133 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.getManufacturer() may expose internal representation by returning Product.manufacturer | MALICIOUS_CODE | EI_EXPOSE_REP | 173 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.setCategories(List) may expose internal representation by storing an externally mutable object into Product.categories | MALICIOUS_CODE | EI_EXPOSE_REP2 | 193 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.setDateAdded(Date) may expose internal representation by storing an externally mutable object into Product.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 129 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.setDateAvailable(Date) may expose internal representation by storing an externally mutable object into Product.dateAvailable | MALICIOUS_CODE | EI_EXPOSE_REP2 | 145 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.setLastModified(Date) may expose internal representation by storing an externally mutable object into Product.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 137 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Product.setManufacturer(Manufacturer) may expose internal representation by storing an externally mutable object into Product.manufacturer | MALICIOUS_CODE | EI_EXPOSE_REP2 | 177 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ProductAttribute.getProduct() may expose internal representation by returning ProductAttribute.product | MALICIOUS_CODE | EI_EXPOSE_REP | 50 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductAttribute.setProduct(Product) may expose internal representation by storing an externally mutable object into ProductAttribute.product | MALICIOUS_CODE | EI_EXPOSE_REP2 | 54 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ProductDescription.getLanguage() may expose internal representation by returning ProductDescription.language | MALICIOUS_CODE | EI_EXPOSE_REP | 49 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductDescription.getProduct() may expose internal representation by returning ProductDescription.product | MALICIOUS_CODE | EI_EXPOSE_REP | 41 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductDescription.setLanguage(Language) may expose internal representation by storing an externally mutable object into ProductDescription.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 53 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductDescription.setProduct(Product) may expose internal representation by storing an externally mutable object into ProductDescription.product | MALICIOUS_CODE | EI_EXPOSE_REP2 | 45 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ProductDescriptionId.getLanguage() may expose internal representation by returning ProductDescriptionId.language | MALICIOUS_CODE | EI_EXPOSE_REP | 24 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductDescriptionId.getProduct() may expose internal representation by returning ProductDescriptionId.product | MALICIOUS_CODE | EI_EXPOSE_REP | 16 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductDescriptionId.setLanguage(Language) may expose internal representation by storing an externally mutable object into ProductDescriptionId.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 28 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductDescriptionId.setProduct(Product) may expose internal representation by storing an externally mutable object into ProductDescriptionId.product | MALICIOUS_CODE | EI_EXPOSE_REP2 | 20 | Medium |
Class org.woehlke.greenshop.oodm.catalog.entities.ProductDescriptionId defines non-transient non-serializable instance field language | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class org.woehlke.greenshop.oodm.catalog.entities.ProductDescriptionId defines non-transient non-serializable instance field product | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ProductImage.getProduct() may expose internal representation by returning ProductImage.product | MALICIOUS_CODE | EI_EXPOSE_REP | 48 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductImage.setProduct(Product) may expose internal representation by storing an externally mutable object into ProductImage.product | MALICIOUS_CODE | EI_EXPOSE_REP2 | 52 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ProductOption.getLanguage() may expose internal representation by returning ProductOption.language | MALICIOUS_CODE | EI_EXPOSE_REP | 44 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductOption.setLanguage(Language) may expose internal representation by storing an externally mutable object into ProductOption.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 48 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ProductOptionId.getLanguage() may expose internal representation by returning ProductOptionId.language | MALICIOUS_CODE | EI_EXPOSE_REP | 23 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductOptionId.setLanguage(Language) may expose internal representation by storing an externally mutable object into ProductOptionId.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 27 | Medium |
Class org.woehlke.greenshop.oodm.catalog.entities.ProductOptionId defines non-transient non-serializable instance field language | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ProductOptionValue.getLanguage() may expose internal representation by returning ProductOptionValue.language | MALICIOUS_CODE | EI_EXPOSE_REP | 45 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductOptionValue.setLanguage(Language) may expose internal representation by storing an externally mutable object into ProductOptionValue.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 49 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ProductOptionValueId.getLanguage() may expose internal representation by returning ProductOptionValueId.language | MALICIOUS_CODE | EI_EXPOSE_REP | 17 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ProductOptionValueId.setLanguage(Language) may expose internal representation by storing an externally mutable object into ProductOptionValueId.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 20 | Medium |
Class org.woehlke.greenshop.oodm.catalog.entities.ProductOptionValueId defines non-transient non-serializable instance field language | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.Review.getDateAdded() may expose internal representation by returning Review.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 103 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Review.getLastModified() may expose internal representation by returning Review.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 111 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Review.getProduct() may expose internal representation by returning Review.product | MALICIOUS_CODE | EI_EXPOSE_REP | 71 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Review.setDateAdded(Date) may expose internal representation by storing an externally mutable object into Review.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 107 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Review.setLastModified(Date) may expose internal representation by storing an externally mutable object into Review.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 115 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Review.setProduct(Product) may expose internal representation by storing an externally mutable object into Review.product | MALICIOUS_CODE | EI_EXPOSE_REP2 | 75 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescription.getLanguage() may expose internal representation by returning ReviewDescription.language | MALICIOUS_CODE | EI_EXPOSE_REP | 54 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescription.getReview() may expose internal representation by returning ReviewDescription.review | MALICIOUS_CODE | EI_EXPOSE_REP | 46 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescription.setLanguage(Language) may expose internal representation by storing an externally mutable object into ReviewDescription.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 58 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescription.setReview(Review) may expose internal representation by storing an externally mutable object into ReviewDescription.review | MALICIOUS_CODE | EI_EXPOSE_REP2 | 50 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescriptionId.getLanguage() may expose internal representation by returning ReviewDescriptionId.language | MALICIOUS_CODE | EI_EXPOSE_REP | 23 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescriptionId.getReview() may expose internal representation by returning ReviewDescriptionId.review | MALICIOUS_CODE | EI_EXPOSE_REP | 15 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescriptionId.setLanguage(Language) may expose internal representation by storing an externally mutable object into ReviewDescriptionId.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 27 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescriptionId.setReview(Review) may expose internal representation by storing an externally mutable object into ReviewDescriptionId.review | MALICIOUS_CODE | EI_EXPOSE_REP2 | 19 | Medium |
Class org.woehlke.greenshop.oodm.catalog.entities.ReviewDescriptionId defines non-transient non-serializable instance field language | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Class org.woehlke.greenshop.oodm.catalog.entities.ReviewDescriptionId defines non-transient non-serializable instance field review | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
org.woehlke.greenshop.oodm.catalog.entities.ReviewDescriptionId is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 8-52 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.entities.Special.getAdded() may expose internal representation by returning Special.added | MALICIOUS_CODE | EI_EXPOSE_REP | 82 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.getExpires() may expose internal representation by returning Special.expires | MALICIOUS_CODE | EI_EXPOSE_REP | 98 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.getLastModified() may expose internal representation by returning Special.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 90 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.getProduct() may expose internal representation by returning Special.product | MALICIOUS_CODE | EI_EXPOSE_REP | 66 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.getStatusChanged() may expose internal representation by returning Special.statusChanged | MALICIOUS_CODE | EI_EXPOSE_REP | 106 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.setAdded(Date) may expose internal representation by storing an externally mutable object into Special.added | MALICIOUS_CODE | EI_EXPOSE_REP2 | 86 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.setExpires(Date) may expose internal representation by storing an externally mutable object into Special.expires | MALICIOUS_CODE | EI_EXPOSE_REP2 | 102 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.setLastModified(Date) may expose internal representation by storing an externally mutable object into Special.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 94 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.setProduct(Product) may expose internal representation by storing an externally mutable object into Special.product | MALICIOUS_CODE | EI_EXPOSE_REP2 | 70 | Medium |
org.woehlke.greenshop.oodm.catalog.entities.Special.setStatusChanged(Date) may expose internal representation by storing an externally mutable object into Special.statusChanged | MALICIOUS_CODE | EI_EXPOSE_REP2 | 110 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.CategoriesBean.getCategories() may expose internal representation by returning CategoriesBean.categories | MALICIOUS_CODE | EI_EXPOSE_REP | 18 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoriesBean.getCategory2level() may expose internal representation by returning CategoriesBean.category2level | MALICIOUS_CODE | EI_EXPOSE_REP | 26 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoriesBean.setCategories(List) may expose internal representation by storing an externally mutable object into CategoriesBean.categories | MALICIOUS_CODE | EI_EXPOSE_REP2 | 22 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoriesBean.setCategory2level(Map) may expose internal representation by storing an externally mutable object into CategoriesBean.category2level | MALICIOUS_CODE | EI_EXPOSE_REP2 | 30 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getBreadcrumb() may expose internal representation by returning CategoryTree.breadcrumb | MALICIOUS_CODE | EI_EXPOSE_REP | 98 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getCategoriesMenuList() may expose internal representation by returning CategoryTree.categoriesMenuList | MALICIOUS_CODE | EI_EXPOSE_REP | 58 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getCategoryIdToNumberOfProducts() may expose internal representation by returning CategoryTree.categoryIdToNumberOfProducts | MALICIOUS_CODE | EI_EXPOSE_REP | 82 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getHasChildrenMap() may expose internal representation by returning CategoryTree.hasChildrenMap | MALICIOUS_CODE | EI_EXPOSE_REP | 90 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getThisCategory() may expose internal representation by returning CategoryTree.thisCategory | MALICIOUS_CODE | EI_EXPOSE_REP | 66 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getThisLevelCategories() may expose internal representation by returning CategoryTree.categoriesMenuList | MALICIOUS_CODE | EI_EXPOSE_REP | 20 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.setBreadcrumb(List) may expose internal representation by storing an externally mutable object into CategoryTree.breadcrumb | MALICIOUS_CODE | EI_EXPOSE_REP2 | 102 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.setCategoriesMenuList(List) may expose internal representation by storing an externally mutable object into CategoryTree.categoriesMenuList | MALICIOUS_CODE | EI_EXPOSE_REP2 | 62 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.setCategoryIdToNumberOfProducts(Map) may expose internal representation by storing an externally mutable object into CategoryTree.categoryIdToNumberOfProducts | MALICIOUS_CODE | EI_EXPOSE_REP2 | 86 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.setHasChildrenMap(Map) may expose internal representation by storing an externally mutable object into CategoryTree.hasChildrenMap | MALICIOUS_CODE | EI_EXPOSE_REP2 | 94 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTree.setThisCategory(CategoryDescription) may expose internal representation by storing an externally mutable object into CategoryTree.thisCategory | MALICIOUS_CODE | EI_EXPOSE_REP2 | 70 | Medium |
CategoryTree.categoriesMenuList not initialized in constructor and dereferenced in org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getChildren() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 34 | Low |
CategoryTree.categoriesMenuList not initialized in constructor and dereferenced in org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getThisLevelCategories() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 23 | Low |
CategoryTree.thisCategory not initialized in constructor and dereferenced in org.woehlke.greenshop.oodm.catalog.model.CategoryTree.getThisLevelCategories() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 24 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.CategoryTreeNode.getCategoryDescription() may expose internal representation by returning CategoryTreeNode.categoryDescription | MALICIOUS_CODE | EI_EXPOSE_REP | 12 | Medium |
org.woehlke.greenshop.oodm.catalog.model.CategoryTreeNode.setCategoryDescription(CategoryDescription) may expose internal representation by storing an externally mutable object into CategoryTreeNode.categoryDescription | MALICIOUS_CODE | EI_EXPOSE_REP2 | 15 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.Manufacturers.getManufacturers() may expose internal representation by returning Manufacturers.manufacturers | MALICIOUS_CODE | EI_EXPOSE_REP | 13 | Medium |
org.woehlke.greenshop.oodm.catalog.model.Manufacturers.setManufacturers(List) may expose internal representation by storing an externally mutable object into Manufacturers.manufacturers | MALICIOUS_CODE | EI_EXPOSE_REP2 | 16 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.ProductAttributes.getMapProductOptionAttribute() may expose internal representation by returning ProductAttributes.mapProductOptionAttribute | MALICIOUS_CODE | EI_EXPOSE_REP | 19 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductAttributes.getProductDescription() may expose internal representation by returning ProductAttributes.productDescription | MALICIOUS_CODE | EI_EXPOSE_REP | 13 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductAttributes.setMapProductOptionAttribute(Map) may expose internal representation by storing an externally mutable object into ProductAttributes.mapProductOptionAttribute | MALICIOUS_CODE | EI_EXPOSE_REP2 | 23 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductAttributes.setProductDescription(ProductDescription) may expose internal representation by storing an externally mutable object into ProductAttributes.productDescription | MALICIOUS_CODE | EI_EXPOSE_REP2 | 16 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.ProductOptionAttribute.getProductAttribute() may expose internal representation by returning ProductOptionAttribute.productAttribute | MALICIOUS_CODE | EI_EXPOSE_REP | 14 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductOptionAttribute.getProductOption() may expose internal representation by returning ProductOptionAttribute.productOption | MALICIOUS_CODE | EI_EXPOSE_REP | 20 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductOptionAttribute.getProductOptionValue() may expose internal representation by returning ProductOptionAttribute.productOptionValue | MALICIOUS_CODE | EI_EXPOSE_REP | 26 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductOptionAttribute.setProductAttribute(ProductAttribute) may expose internal representation by storing an externally mutable object into ProductOptionAttribute.productAttribute | MALICIOUS_CODE | EI_EXPOSE_REP2 | 17 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductOptionAttribute.setProductOption(ProductOption) may expose internal representation by storing an externally mutable object into ProductOptionAttribute.productOption | MALICIOUS_CODE | EI_EXPOSE_REP2 | 23 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductOptionAttribute.setProductOptionValue(ProductOptionValue) may expose internal representation by storing an externally mutable object into ProductOptionAttribute.productOptionValue | MALICIOUS_CODE | EI_EXPOSE_REP2 | 29 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.ProductsByCategory.getChildCategories() may expose internal representation by returning ProductsByCategory.childCategories | MALICIOUS_CODE | EI_EXPOSE_REP | 33 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByCategory.getManufacturers() may expose internal representation by returning ProductsByCategory.manufacturers | MALICIOUS_CODE | EI_EXPOSE_REP | 41 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByCategory.getProducts() may expose internal representation by returning ProductsByCategory.products | MALICIOUS_CODE | EI_EXPOSE_REP | 17 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByCategory.getThisCategory() may expose internal representation by returning ProductsByCategory.thisCategory | MALICIOUS_CODE | EI_EXPOSE_REP | 25 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByCategory.setChildCategories(List) may expose internal representation by storing an externally mutable object into ProductsByCategory.childCategories | MALICIOUS_CODE | EI_EXPOSE_REP2 | 37 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByCategory.setManufacturers(List) may expose internal representation by storing an externally mutable object into ProductsByCategory.manufacturers | MALICIOUS_CODE | EI_EXPOSE_REP2 | 45 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByCategory.setProducts(List) may expose internal representation by storing an externally mutable object into ProductsByCategory.products | MALICIOUS_CODE | EI_EXPOSE_REP2 | 21 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByCategory.setThisCategory(CategoryDescription) may expose internal representation by storing an externally mutable object into ProductsByCategory.thisCategory | MALICIOUS_CODE | EI_EXPOSE_REP2 | 29 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.ProductsByManufacturer.getCategoriesOfProducts() may expose internal representation by returning ProductsByManufacturer.categoriesOfProducts | MALICIOUS_CODE | EI_EXPOSE_REP | 22 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByManufacturer.getProducts() may expose internal representation by returning ProductsByManufacturer.products | MALICIOUS_CODE | EI_EXPOSE_REP | 14 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByManufacturer.setCategoriesOfProducts(List) may expose internal representation by storing an externally mutable object into ProductsByManufacturer.categoriesOfProducts | MALICIOUS_CODE | EI_EXPOSE_REP2 | 27 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ProductsByManufacturer.setProducts(List) may expose internal representation by storing an externally mutable object into ProductsByManufacturer.products | MALICIOUS_CODE | EI_EXPOSE_REP2 | 18 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.ReviewProduct.getProduct() may expose internal representation by returning ReviewProduct.product | MALICIOUS_CODE | EI_EXPOSE_REP | 23 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ReviewProduct.getReview() may expose internal representation by returning ReviewProduct.review | MALICIOUS_CODE | EI_EXPOSE_REP | 15 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ReviewProduct.setProduct(ProductDescription) may expose internal representation by storing an externally mutable object into ReviewProduct.product | MALICIOUS_CODE | EI_EXPOSE_REP2 | 27 | Medium |
org.woehlke.greenshop.oodm.catalog.model.ReviewProduct.setReview(ReviewDescription) may expose internal representation by storing an externally mutable object into ReviewProduct.review | MALICIOUS_CODE | EI_EXPOSE_REP2 | 19 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.model.SpecialProduct.getProductDescription() may expose internal representation by returning SpecialProduct.productDescription | MALICIOUS_CODE | EI_EXPOSE_REP | 34 | Medium |
org.woehlke.greenshop.oodm.catalog.model.SpecialProduct.getSpecial() may expose internal representation by returning SpecialProduct.special | MALICIOUS_CODE | EI_EXPOSE_REP | 26 | Medium |
org.woehlke.greenshop.oodm.catalog.model.SpecialProduct.setProductDescription(ProductDescription) may expose internal representation by storing an externally mutable object into SpecialProduct.productDescription | MALICIOUS_CODE | EI_EXPOSE_REP2 | 38 | Medium |
org.woehlke.greenshop.oodm.catalog.model.SpecialProduct.setSpecial(Special) may expose internal representation by storing an externally mutable object into SpecialProduct.special | MALICIOUS_CODE | EI_EXPOSE_REP2 | 30 | Medium |
SpecialProduct.productDescription not initialized in constructor and dereferenced in org.woehlke.greenshop.oodm.catalog.model.SpecialProduct.getPercentage() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 19 | Low |
SpecialProduct.special not initialized in constructor and dereferenced in org.woehlke.greenshop.oodm.catalog.model.SpecialProduct.getPercentage() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 20 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.catalog.service.CategoryServiceImpl.getNumberOfProductsPerCategory(CategoryTree) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 178 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Random object created and used only once in org.woehlke.greenshop.oodm.catalog.service.ProductServiceImpl.getRandomNewProduct(Language) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 119 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to review in org.woehlke.greenshop.oodm.catalog.service.ReviewServiceImpl.update(Review) | STYLE | DLS_DEAD_LOCAL_STORE | 80 | Medium |
Random object created and used only once in org.woehlke.greenshop.oodm.catalog.service.ReviewServiceImpl.getRandomReview(Language) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 127 | High |
Possible null pointer dereference of customer in org.woehlke.greenshop.oodm.catalog.service.ReviewServiceImpl.saveReview(WriteReviewBean, Product, Customer, Language) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 98 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Random object created and used only once in org.woehlke.greenshop.oodm.catalog.service.SpecialServiceImpl.getRandomSpecial(Language) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 54 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.entities.Order.getBillingAddressFormat() may expose internal representation by returning Order.billingAddressFormat | MALICIOUS_CODE | EI_EXPOSE_REP | 498 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.getCustomer() may expose internal representation by returning Order.customer | MALICIOUS_CODE | EI_EXPOSE_REP | 266 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.getCustomersAddressFormat() may expose internal representation by returning Order.customersAddressFormat | MALICIOUS_CODE | EI_EXPOSE_REP | 354 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.getDatePurchased() may expose internal representation by returning Order.datePurchased | MALICIOUS_CODE | EI_EXPOSE_REP | 554 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.getDeliveryAddressFormat() may expose internal representation by returning Order.deliveryAddressFormat | MALICIOUS_CODE | EI_EXPOSE_REP | 426 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.getLastModified() may expose internal representation by returning Order.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 546 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.getOrdersDateFinished() may expose internal representation by returning Order.ordersDateFinished | MALICIOUS_CODE | EI_EXPOSE_REP | 570 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.setBillingAddressFormat(AddressFormat) may expose internal representation by storing an externally mutable object into Order.billingAddressFormat | MALICIOUS_CODE | EI_EXPOSE_REP2 | 502 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.setCustomer(Customer) may expose internal representation by storing an externally mutable object into Order.customer | MALICIOUS_CODE | EI_EXPOSE_REP2 | 270 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.setCustomersAddressFormat(AddressFormat) may expose internal representation by storing an externally mutable object into Order.customersAddressFormat | MALICIOUS_CODE | EI_EXPOSE_REP2 | 358 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.setDatePurchased(Date) may expose internal representation by storing an externally mutable object into Order.datePurchased | MALICIOUS_CODE | EI_EXPOSE_REP2 | 558 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.setDeliveryAddressFormat(AddressFormat) may expose internal representation by storing an externally mutable object into Order.deliveryAddressFormat | MALICIOUS_CODE | EI_EXPOSE_REP2 | 430 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.setLastModified(Date) may expose internal representation by storing an externally mutable object into Order.lastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 550 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.Order.setOrdersDateFinished(Date) may expose internal representation by storing an externally mutable object into Order.ordersDateFinished | MALICIOUS_CODE | EI_EXPOSE_REP2 | 574 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.entities.OrderProduct.getOrder() may expose internal representation by returning OrderProduct.order | MALICIOUS_CODE | EI_EXPOSE_REP | 88 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderProduct.getOrderProductAttribute() may expose internal representation by returning OrderProduct.orderProductAttribute | MALICIOUS_CODE | EI_EXPOSE_REP | 149 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderProduct.getProduct() may expose internal representation by returning OrderProduct.product | MALICIOUS_CODE | EI_EXPOSE_REP | 96 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderProduct.setOrder(Order) may expose internal representation by storing an externally mutable object into OrderProduct.order | MALICIOUS_CODE | EI_EXPOSE_REP2 | 92 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderProduct.setOrderProductAttribute(List) may expose internal representation by storing an externally mutable object into OrderProduct.orderProductAttribute | MALICIOUS_CODE | EI_EXPOSE_REP2 | 153 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderProduct.setProduct(Product) may expose internal representation by storing an externally mutable object into OrderProduct.product | MALICIOUS_CODE | EI_EXPOSE_REP2 | 100 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.entities.OrderProductAttribute.getOrder() may expose internal representation by returning OrderProductAttribute.order | MALICIOUS_CODE | EI_EXPOSE_REP | 69 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderProductAttribute.getOrderProduct() may expose internal representation by returning OrderProductAttribute.orderProduct | MALICIOUS_CODE | EI_EXPOSE_REP | 77 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderProductAttribute.setOrder(Order) may expose internal representation by storing an externally mutable object into OrderProductAttribute.order | MALICIOUS_CODE | EI_EXPOSE_REP2 | 73 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderProductAttribute.setOrderProduct(OrderProduct) may expose internal representation by storing an externally mutable object into OrderProductAttribute.orderProduct | MALICIOUS_CODE | EI_EXPOSE_REP2 | 81 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.entities.OrderStatus.getLanguage() may expose internal representation by returning OrderStatus.language | MALICIOUS_CODE | EI_EXPOSE_REP | 72 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderStatus.setLanguage(Language) may expose internal representation by storing an externally mutable object into OrderStatus.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 76 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.entities.OrderStatusHistory.getDateAdded() may expose internal representation by returning OrderStatusHistory.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 96 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderStatusHistory.getOrder() may expose internal representation by returning OrderStatusHistory.order | MALICIOUS_CODE | EI_EXPOSE_REP | 80 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderStatusHistory.setDateAdded(Date) may expose internal representation by storing an externally mutable object into OrderStatusHistory.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 100 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderStatusHistory.setOrder(Order) may expose internal representation by storing an externally mutable object into OrderStatusHistory.order | MALICIOUS_CODE | EI_EXPOSE_REP2 | 84 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.entities.OrderStatusId.getLanguage() may expose internal representation by returning OrderStatusId.language | MALICIOUS_CODE | EI_EXPOSE_REP | 22 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderStatusId.setLanguage(Language) may expose internal representation by storing an externally mutable object into OrderStatusId.language | MALICIOUS_CODE | EI_EXPOSE_REP2 | 25 | Medium |
Class org.woehlke.greenshop.oodm.checkout.entities.OrderStatusId defines non-transient non-serializable instance field language | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.entities.OrderTotal.getOrder() may expose internal representation by returning OrderTotal.order | MALICIOUS_CODE | EI_EXPOSE_REP | 85 | Medium |
org.woehlke.greenshop.oodm.checkout.entities.OrderTotal.setOrder(Order) may expose internal representation by storing an externally mutable object into OrderTotal.order | MALICIOUS_CODE | EI_EXPOSE_REP2 | 89 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.model.CheckoutBean.getCustomersAddress() may expose internal representation by returning CheckoutBean.customersAddress | MALICIOUS_CODE | EI_EXPOSE_REP | 9 | Medium |
org.woehlke.greenshop.oodm.checkout.model.CheckoutBean.getPaymentAddress() may expose internal representation by returning CheckoutBean.paymentAddress | MALICIOUS_CODE | EI_EXPOSE_REP | 21 | Medium |
org.woehlke.greenshop.oodm.checkout.model.CheckoutBean.getShippingAddress() may expose internal representation by returning CheckoutBean.shippingAddress | MALICIOUS_CODE | EI_EXPOSE_REP | 15 | Medium |
org.woehlke.greenshop.oodm.checkout.model.CheckoutBean.setCustomersAddress(AddressBean) may expose internal representation by storing an externally mutable object into CheckoutBean.customersAddress | MALICIOUS_CODE | EI_EXPOSE_REP2 | 12 | Medium |
org.woehlke.greenshop.oodm.checkout.model.CheckoutBean.setPaymentAddress(AddressBean) may expose internal representation by storing an externally mutable object into CheckoutBean.paymentAddress | MALICIOUS_CODE | EI_EXPOSE_REP2 | 24 | Medium |
org.woehlke.greenshop.oodm.checkout.model.CheckoutBean.setShippingAddress(AddressBean) may expose internal representation by storing an externally mutable object into CheckoutBean.shippingAddress | MALICIOUS_CODE | EI_EXPOSE_REP2 | 18 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryBean.getDate() may expose internal representation by returning OrderHistoryBean.date | MALICIOUS_CODE | EI_EXPOSE_REP | 43 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryBean.setDate(Date) may expose internal representation by storing an externally mutable object into OrderHistoryBean.date | MALICIOUS_CODE | EI_EXPOSE_REP2 | 46 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.getOrder() may expose internal representation by returning OrderHistoryDetailsBean.order | MALICIOUS_CODE | EI_EXPOSE_REP | 18 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.getOrderProducts() may expose internal representation by returning OrderHistoryDetailsBean.orderProducts | MALICIOUS_CODE | EI_EXPOSE_REP | 36 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.getOrderStatus() may expose internal representation by returning OrderHistoryDetailsBean.orderStatus | MALICIOUS_CODE | EI_EXPOSE_REP | 24 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.getOrderStatusHistoryBeans() may expose internal representation by returning OrderHistoryDetailsBean.orderStatusHistoryBeans | MALICIOUS_CODE | EI_EXPOSE_REP | 42 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.getOrderTotal() may expose internal representation by returning OrderHistoryDetailsBean.orderTotal | MALICIOUS_CODE | EI_EXPOSE_REP | 30 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.setOrder(Order) may expose internal representation by storing an externally mutable object into OrderHistoryDetailsBean.order | MALICIOUS_CODE | EI_EXPOSE_REP2 | 21 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.setOrderProducts(List) may expose internal representation by storing an externally mutable object into OrderHistoryDetailsBean.orderProducts | MALICIOUS_CODE | EI_EXPOSE_REP2 | 39 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.setOrderStatus(OrderStatus) may expose internal representation by storing an externally mutable object into OrderHistoryDetailsBean.orderStatus | MALICIOUS_CODE | EI_EXPOSE_REP2 | 27 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.setOrderStatusHistoryBeans(List) may expose internal representation by storing an externally mutable object into OrderHistoryDetailsBean.orderStatusHistoryBeans | MALICIOUS_CODE | EI_EXPOSE_REP2 | 46 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderHistoryDetailsBean.setOrderTotal(List) may expose internal representation by storing an externally mutable object into OrderHistoryDetailsBean.orderTotal | MALICIOUS_CODE | EI_EXPOSE_REP2 | 33 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.checkout.model.OrderStatusHistoryBean.getDateAdded() may expose internal representation by returning OrderStatusHistoryBean.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 23 | Medium |
new org.woehlke.greenshop.oodm.checkout.model.OrderStatusHistoryBean(Date, String, String) may expose internal representation by storing an externally mutable object into OrderStatusHistoryBean.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 13 | Medium |
org.woehlke.greenshop.oodm.checkout.model.OrderStatusHistoryBean.setDateAdded(Date) may expose internal representation by storing an externally mutable object into OrderStatusHistoryBean.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 27 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to transientAddress in org.woehlke.greenshop.oodm.customer.CustomerServiceImpl.addAddress(AddressBook) | STYLE | DLS_DEAD_LOCAL_STORE | 187 | Medium |
Dead store to defaultAddress in org.woehlke.greenshop.oodm.customer.CustomerServiceImpl.createNewCustomer(CreateNewCustomerFormBean) | STYLE | DLS_DEAD_LOCAL_STORE | 83 | Medium |
Dead store to zones in org.woehlke.greenshop.oodm.customer.CustomerServiceImpl.createNewCustomer(CreateNewCustomerFormBean) | STYLE | DLS_DEAD_LOCAL_STORE | 75 | Medium |
Dead store to persistentAddress in org.woehlke.greenshop.oodm.customer.CustomerServiceImpl.updateAddressBook(AddressBook) | STYLE | DLS_DEAD_LOCAL_STORE | 175 | Medium |
Dead store to customer in org.woehlke.greenshop.oodm.customer.CustomerServiceImpl.updateCustomer(Customer) | STYLE | DLS_DEAD_LOCAL_STORE | 158 | Medium |
Redundant nullcheck of notification, which is known to be non-null in org.woehlke.greenshop.oodm.customer.CustomerServiceImpl.addProductNotification(Product, Customer) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 226 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.customer.entities.AddressBook.getCountry() may expose internal representation by returning AddressBook.country | MALICIOUS_CODE | EI_EXPOSE_REP | 164 | Medium |
org.woehlke.greenshop.oodm.customer.entities.AddressBook.getCustomer() may expose internal representation by returning AddressBook.customer | MALICIOUS_CODE | EI_EXPOSE_REP | 84 | Medium |
org.woehlke.greenshop.oodm.customer.entities.AddressBook.setCountry(Country) may expose internal representation by storing an externally mutable object into AddressBook.country | MALICIOUS_CODE | EI_EXPOSE_REP2 | 168 | Medium |
org.woehlke.greenshop.oodm.customer.entities.AddressBook.setCustomer(Customer) may expose internal representation by storing an externally mutable object into AddressBook.customer | MALICIOUS_CODE | EI_EXPOSE_REP2 | 88 | Medium |
Suspicious comparison of Long references in org.woehlke.greenshop.oodm.customer.entities.AddressBook.isPrimaryAddress() | CORRECTNESS | RC_REF_COMPARISON | 196 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.customer.entities.Country.getAddressFormat() may expose internal representation by returning Country.addressFormat | MALICIOUS_CODE | EI_EXPOSE_REP | 91 | Medium |
org.woehlke.greenshop.oodm.customer.entities.Country.setAddressFormat(AddressFormat) may expose internal representation by storing an externally mutable object into Country.addressFormat | MALICIOUS_CODE | EI_EXPOSE_REP2 | 95 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.customer.entities.Customer.getDefaultAddress() may expose internal representation by returning Customer.defaultAddress | MALICIOUS_CODE | EI_EXPOSE_REP | 140 | Medium |
org.woehlke.greenshop.oodm.customer.entities.Customer.getDob() may expose internal representation by returning Customer.dob | MALICIOUS_CODE | EI_EXPOSE_REP | 124 | Medium |
org.woehlke.greenshop.oodm.customer.entities.Customer.setDefaultAddress(AddressBook) may expose internal representation by storing an externally mutable object into Customer.defaultAddress | MALICIOUS_CODE | EI_EXPOSE_REP2 | 144 | Medium |
org.woehlke.greenshop.oodm.customer.entities.Customer.setDob(Date) may expose internal representation by storing an externally mutable object into Customer.dob | MALICIOUS_CODE | EI_EXPOSE_REP2 | 128 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.customer.entities.CustomerInfo.getAccountCreated() may expose internal representation by returning CustomerInfo.accountCreated | MALICIOUS_CODE | EI_EXPOSE_REP | 79 | Medium |
org.woehlke.greenshop.oodm.customer.entities.CustomerInfo.getAccountLastModified() may expose internal representation by returning CustomerInfo.accountLastModified | MALICIOUS_CODE | EI_EXPOSE_REP | 87 | Medium |
org.woehlke.greenshop.oodm.customer.entities.CustomerInfo.getLastLogin() may expose internal representation by returning CustomerInfo.lastLogin | MALICIOUS_CODE | EI_EXPOSE_REP | 63 | Medium |
org.woehlke.greenshop.oodm.customer.entities.CustomerInfo.getPasswordResetDate() may expose internal representation by returning CustomerInfo.passwordResetDate | MALICIOUS_CODE | EI_EXPOSE_REP | 112 | Medium |
org.woehlke.greenshop.oodm.customer.entities.CustomerInfo.setAccountCreated(Date) may expose internal representation by storing an externally mutable object into CustomerInfo.accountCreated | MALICIOUS_CODE | EI_EXPOSE_REP2 | 83 | Medium |
org.woehlke.greenshop.oodm.customer.entities.CustomerInfo.setAccountLastModified(Date) may expose internal representation by storing an externally mutable object into CustomerInfo.accountLastModified | MALICIOUS_CODE | EI_EXPOSE_REP2 | 91 | Medium |
org.woehlke.greenshop.oodm.customer.entities.CustomerInfo.setLastLogin(Date) may expose internal representation by storing an externally mutable object into CustomerInfo.lastLogin | MALICIOUS_CODE | EI_EXPOSE_REP2 | 67 | Medium |
org.woehlke.greenshop.oodm.customer.entities.CustomerInfo.setPasswordResetDate(Date) may expose internal representation by storing an externally mutable object into CustomerInfo.passwordResetDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 116 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.customer.entities.ProductNotification.getDateAdded() may expose internal representation by returning ProductNotification.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP | 40 | Medium |
org.woehlke.greenshop.oodm.customer.entities.ProductNotification.getId() may expose internal representation by returning ProductNotification.id | MALICIOUS_CODE | EI_EXPOSE_REP | 32 | Medium |
org.woehlke.greenshop.oodm.customer.entities.ProductNotification.setDateAdded(Date) may expose internal representation by storing an externally mutable object into ProductNotification.dateAdded | MALICIOUS_CODE | EI_EXPOSE_REP2 | 44 | Medium |
org.woehlke.greenshop.oodm.customer.entities.ProductNotification.setId(ProductNotificationId) may expose internal representation by storing an externally mutable object into ProductNotification.id | MALICIOUS_CODE | EI_EXPOSE_REP2 | 36 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.customer.entities.ProductNotificationId is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 19-67 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.customer.entities.Zone.getCountry() may expose internal representation by returning Zone.country | MALICIOUS_CODE | EI_EXPOSE_REP | 55 | Medium |
org.woehlke.greenshop.oodm.customer.entities.Zone.setCountry(Country) may expose internal representation by storing an externally mutable object into Zone.country | MALICIOUS_CODE | EI_EXPOSE_REP2 | 59 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
ChangePasswordBean.passwordNew not initialized in constructor and dereferenced in org.woehlke.greenshop.oodm.customer.model.ChangePasswordBean.isConfirmed() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 62 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
CreateNewCustomerFormBean.password not initialized in constructor and dereferenced in org.woehlke.greenshop.oodm.customer.model.CreateNewCustomerFormBean.passwordsMatch() | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 194 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.woehlke.greenshop.oodm.customer.model.CustomerBean.getCustomer() may expose internal representation by returning CustomerBean.customer | MALICIOUS_CODE | EI_EXPOSE_REP | 15 | Medium |
org.woehlke.greenshop.oodm.customer.model.CustomerBean.getCustomerInfo() may expose internal representation by returning CustomerBean.customerInfo | MALICIOUS_CODE | EI_EXPOSE_REP | 23 | Medium |
org.woehlke.greenshop.oodm.customer.model.CustomerBean.setCustomer(Customer) may expose internal representation by storing an externally mutable object into CustomerBean.customer | MALICIOUS_CODE | EI_EXPOSE_REP2 | 19 | Medium |
org.woehlke.greenshop.oodm.customer.model.CustomerBean.setCustomerInfo(CustomerInfo) may expose internal representation by storing an externally mutable object into CustomerBean.customerInfo | MALICIOUS_CODE | EI_EXPOSE_REP2 | 27 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to thisZone in org.woehlke.greenshop.oodm.customer.service.ZoneServiceImpl.createZone(Zone) | STYLE | DLS_DEAD_LOCAL_STORE | 54 | Medium |
Dead store to thisZone in org.woehlke.greenshop.oodm.customer.service.ZoneServiceImpl.update(Zone) | STYLE | DLS_DEAD_LOCAL_STORE | 65 | Medium |